* usb-serial.c:1415 code aligned with following code on line 1416
@ 2012-09-19 0:57 Fengguang Wu
2012-09-19 7:14 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Fengguang Wu @ 2012-09-19 0:57 UTC (permalink / raw)
To: kernel-janitors
Hi Greg,
FYI, coccinelle warns about
drivers/usb/serial/usb-serial.c:1415:3-51: code aligned with following code on line 1416
vim +1415 drivers/usb/serial/usb-serial.c
1412 /* we only set the reset_resume field if the serial_driver has one */
1413 for (sd = serial_drivers; *sd; ++sd) {
1414 if ((*sd)->reset_resume)
> 1415 udriver->reset_resume = usb_serial_reset_resume;
> 1416 break;
1417 }
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: usb-serial.c:1415 code aligned with following code on line 1416
2012-09-19 0:57 usb-serial.c:1415 code aligned with following code on line 1416 Fengguang Wu
@ 2012-09-19 7:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2012-09-19 7:14 UTC (permalink / raw)
To: kernel-janitors
On Wed, Sep 19, 2012 at 08:57:00AM +0800, Fengguang Wu wrote:
> Hi Greg,
>
> FYI, coccinelle warns about
>
> drivers/usb/serial/usb-serial.c:1415:3-51: code aligned with following code on line 1416
>
> vim +1415 drivers/usb/serial/usb-serial.c
>
> 1412 /* we only set the reset_resume field if the serial_driver has one */
> 1413 for (sd = serial_drivers; *sd; ++sd) {
> 1414 if ((*sd)->reset_resume)
> > 1415 udriver->reset_resume = usb_serial_reset_resume;
> > 1416 break;
> 1417 }
Ah, nice catch, that's been there for a while now (since 3.5-rc1), I'll
go fix it up.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-19 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 0:57 usb-serial.c:1415 code aligned with following code on line 1416 Fengguang Wu
2012-09-19 7:14 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.