From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
alsa-devel@alsa-project.org, Anatolij Gustschin <agust@denx.de>,
linuxppc-dev@lists.ozlabs.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 5/7] ASoC: fsl: convert pcm030-audio-fabric to a platform-driver
Date: Tue, 18 Sep 2012 23:03:24 -0400 [thread overview]
Message-ID: <20120919030324.GO8832@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347572596-37540-6-git-send-email-emillbrandt@dekaresearch.com>
On Thu, Sep 13, 2012 at 05:43:14PM -0400, Eric Millbrandt wrote:
> +static int __devexit pcm030_fabric_remove(struct platform_device *op)
> +{
> + struct platform_device *pdev = platform_get_drvdata(op);
> +
> + platform_device_unregister(pdev);
> +
> + return 0;
> +}
This seems really confused... why is a platform device registering
another platform device? Do you mean to convert to
snd_soc_register_card()?
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: alsa-devel@alsa-project.org, Anatolij Gustschin <agust@denx.de>,
linuxppc-dev@lists.ozlabs.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 5/7] ASoC: fsl: convert pcm030-audio-fabric to a platform-driver
Date: Tue, 18 Sep 2012 23:03:24 -0400 [thread overview]
Message-ID: <20120919030324.GO8832@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347572596-37540-6-git-send-email-emillbrandt@dekaresearch.com>
On Thu, Sep 13, 2012 at 05:43:14PM -0400, Eric Millbrandt wrote:
> +static int __devexit pcm030_fabric_remove(struct platform_device *op)
> +{
> + struct platform_device *pdev = platform_get_drvdata(op);
> +
> + platform_device_unregister(pdev);
> +
> + return 0;
> +}
This seems really confused... why is a platform device registering
another platform device? Do you mean to convert to
snd_soc_register_card()?
next prev parent reply other threads:[~2012-09-19 3:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 21:43 [RFC 0/7] mpc5200 ASoC and pcm030 board fixes Eric Millbrandt
2012-09-13 21:43 ` [PATCH 1/7] powerpc/52xx: define FSL_SOC Eric Millbrandt
2012-09-14 9:31 ` agust
2012-09-14 14:45 ` Eric Millbrandt
2012-09-14 14:45 ` Eric Millbrandt
2012-09-13 21:43 ` [PATCH 2/7] ASoC: fsl: mpc5200 combine psc_dma platform data Eric Millbrandt
2012-09-19 3:03 ` Mark Brown
2012-09-19 3:03 ` Mark Brown
2012-09-13 21:43 ` [PATCH 3/7] ASoC: fsl: mpc5200 add missing information to snd_soc_dai_driver Eric Millbrandt
2012-09-19 3:04 ` Mark Brown
2012-09-19 3:04 ` Mark Brown
2012-09-13 21:43 ` [PATCH 4/7] ASoC: fsl: cleanup headers in pcm030-audio-fabric Eric Millbrandt
2012-09-19 3:04 ` Mark Brown
2012-09-19 3:04 ` Mark Brown
2012-09-13 21:43 ` [PATCH 5/7] ASoC: fsl: convert pcm030-audio-fabric to a platform-driver Eric Millbrandt
2012-09-19 3:03 ` Mark Brown [this message]
2012-09-19 3:03 ` Mark Brown
2012-09-19 14:35 ` Eric Millbrandt
2012-09-19 14:35 ` Eric Millbrandt
2012-09-19 20:46 ` Mark Brown
2012-09-19 20:46 ` Mark Brown
2012-09-13 21:43 ` [PATCH 6/7] ASoC: fsl: convert pcm030-audio-fabric to use snd_soc_register_card Eric Millbrandt
2012-09-13 21:43 ` [PATCH 7/7] ASoC: fsl: register the wm9712-codec Eric Millbrandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919030324.GO8832@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=agust@denx.de \
--cc=alsa-devel@alsa-project.org \
--cc=emillbrandt@dekaresearch.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.