From: Theodore Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: ext4: convert file system to meta_bg if needed during resizing
Date: Wed, 19 Sep 2012 03:51:32 +0000 [thread overview]
Message-ID: <20120919035132.GB18707@thunk.org> (raw)
In-Reply-To: <20120918114634.GA12383@elgon.mountain>
On Tue, Sep 18, 2012 at 02:46:35PM +0300, Dan Carpenter wrote:
> 1775 struct ext4_inode_info *ei = 0;
> ^^^^^^
> Sparse is going to complain. Not sure why Fengguang hasn't emailed you.
> 1791 ei = EXT4_I(inode);
> ^^^^^^^^^^^^^^^^^^
> We only set "ei" if EXT4_FEATURE_COMPAT_RESIZE_INODE.
> ...
> 1829 nr = le32_to_cpu(ei->i_data[EXT4_DIND_BLOCK]);
> ^^^^^^^^^^
> Null deref. Perhaps inode implies EXT4_FEATURE_COMPAT_RESIZE_INODE?
Inode does imply EXT4_FEATURE_COMPAT_RESIZE_INODE, but I should make
the code cleaner.
Thanks for pointing this out.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: ext4: convert file system to meta_bg if needed during resizing
Date: Tue, 18 Sep 2012 23:51:32 -0400 [thread overview]
Message-ID: <20120919035132.GB18707@thunk.org> (raw)
In-Reply-To: <20120918114634.GA12383@elgon.mountain>
On Tue, Sep 18, 2012 at 02:46:35PM +0300, Dan Carpenter wrote:
> 1775 struct ext4_inode_info *ei = 0;
> ^^^^^^
> Sparse is going to complain. Not sure why Fengguang hasn't emailed you.
> 1791 ei = EXT4_I(inode);
> ^^^^^^^^^^^^^^^^^^
> We only set "ei" if EXT4_FEATURE_COMPAT_RESIZE_INODE.
> ...
> 1829 nr = le32_to_cpu(ei->i_data[EXT4_DIND_BLOCK]);
> ^^^^^^^^^^
> Null deref. Perhaps inode implies EXT4_FEATURE_COMPAT_RESIZE_INODE?
Inode does imply EXT4_FEATURE_COMPAT_RESIZE_INODE, but I should make
the code cleaner.
Thanks for pointing this out.
- Ted
next prev parent reply other threads:[~2012-09-19 3:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 11:46 ext4: convert file system to meta_bg if needed during resizing Dan Carpenter
2012-09-18 11:46 ` Dan Carpenter
2012-09-18 11:52 ` Fengguang Wu
2012-09-18 11:52 ` Fengguang Wu
2012-09-19 3:51 ` Theodore Ts'o [this message]
2012-09-19 3:51 ` Theodore Ts'o
2012-09-19 4:56 ` [PATCH] ext4: fix online resizing when the # of block groups is constant Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2020-02-29 0:39 ext4: convert file system to meta_bg if needed during resizing Colin Ian King
2020-02-29 17:42 ` Theodore Y. Ts'o
2020-02-29 17:52 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919035132.GB18707@thunk.org \
--to=tytso@mit.edu \
--cc=dan.carpenter@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.