* [PATCH] MIPS: hide USE_OF
@ 2012-09-18 9:28 Jonas Gorski
2012-09-19 13:36 ` Ralf Baechle
2012-09-23 17:24 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Jonas Gorski @ 2012-09-18 9:28 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, David Daney
b01da9f1 ("MIPS: Prune some target specific code out of prom.c") removed
the generic implementation of device_tree_init, breaking the kernel
build when manually selecting USE_OF.
Hide the config symbol so it can't be selected acidentially anymore.
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
There are two alternatives I have thought of:
a) Make HAVE_OF depend on an additional config symbol selected by targets
supporting OF.
and
b) create a weak implementation of device_tree_init.
Both depend on the assumption that there are/will be targets that support
booting with and without OF, but I don't know if anyone really wants that.
arch/mips/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 678931c..529fb19 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2408,12 +2408,10 @@ config SECCOMP
If unsure, say Y. Only embedded should say N here.
config USE_OF
- bool "Flattened Device Tree support"
+ bool
select OF
select OF_EARLY_FLATTREE
select IRQ_DOMAIN
- help
- Include support for flattened device tree machine descriptions.
endmenu
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: hide USE_OF
2012-09-18 9:28 [PATCH] MIPS: hide USE_OF Jonas Gorski
@ 2012-09-19 13:36 ` Ralf Baechle
2012-09-23 17:24 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2012-09-19 13:36 UTC (permalink / raw)
To: Jonas Gorski; +Cc: linux-mips, David Daney
On Tue, Sep 18, 2012 at 11:28:54AM +0200, Jonas Gorski wrote:
> b01da9f1 ("MIPS: Prune some target specific code out of prom.c") removed
> the generic implementation of device_tree_init, breaking the kernel
> build when manually selecting USE_OF.
>
> Hide the config symbol so it can't be selected acidentially anymore.
I'm inclined to accept this patch but would like to wait for a little
longer for others' opinions.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: hide USE_OF
2012-09-18 9:28 [PATCH] MIPS: hide USE_OF Jonas Gorski
2012-09-19 13:36 ` Ralf Baechle
@ 2012-09-23 17:24 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2012-09-23 17:24 UTC (permalink / raw)
To: Jonas Gorski; +Cc: linux-mips, David Daney
On Tue, Sep 18, 2012 at 11:28:54AM +0200, Jonas Gorski wrote:
> b01da9f1 ("MIPS: Prune some target specific code out of prom.c") removed
> the generic implementation of device_tree_init, breaking the kernel
> build when manually selecting USE_OF.
Applied. Thanks,
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-23 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-18 9:28 [PATCH] MIPS: hide USE_OF Jonas Gorski
2012-09-19 13:36 ` Ralf Baechle
2012-09-23 17:24 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.