All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/5] snd-ice1712: Add Philips PSC724	Ultimate Edge
Date: Wed, 19 Sep 2012 19:03:14 +0200	[thread overview]
Message-ID: <201209191903.14690.linux@rainbow-software.org> (raw)
In-Reply-To: <s5h392eyqui.wl%tiwai@suse.de>

On Wednesday 19 September 2012 17:28:21 Takashi Iwai wrote:
> At Tue, 18 Sep 2012 20:58:31 +0200,
>
> Ondrej Zary wrote:
> > Hello,
> > this is second attempt to add Philips PSC724 Ultimate Edge sound card
> > support to snd-ice1712 driver. Unlike other snd-ice1712 subdrivers, the
> > codec code is splitted into separate modules and thus reusable by other
> > ice1712 subdrivers.
>
> Well, the problem is that most of ice17xx boards use only a part of
> channels on codecs.   Thus you don't want to expose controls for all
> channels, too.  Otherwise user will get confusing dead controls.

The controls can be easily hidden by setting its name to NULL. It's even used 
in the psc724 subdriver.

> If these new modules are supposed to be used by other ice1712/ice1724
> sub drivers, they should provide some good binding mechanism, too.
> (And that's one of the good reasons why ASoC has been nominated.)

They're easy to use, you just need to provide wm87x6_write() function. I think 
that other subdrivers could be easily converted to use this (with hardware to 
test).

> thanks,
>
> Takashi
>
> > Working: all analog outputs (front, rear, center+lfe, headphone) and
> > inputs (front mic, rear mic, line, cd, aux), mixer, headphone jack
> > detection, suspend/resume
> >
> > Currently untested: SPDIF
> >
> > Buggy: switching AGC mode in mixer causes alsamixer to crash - looks like
> > it does not like notifications about control activating/deactivating
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Ondrej Zary <linux@rainbow-software.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [RFC PATCH v2 0/5] snd-ice1712: Add Philips PSC724	Ultimate Edge
Date: Wed, 19 Sep 2012 19:03:14 +0200	[thread overview]
Message-ID: <201209191903.14690.linux@rainbow-software.org> (raw)
In-Reply-To: <s5h392eyqui.wl%tiwai@suse.de>

On Wednesday 19 September 2012 17:28:21 Takashi Iwai wrote:
> At Tue, 18 Sep 2012 20:58:31 +0200,
>
> Ondrej Zary wrote:
> > Hello,
> > this is second attempt to add Philips PSC724 Ultimate Edge sound card
> > support to snd-ice1712 driver. Unlike other snd-ice1712 subdrivers, the
> > codec code is splitted into separate modules and thus reusable by other
> > ice1712 subdrivers.
>
> Well, the problem is that most of ice17xx boards use only a part of
> channels on codecs.   Thus you don't want to expose controls for all
> channels, too.  Otherwise user will get confusing dead controls.

The controls can be easily hidden by setting its name to NULL. It's even used 
in the psc724 subdriver.

> If these new modules are supposed to be used by other ice1712/ice1724
> sub drivers, they should provide some good binding mechanism, too.
> (And that's one of the good reasons why ASoC has been nominated.)

They're easy to use, you just need to provide wm87x6_write() function. I think 
that other subdrivers could be easily converted to use this (with hardware to 
test).

> thanks,
>
> Takashi
>
> > Working: all analog outputs (front, rear, center+lfe, headphone) and
> > inputs (front mic, rear mic, line, cd, aux), mixer, headphone jack
> > detection, suspend/resume
> >
> > Currently untested: SPDIF
> >
> > Buggy: switching AGC mode in mixer causes alsamixer to crash - looks like
> > it does not like notifications about control activating/deactivating
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


  reply	other threads:[~2012-09-19 17:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 18:58 [RFC PATCH v2 0/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-09-18 18:58 ` Ondrej Zary
2012-09-18 18:58 ` [PATCH 1/5] snd-ice1712: add chip_exit callback Ondrej Zary
2012-09-18 18:58   ` Ondrej Zary
2012-09-18 18:58 ` [PATCH 2/5] snd-ice1712: Add Wolfson Microelectronics WM8766 codec support Ondrej Zary
2012-09-18 18:58   ` Ondrej Zary
2012-09-18 18:58 ` [PATCH 3/5] snd-ice1712: Add Wolfson Microelectronics WM8776 " Ondrej Zary
2012-09-18 18:58   ` Ondrej Zary
2012-09-18 18:58 ` [PATCH 4/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-09-18 18:58   ` Ondrej Zary
2012-09-18 18:58 ` [PATCH 5/5] snd-ice1712: Fix resume on ice1724 Ondrej Zary
2012-09-18 18:58   ` Ondrej Zary
2012-09-19 15:28 ` [RFC PATCH v2 0/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Takashi Iwai
2012-09-19 15:28   ` [alsa-devel] " Takashi Iwai
2012-09-19 17:03   ` Ondrej Zary [this message]
2012-09-19 17:03     ` Ondrej Zary
2012-09-19 17:58     ` Takashi Iwai
2012-09-19 17:58       ` [alsa-devel] " Takashi Iwai
2012-09-19 21:48       ` Ondrej Zary
2012-09-19 21:48         ` [alsa-devel] " Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209191903.14690.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.