All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: linux-ext4@vger.kernel.org
Subject: Re: [v2] ext4: fix possible non-initialized variable
Date: Wed, 19 Sep 2012 17:10:57 -0300	[thread overview]
Message-ID: <20120919201057.GA23237@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <20120918125155.GA30408@andromeda.usersys.redhat.com>

> > OK, I've applied this patch to my tree.  However, I would really
> > appreciate if you could indeed review the callers for ext4_bread() and
> > ext3_bread() and send patches for ext3 and ext4 as you have suggested,
> > thanks!!
> > 
> On my todo list.
> > 						- Ted
Ted,

In case of ext4_add_entry() I'm supposing to make the function call ext4_error()
and return -EIO in the case where ext4_bread() returns NULL and err is 0'ed,
does that matches with your thoughts or is there a better way to handle with
this?
I'm talking about ext4_add_entry() behavious mainly as an example to better
understand how we should handle these situations. In case of ext4_add_entry(),
based on our discussions ext4_bread() should not fail once dir entries should
not have HOLES, so, a NULL return should indicate a on-disk corruption or an I/O
error.

Does that makes sense?

-- 
--Carlos

  reply	other threads:[~2012-09-19 20:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 21:55 [PATCH v2] ext4: fix possible non-initialized variable Carlos Maiolino
2012-09-15 18:30 ` [v2] " Theodore Ts'o
2012-09-17 14:55   ` Eric Sandeen
2012-09-17 15:30     ` Eric Sandeen
2012-09-17 15:37       ` Theodore Ts'o
2012-09-17 18:26         ` Carlos Maiolino
2012-09-18  3:59           ` Theodore Ts'o
2012-09-18 12:51             ` Carlos Maiolino
2012-09-19 20:10               ` Carlos Maiolino [this message]
2012-09-19 20:41                 ` Theodore Ts'o
2012-09-20  2:59                   ` Eric Sandeen
2012-09-21 19:14                     ` Carlos Maiolino
2012-09-22  0:52                       ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120919201057.GA23237@andromeda.usersys.redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.