Re: [v2] ext4: fix possible non-initialized variable

[Theodore Ts'o <tytso@mit.edu>]

On Fri, Sep 21, 2012 at 04:14:49PM -0300, Carlos Maiolino wrote:
> Not a bad idea really.
> 
> I've found some functions properly handling the problem (i.e !bh and !err), but
> some of them not. I'm thinking in fix functions with missing hole handlers and
> after that think about a 'default directory hole handler' for this, instead of
> make each function work on a specific way.

I'd have to take a look at a patch, but I didn't think there would be
enough code to be worth factoring out into a separate function.  It's
just a conditional, a call to ext4_error(), and then setting up the
return code and releasing resources that need to be released on our
way out (which tends to be function-specific).

Am I missing something?

						- Ted