All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Krishna Gudipati <kgudipat@brocade.com>
Cc: kernel-janitors@vger.kernel.org,
	James Bottomley <JBottomley@Parallels.com>,
	linux-scsi@vger.kernel.org
Subject: bfa_ioc.c:3407 code aligned with following code on line 3409
Date: Thu, 20 Sep 2012 08:58:56 +0000	[thread overview]
Message-ID: <20120920085856.GA6724@localhost> (raw)

Hi Krishna,

According to these (old) coccinelle warnings, bfa_cb_sfp_state_query() has very
weird indents and "if" blocks:

  drivers/scsi/bfa/bfa_ioc.c:3407:3-18: code aligned with following code on line 3409
  drivers/scsi/bfa/bfa_ioc.c:3415:4-19: code aligned with following code on line 3417

        3400 static void
        3401 bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
        3402 {
        3403         bfa_trc(sfp, sfp->portspeed);
        3404         if (sfp->media) {
        3405                 bfa_sfp_media_get(sfp);
        3406                 if (sfp->state_query_cbfn)
>       3407                         sfp->state_query_cbfn(sfp->state_query_cbarg,
        3408                                         sfp->status);
        3409                         sfp->media = NULL;
        3410                 }
        3411 
        3412                 if (sfp->portspeed) {
        3413                         sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
        3414                         if (sfp->state_query_cbfn)
        3415                                 sfp->state_query_cbfn(sfp->state_query_cbarg,
        3416                                                 sfp->status);
>       3417                                 sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
        3418                 }
        3419 
        3420                 sfp->state_query_lock = 0;
        3421                 sfp->state_query_cbfn = NULL;
        3422 }

The code was introduced by

commit 51e569aa1f0c10bd71af05e76e4ba0e42c51e4ab
Author:     Krishna Gudipati <kgudipat@brocade.com>
Commit:     James Bottomley <JBottomley@Parallels.com>
CommitDate: Wed Jun 29 17:22:26 2011 -0500

    [SCSI] bfa: Added support to obtain SFP info.

Thanks,
Fengguang

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Krishna Gudipati <kgudipat@brocade.com>
Cc: kernel-janitors@vger.kernel.org,
	James Bottomley <JBottomley@Parallels.com>,
	linux-scsi@vger.kernel.org
Subject: bfa_ioc.c:3407 code aligned with following code on line 3409
Date: Thu, 20 Sep 2012 16:58:56 +0800	[thread overview]
Message-ID: <20120920085856.GA6724@localhost> (raw)

Hi Krishna,

According to these (old) coccinelle warnings, bfa_cb_sfp_state_query() has very
weird indents and "if" blocks:

  drivers/scsi/bfa/bfa_ioc.c:3407:3-18: code aligned with following code on line 3409
  drivers/scsi/bfa/bfa_ioc.c:3415:4-19: code aligned with following code on line 3417

        3400 static void
        3401 bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
        3402 {
        3403         bfa_trc(sfp, sfp->portspeed);
        3404         if (sfp->media) {
        3405                 bfa_sfp_media_get(sfp);
        3406                 if (sfp->state_query_cbfn)
>       3407                         sfp->state_query_cbfn(sfp->state_query_cbarg,
        3408                                         sfp->status);
        3409                         sfp->media = NULL;
        3410                 }
        3411 
        3412                 if (sfp->portspeed) {
        3413                         sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
        3414                         if (sfp->state_query_cbfn)
        3415                                 sfp->state_query_cbfn(sfp->state_query_cbarg,
        3416                                                 sfp->status);
>       3417                                 sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
        3418                 }
        3419 
        3420                 sfp->state_query_lock = 0;
        3421                 sfp->state_query_cbfn = NULL;
        3422 }

The code was introduced by

commit 51e569aa1f0c10bd71af05e76e4ba0e42c51e4ab
Author:     Krishna Gudipati <kgudipat@brocade.com>
Commit:     James Bottomley <JBottomley@Parallels.com>
CommitDate: Wed Jun 29 17:22:26 2011 -0500

    [SCSI] bfa: Added support to obtain SFP info.

Thanks,
Fengguang

             reply	other threads:[~2012-09-20  8:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20  8:58 Fengguang Wu [this message]
2012-09-20  8:58 ` bfa_ioc.c:3407 code aligned with following code on line 3409 Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120920085856.GA6724@localhost \
    --to=fengguang.wu@intel.com \
    --cc=JBottomley@Parallels.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kgudipat@brocade.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.