From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (net-next tree related)
Date: Thu, 20 Sep 2012 12:10:14 +0300 [thread overview]
Message-ID: <20120920091013.GV15548@intel.com> (raw)
In-Reply-To: <20120920173622.2aa7209cd241a3945f4384d4@canb.auug.org.au>
On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
> drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of function 'isa_virt_to_bus' [-Werror=implicit-function-declaration]
>
> Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when
> building a 64-bit kernel"). Is there some Kconfig dependency missing (CONFIG_ISA)?
If we make it dependent on CONFIG_ISA then the driver cannot be built with
64-bit kernel. Then again is there someone running 64-bit kernel on Zenith
Z-note notebook? From the pictures it looks like very ancient "laptop".
An alternative is to make it depend on X86 like this:
diff --git a/drivers/net/ethernet/i825xx/Kconfig b/drivers/net/ethernet/i825xx/Kconfig
index fed5080..959faf7 100644
--- a/drivers/net/ethernet/i825xx/Kconfig
+++ b/drivers/net/ethernet/i825xx/Kconfig
@@ -150,7 +150,7 @@ config SUN3_82586
config ZNET
tristate "Zenith Z-Note support (EXPERIMENTAL)"
- depends on EXPERIMENTAL && ISA_DMA_API
+ depends on EXPERIMENTAL && ISA_DMA_API && X86
---help---
The Zenith Z-Note notebook computer has a built-in network
(Ethernet) card, and this is the Linux driver for it. Note that the
next prev parent reply other threads:[~2012-09-20 9:10 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 7:36 linux-next: build failure after merge of the final tree (net-next tree related) Stephen Rothwell
2012-09-20 7:36 ` Stephen Rothwell
2012-09-20 9:10 ` Mika Westerberg [this message]
2012-09-20 20:45 ` David Miller
2012-09-20 22:15 ` Stephen Rothwell
2012-09-20 22:15 ` Stephen Rothwell
2012-09-20 22:15 ` Stephen Rothwell
2012-09-20 22:22 ` Benjamin Herrenschmidt
2012-09-20 22:22 ` Benjamin Herrenschmidt
2012-09-20 22:53 ` David Miller
2012-09-20 22:53 ` David Miller
2012-09-21 21:46 ` Benjamin Herrenschmidt
2012-09-21 21:46 ` Benjamin Herrenschmidt
2012-09-22 20:00 ` David Miller
2012-09-22 20:00 ` David Miller
2012-09-22 21:20 ` Benjamin Herrenschmidt
2012-09-22 21:20 ` Benjamin Herrenschmidt
2012-09-20 22:28 ` Stephen Rothwell
2012-09-20 22:28 ` Stephen Rothwell
2012-09-20 22:28 ` Stephen Rothwell
2012-09-21 1:37 ` Stephen Rothwell
2012-09-21 1:37 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 7:27 Stephen Rothwell
2014-03-18 7:27 ` Stephen Rothwell
2014-03-19 3:13 ` David Miller
2014-03-17 10:21 Stephen Rothwell
2014-03-17 10:21 ` Stephen Rothwell
2014-03-19 3:11 ` David Miller
2014-03-17 10:13 Stephen Rothwell
2014-03-17 10:13 ` Stephen Rothwell
2013-09-02 9:11 Stephen Rothwell
2013-09-02 9:11 ` Stephen Rothwell
2013-09-02 9:18 ` Cong Wang
2013-07-03 7:48 Stephen Rothwell
2013-07-03 7:48 ` Stephen Rothwell
2013-07-03 7:51 ` Sedat Dilek
2013-07-03 8:45 ` Eliezer Tamir
2013-07-03 19:17 ` David Miller
2013-06-26 7:56 Stephen Rothwell
2013-06-26 7:56 ` Stephen Rothwell
2013-06-26 8:07 ` Alexey Brodkin
2013-06-26 8:36 ` David Miller
2013-04-23 7:46 Stephen Rothwell
2013-04-23 7:46 ` Stephen Rothwell
2013-04-23 17:10 ` David Miller
2013-04-23 23:44 ` David Rientjes
2013-04-12 6:00 Stephen Rothwell
2013-04-12 6:00 ` Stephen Rothwell
2013-04-12 7:08 ` David Miller
2013-03-28 5:04 Stephen Rothwell
2013-03-28 5:04 ` Stephen Rothwell
2013-03-28 5:19 ` David Miller
2013-01-03 3:23 Stephen Rothwell
2013-01-03 3:23 ` Stephen Rothwell
2013-01-03 3:28 ` David Miller
2013-01-03 9:51 ` David Miller
2012-09-05 5:39 Stephen Rothwell
2012-09-05 5:39 ` Stephen Rothwell
2012-09-05 21:46 ` David Miller
2012-09-04 6:58 Stephen Rothwell
2012-09-04 18:20 ` David Miller
2012-09-04 19:50 ` Jerry Chu
2012-07-22 6:34 Stephen Rothwell
2012-07-22 7:29 ` Jiri Pirko
2012-05-03 6:16 Stephen Rothwell
2012-05-03 6:16 ` Stephen Rothwell
2012-05-03 6:26 ` David Miller
2012-04-30 5:58 Stephen Rothwell
2012-04-30 5:58 ` Stephen Rothwell
2012-04-30 17:22 ` David Miller
2012-04-19 6:28 Stephen Rothwell
2012-04-19 6:28 ` Stephen Rothwell
2012-04-19 6:40 ` David Miller
2012-04-10 5:29 Stephen Rothwell
2012-04-10 5:29 ` Stephen Rothwell
2012-04-10 13:26 ` David Miller
2012-04-05 3:25 Stephen Rothwell
2012-04-05 3:25 ` Stephen Rothwell
2012-04-05 3:59 ` David Miller
2012-04-06 7:09 ` Giuseppe CAVALLARO
2012-04-06 7:30 ` Giuseppe CAVALLARO
2012-02-20 5:15 Stephen Rothwell
2012-02-20 5:15 ` Stephen Rothwell
2012-02-20 5:46 ` David Miller
2011-12-14 7:07 Stephen Rothwell
2011-12-14 7:07 ` Stephen Rothwell
2011-12-14 18:35 ` David Miller
2011-11-23 4:00 Stephen Rothwell
2011-11-23 4:00 ` Stephen Rothwell
2011-11-23 12:09 ` Neil Horman
2011-11-23 23:02 ` Andrew Morton
2011-11-23 23:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920091013.GV15548@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.