From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: David Miller <davem@davemloft.net>,
sfr@canb.auug.org.au, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
deepak.sikri@st.com, shiraz.hashim@st.com, vikas.manocha@st.com
Subject: Re: linux-next: build failure after merge of the final tree (net-next tree related)
Date: Fri, 06 Apr 2012 09:30:02 +0200 [thread overview]
Message-ID: <4F7E9B7A.2080807@st.com> (raw)
In-Reply-To: <4F7E96B9.9060907@st.com>
On 4/6/2012 9:09 AM, Giuseppe CAVALLARO wrote:
> On 4/5/2012 5:59 AM, David Miller wrote:
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Thu, 5 Apr 2012 13:25:15 +1000
>>
>>> After merging the final tree, today's linux-next build (powerpc
>>> allyesconfig) failed like this:
>>>
>>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c: In function 'stmmac_probe_config_dt':
>>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:53:7: error: 'struct plat_stmmacenet_data' has no member named 'pbl'
>>>
>>> Caused by commit 8327eb65e795 ("stmmac: re-work the internal GMAC DMA
>>> platf parameters"). Clearly I am missing something, because I can't see
>>> how that patch is correct since nothing ever assigns to the new dma_cfg
>>> pointer but it is dereferenced.
>>>
>>> I have added this patch to make it build today, but it is obviously not
>>> correct.
>>
>> Sorry Stephen.
>>
>> Giuseppe don't submit patches to me that don't even compile.
>>
>> Please submit a proper fix to me for this _now_.
>
> Sorry Dave!
> I don't know what happened (I believed to test all).
> I'm sending you the patches soon!!!
Please Stephen,
can you test it on your kernel. I didn't build when CONFIG_OF is enable.
I tested on ARM/SH/x86 but never with CONFIG_OF on.
The problem was due to the hard-coded values adding with devicetree support.
Sorry for this problem, next time I'll build also on OF.
I had also done a grep in all the arch to verify the ARCH that used the
pbl/fixed_burst/burst_len fields :-(. These have been moved in a
separate structure.
Let me know if the patch is ok.
Peppe
>
> Peppe
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-04-06 7:31 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 3:25 linux-next: build failure after merge of the final tree (net-next tree related) Stephen Rothwell
2012-04-05 3:25 ` Stephen Rothwell
2012-04-05 3:59 ` David Miller
2012-04-06 7:09 ` Giuseppe CAVALLARO
2012-04-06 7:30 ` Giuseppe CAVALLARO [this message]
2012-04-06 7:25 ` [net-next] stmmac: fix build when CONFIG_OF is enable Giuseppe CAVALLARO
2012-04-06 7:34 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 7:27 linux-next: build failure after merge of the final tree (net-next tree related) Stephen Rothwell
2014-03-18 7:27 ` Stephen Rothwell
2014-03-19 3:13 ` David Miller
2014-03-17 10:21 Stephen Rothwell
2014-03-17 10:21 ` Stephen Rothwell
2014-03-19 3:11 ` David Miller
2014-03-17 10:13 Stephen Rothwell
2014-03-17 10:13 ` Stephen Rothwell
2013-09-02 9:11 Stephen Rothwell
2013-09-02 9:11 ` Stephen Rothwell
2013-09-02 9:18 ` Cong Wang
2013-07-03 7:48 Stephen Rothwell
2013-07-03 7:48 ` Stephen Rothwell
2013-07-03 7:51 ` Sedat Dilek
2013-07-03 8:45 ` Eliezer Tamir
2013-07-03 19:17 ` David Miller
2013-06-26 7:56 Stephen Rothwell
2013-06-26 7:56 ` Stephen Rothwell
2013-06-26 8:07 ` Alexey Brodkin
2013-06-26 8:36 ` David Miller
2013-04-23 7:46 Stephen Rothwell
2013-04-23 7:46 ` Stephen Rothwell
2013-04-23 17:10 ` David Miller
2013-04-23 23:44 ` David Rientjes
2013-04-12 6:00 Stephen Rothwell
2013-04-12 6:00 ` Stephen Rothwell
2013-04-12 7:08 ` David Miller
2013-03-28 5:04 Stephen Rothwell
2013-03-28 5:04 ` Stephen Rothwell
2013-03-28 5:19 ` David Miller
2013-01-03 3:23 Stephen Rothwell
2013-01-03 3:23 ` Stephen Rothwell
2013-01-03 3:28 ` David Miller
2013-01-03 9:51 ` David Miller
2012-09-20 7:36 Stephen Rothwell
2012-09-20 7:36 ` Stephen Rothwell
2012-09-20 9:10 ` Mika Westerberg
2012-09-20 20:45 ` David Miller
2012-09-20 22:15 ` Stephen Rothwell
2012-09-20 22:15 ` Stephen Rothwell
2012-09-20 22:15 ` Stephen Rothwell
2012-09-20 22:22 ` Benjamin Herrenschmidt
2012-09-20 22:22 ` Benjamin Herrenschmidt
2012-09-20 22:53 ` David Miller
2012-09-20 22:53 ` David Miller
2012-09-21 21:46 ` Benjamin Herrenschmidt
2012-09-21 21:46 ` Benjamin Herrenschmidt
2012-09-22 20:00 ` David Miller
2012-09-22 20:00 ` David Miller
2012-09-22 21:20 ` Benjamin Herrenschmidt
2012-09-22 21:20 ` Benjamin Herrenschmidt
2012-09-20 22:28 ` Stephen Rothwell
2012-09-20 22:28 ` Stephen Rothwell
2012-09-20 22:28 ` Stephen Rothwell
2012-09-21 1:37 ` Stephen Rothwell
2012-09-21 1:37 ` Stephen Rothwell
2012-09-05 5:39 Stephen Rothwell
2012-09-05 5:39 ` Stephen Rothwell
2012-09-05 21:46 ` David Miller
2012-09-04 6:58 Stephen Rothwell
2012-09-04 18:20 ` David Miller
2012-09-04 19:50 ` Jerry Chu
2012-07-22 6:34 Stephen Rothwell
2012-07-22 7:29 ` Jiri Pirko
2012-05-03 6:16 Stephen Rothwell
2012-05-03 6:16 ` Stephen Rothwell
2012-05-03 6:26 ` David Miller
2012-04-30 5:58 Stephen Rothwell
2012-04-30 5:58 ` Stephen Rothwell
2012-04-30 17:22 ` David Miller
2012-04-19 6:28 Stephen Rothwell
2012-04-19 6:28 ` Stephen Rothwell
2012-04-19 6:40 ` David Miller
2012-04-10 5:29 Stephen Rothwell
2012-04-10 5:29 ` Stephen Rothwell
2012-04-10 13:26 ` David Miller
2012-02-20 5:15 Stephen Rothwell
2012-02-20 5:15 ` Stephen Rothwell
2012-02-20 5:46 ` David Miller
2011-12-14 7:07 Stephen Rothwell
2011-12-14 7:07 ` Stephen Rothwell
2011-12-14 18:35 ` David Miller
2011-11-23 4:00 Stephen Rothwell
2011-11-23 4:00 ` Stephen Rothwell
2011-11-23 12:09 ` Neil Horman
2011-11-23 23:02 ` Andrew Morton
2011-11-23 23:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7E9B7A.2080807@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=deepak.sikri@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shiraz.hashim@st.com \
--cc=vikas.manocha@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.