From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
devicetree-discuss@lists.ozlabs.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2 2/2] ARM: at91: add at91sam9_wdt driver to at91sam9260
Date: Thu, 20 Sep 2012 12:07:24 +0200 [thread overview]
Message-ID: <20120920100724.GF17667@game.jcrosoft.org> (raw)
In-Reply-To: <CAHkwnC9jqUmb+AGCnxV9QeSv=5JjS4+AWnutkm6TZPJJRcxGAA@mail.gmail.com>
On 09:52 Thu 20 Sep , Fabio Porcedda wrote:
> Hi Jean-Christophe,
>
> On Thu, Sep 20, 2012 at 7:29 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
> > On 13:57 Wed 19 Sep , Fabio Porcedda wrote:
> >> Tested on an at91sam9260 board (evk-pro3)
> >>
> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> >> ---
> >> arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> >> index 66389c1..680b1c8 100644
> >> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> >> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> >> @@ -233,6 +233,12 @@
> >> trigger-external;
> >> };
> >> };
> >> +
> >> + watchdog@fffffd40 {
> > disable dy default
>
> All the others watchdog drivers in arch/arm/boot/dts/* are enabled by default.
> IMHO the watchdog driver it's like the "rtstc" and "shdwc" driver,
> they are safe to be enabled by default.
> I'm missing something?
no the other watchdog will not reset if not managed
this one will
so I'm not confortable by enabling it by default
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: at91: add at91sam9_wdt driver to at91sam9260
Date: Thu, 20 Sep 2012 12:07:24 +0200 [thread overview]
Message-ID: <20120920100724.GF17667@game.jcrosoft.org> (raw)
In-Reply-To: <CAHkwnC9jqUmb+AGCnxV9QeSv=5JjS4+AWnutkm6TZPJJRcxGAA@mail.gmail.com>
On 09:52 Thu 20 Sep , Fabio Porcedda wrote:
> Hi Jean-Christophe,
>
> On Thu, Sep 20, 2012 at 7:29 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
> > On 13:57 Wed 19 Sep , Fabio Porcedda wrote:
> >> Tested on an at91sam9260 board (evk-pro3)
> >>
> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> >> ---
> >> arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> >> index 66389c1..680b1c8 100644
> >> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> >> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> >> @@ -233,6 +233,12 @@
> >> trigger-external;
> >> };
> >> };
> >> +
> >> + watchdog at fffffd40 {
> > disable dy default
>
> All the others watchdog drivers in arch/arm/boot/dts/* are enabled by default.
> IMHO the watchdog driver it's like the "rtstc" and "shdwc" driver,
> they are safe to be enabled by default.
> I'm missing something?
no the other watchdog will not reset if not managed
this one will
so I'm not confortable by enabling it by default
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-watchdog@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: at91: add at91sam9_wdt driver to at91sam9260
Date: Thu, 20 Sep 2012 12:07:24 +0200 [thread overview]
Message-ID: <20120920100724.GF17667@game.jcrosoft.org> (raw)
In-Reply-To: <CAHkwnC9jqUmb+AGCnxV9QeSv=5JjS4+AWnutkm6TZPJJRcxGAA@mail.gmail.com>
On 09:52 Thu 20 Sep , Fabio Porcedda wrote:
> Hi Jean-Christophe,
>
> On Thu, Sep 20, 2012 at 7:29 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
> > On 13:57 Wed 19 Sep , Fabio Porcedda wrote:
> >> Tested on an at91sam9260 board (evk-pro3)
> >>
> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> >> ---
> >> arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> >> index 66389c1..680b1c8 100644
> >> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> >> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> >> @@ -233,6 +233,12 @@
> >> trigger-external;
> >> };
> >> };
> >> +
> >> + watchdog@fffffd40 {
> > disable dy default
>
> All the others watchdog drivers in arch/arm/boot/dts/* are enabled by default.
> IMHO the watchdog driver it's like the "rtstc" and "shdwc" driver,
> they are safe to be enabled by default.
> I'm missing something?
no the other watchdog will not reset if not managed
this one will
so I'm not confortable by enabling it by default
Best Regards,
J.
next prev parent reply other threads:[~2012-09-20 10:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:57 [PATCH v2 0/2] watchdog: at91sam9_wdt: add device tree support Fabio Porcedda
2012-09-19 11:57 ` Fabio Porcedda
2012-09-19 11:57 ` Fabio Porcedda
2012-09-19 11:57 ` [PATCH v2 1/2] " Fabio Porcedda
2012-09-19 11:57 ` Fabio Porcedda
2012-09-19 11:57 ` Fabio Porcedda
2012-09-20 5:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 5:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 5:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 10:04 ` Fabio Porcedda
2012-09-20 10:04 ` Fabio Porcedda
2012-09-20 10:04 ` Fabio Porcedda
2012-09-19 11:57 ` [PATCH v2 2/2] ARM: at91: add at91sam9_wdt driver to at91sam9260 Fabio Porcedda
2012-09-19 11:57 ` Fabio Porcedda
2012-09-19 11:57 ` Fabio Porcedda
2012-09-20 5:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 5:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 5:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 7:52 ` Fabio Porcedda
2012-09-20 7:52 ` Fabio Porcedda
2012-09-20 7:52 ` Fabio Porcedda
2012-09-20 10:07 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-20 10:07 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 10:07 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 10:19 ` Fabio Porcedda
2012-09-20 10:19 ` Fabio Porcedda
2012-09-20 10:19 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920100724.GF17667@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.porcedda@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.ferre@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.