From: Alan Cox <alan@linux.intel.com>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, RT <linux-rt-users@vger.kernel.org>,
Jiri Slaby <jslaby@suse.cz>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] tty: cleanup duplicate functions in tty_buffer
Date: Thu, 20 Sep 2012 17:17:17 +0100 [thread overview]
Message-ID: <20120920171717.04ee9098@bob.linux.org.uk> (raw)
In-Reply-To: <1348149223-4281-1-git-send-email-meltedpianoman@gmail.com>
> Therefor the the tty_scedule_flip() function and replaced it
> everywhere with the tty_flip_buffer_push() beause that function is
> used the most by serial drivers and implements the work queue bypass
> mechanism.
So now when the user sets tty->low_latency on these devices the machine
crashes ?
This is the wrong direction - in fact we have a pile we need to move
the other way !
If they resolve to the same thing in hard RT patches fine, that's a
different question.
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@linux.intel.com>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
<linux-serial@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>, Jiri Slaby <jslaby@suse.cz>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] tty: cleanup duplicate functions in tty_buffer
Date: Thu, 20 Sep 2012 17:17:17 +0100 [thread overview]
Message-ID: <20120920171717.04ee9098@bob.linux.org.uk> (raw)
In-Reply-To: <1348149223-4281-1-git-send-email-meltedpianoman@gmail.com>
> Therefor the the tty_scedule_flip() function and replaced it
> everywhere with the tty_flip_buffer_push() beause that function is
> used the most by serial drivers and implements the work queue bypass
> mechanism.
So now when the user sets tty->low_latency on these devices the machine
crashes ?
This is the wrong direction - in fact we have a pile we need to move
the other way !
If they resolve to the same thing in hard RT patches fine, that's a
different question.
Alan
next prev parent reply other threads:[~2012-09-20 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 13:53 [PATCH] tty: cleanup duplicate functions in tty_buffer Ivo Sieben
2012-09-20 13:53 ` Ivo Sieben
2012-09-20 16:17 ` Alan Cox [this message]
2012-09-20 16:17 ` Alan Cox
2012-09-24 8:02 ` Ivo Sieben
2012-09-24 8:15 ` Jiri Slaby
2012-09-24 9:25 ` Alan Cox
2012-09-25 11:28 ` Ivo Sieben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920171717.04ee9098@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jslaby@suse.cz \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.