From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: walter harms <wharms@bfs.de>,
Ashish Jangam <ashish.jangam@kpitcummins.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] da9052-battery: don't free IRQ that wasn't requested
Date: Thu, 20 Sep 2012 22:02:04 +0000 [thread overview]
Message-ID: <20120920220204.GE18223@lizard> (raw)
In-Reply-To: <20120906150758.GL19410@mwanda>
On Thu, Sep 06, 2012 at 08:07:58AM -0700, Dan Carpenter wrote:
[...]
> > for (j=0; j <= i ;j++ ) {
> ^^^^^^
> The count up loops are prone to the exact same off by one bugs. ;)
> You've got one in your sample code. Plus I'd have to declare
> another variable and send a v2 patch and I am very lazy... So in
> this case I think should just take my original patch.
Applied, thank you!
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: walter harms <wharms@bfs.de>,
Ashish Jangam <ashish.jangam@kpitcummins.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] da9052-battery: don't free IRQ that wasn't requested
Date: Thu, 20 Sep 2012 15:02:04 -0700 [thread overview]
Message-ID: <20120920220204.GE18223@lizard> (raw)
In-Reply-To: <20120906150758.GL19410@mwanda>
On Thu, Sep 06, 2012 at 08:07:58AM -0700, Dan Carpenter wrote:
[...]
> > for (j=0; j <= i ;j++ ) {
> ^^^^^^
> The count up loops are prone to the exact same off by one bugs. ;)
> You've got one in your sample code. Plus I'd have to declare
> another variable and send a v2 patch and I am very lazy... So in
> this case I think should just take my original patch.
Applied, thank you!
next prev parent reply other threads:[~2012-09-20 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 12:34 [patch] da9052-battery: don't free IRQ that wasn't requested Dan Carpenter
2012-09-05 12:34 ` Dan Carpenter
2012-09-05 14:11 ` walter harms
2012-09-05 14:11 ` walter harms
2012-09-06 15:07 ` Dan Carpenter
2012-09-06 15:07 ` Dan Carpenter
2012-09-20 22:02 ` Anton Vorontsov [this message]
2012-09-20 22:02 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920220204.GE18223@lizard \
--to=cbouatmailru@gmail.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.