All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@stericsson.com>,
	linux-serial@vger.kernel.org,
	Guillaume Jaunet <guillaume.jaunet@stericsson.com>,
	Par-Gunnar Hjalmdahl <par-gunnar.hjalmdahl@stericsson.com>,
	Anmar Oueja <anmar.oueja@linaro.org>,
	Matthias Locher <matthias.locher@stericsson.com>,
	"Rajanikanth H.V" <rajanikanth.hv@stericsson.com>,
	Christophe Arnal <christophe.arnal@stericsson.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] serial: pl011: allow very high baudrates
Date: Fri, 21 Sep 2012 15:37:10 +0100	[thread overview]
Message-ID: <20120921153710.220adb92@bob.linux.org.uk> (raw)
In-Reply-To: <CACRpkdY1ZxQoyGFO9OnKr0WYQzooxPGvZV8Gnr_YO_yT_+ddDw@mail.gmail.com>

> Device drivers should use c_[io]speed directly!
> 
> Alan Cox wrote this, so Alan: should I just ditch the use of
> uart_get_baud_rate() and program the divider directly from
> c_[io]speed?

Yes.

The functions are designed to act as helpers for old devices. In fact
we can actually probably abolish tty_termios_baud_rate at this point as
I don't think there is much if anything left which blows up fed a non
Bxxx table entry.

I will have a look at that in fact see what it involves at this point.

Alan

WARNING: multiple messages have this Message-ID (diff)
From: alan@linux.intel.com (Alan Cox)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] serial: pl011: allow very high baudrates
Date: Fri, 21 Sep 2012 15:37:10 +0100	[thread overview]
Message-ID: <20120921153710.220adb92@bob.linux.org.uk> (raw)
In-Reply-To: <CACRpkdY1ZxQoyGFO9OnKr0WYQzooxPGvZV8Gnr_YO_yT_+ddDw@mail.gmail.com>

> Device drivers should use c_[io]speed directly!
> 
> Alan Cox wrote this, so Alan: should I just ditch the use of
> uart_get_baud_rate() and program the divider directly from
> c_[io]speed?

Yes.

The functions are designed to act as helpers for old devices. In fact
we can actually probably abolish tty_termios_baud_rate at this point as
I don't think there is much if anything left which blows up fed a non
Bxxx table entry.

I will have a look at that in fact see what it involves at this point.

Alan

  reply	other threads:[~2012-09-21 14:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20  9:46 [PATCH 3/3] serial: pl011: allow very high baudrates Linus Walleij
2012-09-20  9:46 ` Linus Walleij
2012-09-20 19:00 ` Russell King - ARM Linux
2012-09-20 19:00   ` Russell King - ARM Linux
2012-09-21 13:41   ` Linus Walleij
2012-09-21 13:41     ` Linus Walleij
2012-09-21 14:37     ` Alan Cox [this message]
2012-09-21 14:37       ` Alan Cox
2012-09-21 14:58       ` Russell King - ARM Linux
2012-09-21 14:58         ` Russell King - ARM Linux
2012-09-21 15:05         ` Alan Cox
2012-09-21 15:05           ` Alan Cox
2012-09-21 15:06           ` Russell King - ARM Linux
2012-09-21 15:06             ` Russell King - ARM Linux
2012-09-21 15:36             ` Alan Cox
2012-09-21 15:36               ` Alan Cox
2012-09-21 15:14     ` Alan Cox
2012-09-21 15:14       ` Alan Cox
2012-09-21 15:25     ` Alan Cox
2012-09-21 15:25       ` Alan Cox
2012-09-21 17:52       ` Linus Walleij
2012-09-21 17:52         ` Linus Walleij
2012-09-21 19:56         ` Alan Cox
2012-09-21 19:56           ` Alan Cox
2012-09-21 20:34           ` Russell King - ARM Linux
2012-09-21 20:34             ` Russell King - ARM Linux
2012-09-21 20:55             ` Alan Cox
2012-09-21 20:55               ` Alan Cox
2012-09-25 18:48           ` Linus Walleij
2012-09-25 18:48             ` Linus Walleij
2012-09-25 19:00             ` Alan Cox
2012-09-25 19:00               ` Alan Cox
2012-09-26  8:06             ` Linus Walleij
2012-09-26  8:06               ` Linus Walleij
2012-09-26 10:04               ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120921153710.220adb92@bob.linux.org.uk \
    --to=alan@linux.intel.com \
    --cc=anmar.oueja@linaro.org \
    --cc=christophe.arnal@stericsson.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guillaume.jaunet@stericsson.com \
    --cc=linus.walleij@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=matthias.locher@stericsson.com \
    --cc=par-gunnar.hjalmdahl@stericsson.com \
    --cc=rajanikanth.hv@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.