All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
To: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	Jeff Dike <jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid where appropriate
Date: Mon, 24 Sep 2012 09:55:34 -0500	[thread overview]
Message-ID: <20120924145534.GA5193@sergelap> (raw)
In-Reply-To: <505F864C.2000103-/L3Ra7n9ekc@public.gmane.org>

Quoting Richard Weinberger (richard-/L3Ra7n9ekc@public.gmane.org):
> Am 21.09.2012 02:28, schrieb Eric W. Biederman:
> > From: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
> > 
> > Cc: Jeff Dike <jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org>
> > Cc: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
> > Acked-by: Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> > Signed-off-by: Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
> > ---
> 
> Looks sane to me.
> 
> Acked-by: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
> 
> BTW: How you do test your user namespace patches?

I've got a few specific tests of the new functionality in the usernstest.c
in the nsexec package at
https://launchpad.net/~serge-hallyn/+archive/userns-natty/+sourcepub/2530252/+listing-archive-extra .
Of course LTP already has a good set of test cases for the regular
functionality.

> Is there a generic way to compare/verify uids within a namespace vs. the initial namespace?

It's good to look at output of 'id' in the task versus 'ps' from the initial ns,
as well as create a file and look at the stat output from both namespaces.

-serge

WARNING: multiple messages have this Message-ID (diff)
From: Serge Hallyn <serge.hallyn@canonical.com>
To: Richard Weinberger <richard@nod.at>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Linux Containers <containers@lists.linux-foundation.org>,
	linux-security-module@vger.kernel.org,
	Jeff Dike <jdike@addtoit.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid where appropriate
Date: Mon, 24 Sep 2012 09:55:34 -0500	[thread overview]
Message-ID: <20120924145534.GA5193@sergelap> (raw)
In-Reply-To: <505F864C.2000103@nod.at>

Quoting Richard Weinberger (richard@nod.at):
> Am 21.09.2012 02:28, schrieb Eric W. Biederman:
> > From: "Eric W. Biederman" <ebiederm@xmission.com>
> > 
> > Cc: Jeff Dike <jdike@addtoit.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> > ---
> 
> Looks sane to me.
> 
> Acked-by: Richard Weinberger <richard@nod.at>
> 
> BTW: How you do test your user namespace patches?

I've got a few specific tests of the new functionality in the usernstest.c
in the nsexec package at
https://launchpad.net/~serge-hallyn/+archive/userns-natty/+sourcepub/2530252/+listing-archive-extra .
Of course LTP already has a good set of test cases for the regular
functionality.

> Is there a generic way to compare/verify uids within a namespace vs. the initial namespace?

It's good to look at output of 'id' in the task versus 'ps' from the initial ns,
as well as create a file and look at the stat output from both namespaces.

-serge

  parent reply	other threads:[~2012-09-24 14:55 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21  0:26 [REVIEW][PATCH 00/14] userns: Miscelanous conversions Eric W. Biederman
     [not found] ` <87k3vote43.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-21  0:28   ` [PATCH 01/14] userns: Convert loop to use kuid_t instead of uid_t Eric W. Biederman
2012-09-21  0:28     ` Eric W. Biederman
     [not found]     ` <1348187330-6616-1-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-21  0:28       ` [PATCH 02/14] userns: Convert apparmor to use kuid and kgid where appropriate Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-21  0:28       ` [PATCH 03/14] userns: Convert tomoyo " Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-21  0:28       ` [PATCH 04/14] userns: Convert selinux " Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-26 17:51         ` Serge Hallyn
     [not found]         ` <1348187330-6616-4-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-26 17:51           ` Serge Hallyn
2012-09-21  0:28       ` [PATCH 05/14] userns: Convert hostfs " Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
     [not found]         ` <1348187330-6616-5-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-23 21:59           ` Richard Weinberger
2012-09-23 21:59         ` Richard Weinberger
2012-09-24  2:39           ` Eric W. Biederman
     [not found]           ` <505F864C.2000103-/L3Ra7n9ekc@public.gmane.org>
2012-09-24  2:39             ` Eric W. Biederman
2012-09-24 14:55             ` Serge Hallyn [this message]
2012-09-24 14:55               ` Serge Hallyn
2012-09-21  0:28       ` [PATCH 06/14] userns: Convert EVM to deal with kuids and kgids in it's hmac computation Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-21  0:28       ` [PATCH 07/14] userns: Add user namespace support to IMA Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-21  0:28       ` [PATCH 08/14] userns: Teach security_path_chown to take kuids and kgids Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-21  0:28       ` [PATCH 09/14] userns: Convert binder ipc to use kuids Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
     [not found]         ` <1348187330-6616-9-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-21  6:44           ` Greg Kroah-Hartman
2012-09-21  6:44             ` Greg Kroah-Hartman
2012-09-21  0:28       ` [PATCH 10/14] userns: Convert s390 hypfs to use kuid and kgid where appropriate Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
     [not found]         ` <1348187330-6616-10-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-26 17:52           ` Serge Hallyn
2012-09-26 17:52         ` Serge Hallyn
2012-09-21  0:28       ` [PATCH 11/14] userns: Convert s390 getting uid and gid system calls to use kuid and kgid Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-26 17:59         ` Serge Hallyn
     [not found]         ` <1348187330-6616-11-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-26 17:59           ` Serge Hallyn
2012-09-21  0:28       ` [PATCH 12/14] userns: On ppc convert current_uid from a kuid before printing Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-26 17:56         ` Serge Hallyn
     [not found]         ` <1348187330-6616-12-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-26 17:56           ` Serge Hallyn
2012-09-21  0:28       ` [PATCH 13/14] userns: On ia64 deal with current_uid and current_gid being kuid and kgid Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
     [not found]         ` <1348187330-6616-13-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-25  9:15           ` Zhao Hongjiang
     [not found]             ` <50617630.1050709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-25  9:58               ` Eric W. Biederman
2012-09-26 17:55           ` Serge Hallyn
2012-09-26 17:55         ` Serge Hallyn
2012-09-21  0:28       ` [PATCH 14/14] userns: On alpha modify linux_to_osf_stat to use convert from kuids and kgids Eric W. Biederman
2012-09-21  0:28         ` Eric W. Biederman
2012-09-21  6:07       ` [PATCH 01/14] userns: Convert loop to use kuid_t instead of uid_t Jens Axboe
2012-09-21  6:07     ` Jens Axboe
     [not found]       ` <505C0438.9060907-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
2012-09-21  7:07         ` Eric W. Biederman
2012-09-21  7:07           ` Eric W. Biederman
     [not found]           ` <87sjabsvkx.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2012-09-21  7:11             ` Jens Axboe
2012-09-21  7:11               ` Jens Axboe
     [not found]               ` <505C1331.8050907-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
2012-09-21  7:19                 ` Eric W. Biederman
2012-09-21  7:19                   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120924145534.GA5193@sergelap \
    --to=serge.hallyn-z7wlfzj8ewms+fvcfc7uqw@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=richard-/L3Ra7n9ekc@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.