From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
Date: Tue, 25 Sep 2012 08:21:06 +0000 [thread overview]
Message-ID: <20120925082106.GS4587@mwanda> (raw)
In-Reply-To: <20120925081342.GA21642@localhost>
On Tue, Sep 25, 2012 at 04:13:42PM +0800, Fengguang Wu wrote:
> Hi Frederic,
>
> FYI, there are new smatch warnings show up in
>
> 37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection()
>
> All smatch warnings:
>
> + arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
> arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code.
>
> vim +276 arch/x86/kernel/traps.c
>
> 272
> 273 tsk->thread.error_code = error_code;
> 274 tsk->thread.trap_nr = X86_TRAP_GP;
> 275 if (!notify_die(DIE_GPF, "general protection fault", regs, error_code,
> > 276 X86_TRAP_GP, SIGSEGV) = NOTIFY_STOP)
Precedence error. Should != NOTIFY_STOP. Same for the other email.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-25 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 8:13 arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? Fengguang Wu
2012-09-25 8:21 ` Dan Carpenter [this message]
2012-09-25 11:03 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925082106.GS4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.