* arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
@ 2012-09-25 8:13 Fengguang Wu
2012-09-25 8:21 ` Dan Carpenter
2012-09-25 11:03 ` Frederic Weisbecker
0 siblings, 2 replies; 3+ messages in thread
From: Fengguang Wu @ 2012-09-25 8:13 UTC (permalink / raw)
To: kernel-janitors
Hi Frederic,
FYI, there are new smatch warnings show up in
37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection()
All smatch warnings:
+ arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code.
vim +276 arch/x86/kernel/traps.c
272
273 tsk->thread.error_code = error_code;
274 tsk->thread.trap_nr = X86_TRAP_GP;
275 if (!notify_die(DIE_GPF, "general protection fault", regs, error_code,
> 276 X86_TRAP_GP, SIGSEGV) = NOTIFY_STOP)
277 die("general protection fault", regs, error_code);
278 return;
279 }
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
2012-09-25 8:13 arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? Fengguang Wu
@ 2012-09-25 8:21 ` Dan Carpenter
2012-09-25 11:03 ` Frederic Weisbecker
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-09-25 8:21 UTC (permalink / raw)
To: kernel-janitors
On Tue, Sep 25, 2012 at 04:13:42PM +0800, Fengguang Wu wrote:
> Hi Frederic,
>
> FYI, there are new smatch warnings show up in
>
> 37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection()
>
> All smatch warnings:
>
> + arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
> arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code.
>
> vim +276 arch/x86/kernel/traps.c
>
> 272
> 273 tsk->thread.error_code = error_code;
> 274 tsk->thread.trap_nr = X86_TRAP_GP;
> 275 if (!notify_die(DIE_GPF, "general protection fault", regs, error_code,
> > 276 X86_TRAP_GP, SIGSEGV) = NOTIFY_STOP)
Precedence error. Should != NOTIFY_STOP. Same for the other email.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
2012-09-25 8:13 arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? Fengguang Wu
2012-09-25 8:21 ` Dan Carpenter
@ 2012-09-25 11:03 ` Frederic Weisbecker
1 sibling, 0 replies; 3+ messages in thread
From: Frederic Weisbecker @ 2012-09-25 11:03 UTC (permalink / raw)
To: kernel-janitors
2012/9/25 Dan Carpenter <dan.carpenter@oracle.com>:
> On Tue, Sep 25, 2012 at 04:13:42PM +0800, Fengguang Wu wrote:
>> Hi Frederic,
>>
>> FYI, there are new smatch warnings show up in
>>
>> 37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection()
>>
>> All smatch warnings:
>>
>> + arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?
>> arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code.
>>
>> vim +276 arch/x86/kernel/traps.c
>>
>> 272
>> 273 tsk->thread.error_code = error_code;
>> 274 tsk->thread.trap_nr = X86_TRAP_GP;
>> 275 if (!notify_die(DIE_GPF, "general protection fault", regs, error_code,
>> > 276 X86_TRAP_GP, SIGSEGV) = NOTIFY_STOP)
>
> Precedence error. Should != NOTIFY_STOP. Same for the other email.
Doh! I'm fixing this. I should stop writing patches in the middle of the night.
Thanks for your report!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-25 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 8:13 arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? Fengguang Wu
2012-09-25 8:21 ` Dan Carpenter
2012-09-25 11:03 ` Frederic Weisbecker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.