All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Yuanhan Liu <yuanhan.liu@intel.com>,
	kernel-janitors@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [nfs:devel 17/39] fs/nfs/pnfs.c:1043:20: warning: unused variable 'nfsi'
Date: Wed, 26 Sep 2012 01:38:39 +0000	[thread overview]
Message-ID: <20120926013839.GD8522@localhost> (raw)

Hi Trond,

FYI, there are new compile warnings show up in

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   f743c735b817547b590d36a6e275235c7beb8600
commit: a9c310af706112f44c15cf5172e81ba3ee755cab [17/39] NFSv4.1: Add helpers for setting/reading the I/O fail bit

All warnings:

fs/nfs/pnfs.c: In function 'pnfs_update_layout':
fs/nfs/pnfs.c:1043:20: warning: unused variable 'nfsi' [-Wunused-variable]

vim +1043 fs/nfs/pnfs.c
  1027	 * The appropriate layout segment is referenced and returned to the caller.
  1028	 */
  1029	struct pnfs_layout_segment *
  1030	pnfs_update_layout(struct inode *ino,
  1031			   struct nfs_open_context *ctx,
  1032			   loff_t pos,
  1033			   u64 count,
  1034			   enum pnfs_iomode iomode,
  1035			   gfp_t gfp_flags)
  1036	{
  1037		struct pnfs_layout_range arg = {
  1038			.iomode = iomode,
  1039			.offset = pos,
  1040			.length = count,
  1041		};
  1042		unsigned pg_offset;
> 1043		struct nfs_inode *nfsi = NFS_I(ino);
  1044		struct nfs_server *server = NFS_SERVER(ino);
  1045		struct nfs_client *clp = server->nfs_client;
  1046		struct pnfs_layout_hdr *lo;
  1047		struct pnfs_layout_segment *lseg = NULL;
  1048		bool first = false;
  1049	
  1050		if (!pnfs_enabled_sb(NFS_SERVER(ino)))
  1051			return NULL;

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Yuanhan Liu <yuanhan.liu@intel.com>,
	kernel-janitors@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [nfs:devel 17/39] fs/nfs/pnfs.c:1043:20: warning: unused variable 'nfsi'
Date: Wed, 26 Sep 2012 09:38:39 +0800	[thread overview]
Message-ID: <20120926013839.GD8522@localhost> (raw)

Hi Trond,

FYI, there are new compile warnings show up in

tree:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel
head:   f743c735b817547b590d36a6e275235c7beb8600
commit: a9c310af706112f44c15cf5172e81ba3ee755cab [17/39] NFSv4.1: Add helpers for setting/reading the I/O fail bit

All warnings:

fs/nfs/pnfs.c: In function 'pnfs_update_layout':
fs/nfs/pnfs.c:1043:20: warning: unused variable 'nfsi' [-Wunused-variable]

vim +1043 fs/nfs/pnfs.c
  1027	 * The appropriate layout segment is referenced and returned to the caller.
  1028	 */
  1029	struct pnfs_layout_segment *
  1030	pnfs_update_layout(struct inode *ino,
  1031			   struct nfs_open_context *ctx,
  1032			   loff_t pos,
  1033			   u64 count,
  1034			   enum pnfs_iomode iomode,
  1035			   gfp_t gfp_flags)
  1036	{
  1037		struct pnfs_layout_range arg = {
  1038			.iomode = iomode,
  1039			.offset = pos,
  1040			.length = count,
  1041		};
  1042		unsigned pg_offset;
> 1043		struct nfs_inode *nfsi = NFS_I(ino);
  1044		struct nfs_server *server = NFS_SERVER(ino);
  1045		struct nfs_client *clp = server->nfs_client;
  1046		struct pnfs_layout_hdr *lo;
  1047		struct pnfs_layout_segment *lseg = NULL;
  1048		bool first = false;
  1049	
  1050		if (!pnfs_enabled_sb(NFS_SERVER(ino)))
  1051			return NULL;

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

             reply	other threads:[~2012-09-26  1:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  1:38 Fengguang Wu [this message]
2012-09-26  1:38 ` [nfs:devel 17/39] fs/nfs/pnfs.c:1043:20: warning: unused variable 'nfsi' Fengguang Wu
2012-09-26 14:47 ` Myklebust, Trond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120926013839.GD8522@localhost \
    --to=fengguang.wu@intel.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=yuanhan.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.