From: Fengguang Wu <fengguang.wu@intel.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andi Kleen <andi.kleen@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kpageflags: fix wrong KPF_THP on non-huge compound pages
Date: Thu, 27 Sep 2012 09:20:57 +0800 [thread overview]
Message-ID: <20120927012057.GE7205@localhost> (raw)
In-Reply-To: <1348691234-31729-1-git-send-email-n-horiguchi@ah.jp.nec.com>
> - else if (PageTransCompound(page))
> + /*
> + * PageTransCompound can be true for non-huge compound pages (slab
> + * pages or pages allocated by drivers with __GFP_COMP) because it
> + * just checks PG_head/PG_tail, so we need to check PageLRU to make
> + * sure a given page is a thp, not a non-huge compound page.
> + */
> + else if (PageTransCompound(page) && PageLRU(compound_trans_head(page)))
> u |= 1 << KPF_THP;
Reviewed-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andi Kleen <andi.kleen@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kpageflags: fix wrong KPF_THP on non-huge compound pages
Date: Thu, 27 Sep 2012 09:20:57 +0800 [thread overview]
Message-ID: <20120927012057.GE7205@localhost> (raw)
In-Reply-To: <1348691234-31729-1-git-send-email-n-horiguchi@ah.jp.nec.com>
> - else if (PageTransCompound(page))
> + /*
> + * PageTransCompound can be true for non-huge compound pages (slab
> + * pages or pages allocated by drivers with __GFP_COMP) because it
> + * just checks PG_head/PG_tail, so we need to check PageLRU to make
> + * sure a given page is a thp, not a non-huge compound page.
> + */
> + else if (PageTransCompound(page) && PageLRU(compound_trans_head(page)))
> u |= 1 << KPF_THP;
Reviewed-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks!
next prev parent reply other threads:[~2012-09-27 1:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 20:27 [PATCH v4] kpageflags: fix wrong KPF_THP on non-huge compound pages Naoya Horiguchi
2012-09-26 20:27 ` Naoya Horiguchi
2012-09-27 1:17 ` David Rientjes
2012-09-27 1:17 ` David Rientjes
2012-09-27 1:20 ` Fengguang Wu [this message]
2012-09-27 1:20 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927012057.GE7205@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.