From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn
Date: Thu, 27 Sep 2012 05:18:00 +0000 [thread overview]
Message-ID: <20120927051800.GA24703@localhost> (raw)
In-Reply-To: <20120927011122.GC7205@localhost>
On Thu, Sep 27, 2012 at 12:00:09AM -0500, H Hartley Sweeten wrote:
> On Wednesday, September 26, 2012 6:11 PM, Fengguang Wu wrote:
> >
> > FYI, there are new smatch warnings show up in
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
> > head: 3cd73bc1cf59b2c9232d9889ba2b148e262054b6
> > commit: 8c7e4277c1197d31c0b34dbaf23e6edddb5978f7 [253/267] staging: comedi: s626: cleanup request_irq in s626_attach_pci()
> >
> > drivers/staging/comedi/drivers/s626.c:1428 s626_ai_cmd() Error invalid range 4096 to -1
> > drivers/staging/comedi/drivers/s626.c:1448 s626_ai_cmd() Error invalid range 4096 to -1
> > drivers/staging/comedi/drivers/s626.c:1649 s626_ai_cmdtest() Error invalid range 4096 to -1
> > drivers/staging/comedi/drivers/s626.c:1656 s626_ai_cmdtest() Error invalid range 4096 to -1
> > drivers/staging/comedi/drivers/s626.c:2504 s626_attach_pci() warn: '(dev->private)->base_addr' was not released on error
> > drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: '(dev->private)->base_addr' was not released on error
> > + drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: 'pcidev->irq' was not released on error
>
> These shouldn't be "new" warnings. The logic of the code has
> not been changed. Its just been shuffled around.
>
> I'll take a look at the first four tommorrow just to make sure.
> They may actually be a problem but they shouldn't be new.
Right, it's not really a new *problem*. Technically, it's classified
as "new" by the script because of the s626_attach()=>s626_attach_pci()
rename, which makes it a new error *message*. This prevents the system
from bisecting it to the initial commit that caused the *problem*.
Hopefully such mistakes will only happen on a small fraction of pretty
old bugs.
> The last three warnings should exist in _every_ comedi driver.
> The comedi drivers are designed _not_ to release anything in
> the "attach" functions. Everything gets released either in the
> "detach" function or by the comedi core itself. I think it was
> orignally modeled on the tty subsystem.
Ah OK. These error messages will be ignored by the build system until
there comes another rename ;)
> I plan on looking into if it would be cleaner for the "attach"
> functions to cleanup after themselves on error. My initial
> impression is that the patch to "fix" this is going to be huge...
OK, thanks!
Fengguang
next prev parent reply other threads:[~2012-09-27 5:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 1:11 [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: Fengguang Wu
2012-09-27 5:00 ` [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn H Hartley Sweeten
2012-09-27 5:18 ` Fengguang Wu [this message]
2012-09-27 7:27 ` Dan Carpenter
2012-09-27 7:38 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927051800.GA24703@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.