From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn
Date: Thu, 27 Sep 2012 07:38:52 +0000 [thread overview]
Message-ID: <20120927073852.GD31500@localhost> (raw)
In-Reply-To: <20120927011122.GC7205@localhost>
On Thu, Sep 27, 2012 at 10:27:13AM +0300, Dan Carpenter wrote:
> On Thu, Sep 27, 2012 at 01:18:00PM +0800, Fengguang Wu wrote:
> > On Thu, Sep 27, 2012 at 12:00:09AM -0500, H Hartley Sweeten wrote:
> > > On Wednesday, September 26, 2012 6:11 PM, Fengguang Wu wrote:
> > > >
> > > > FYI, there are new smatch warnings show up in
> > > >
> > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
> > > > head: 3cd73bc1cf59b2c9232d9889ba2b148e262054b6
> > > > commit: 8c7e4277c1197d31c0b34dbaf23e6edddb5978f7 [253/267] staging: comedi: s626: cleanup request_irq in s626_attach_pci()
> > > >
> > > > drivers/staging/comedi/drivers/s626.c:1428 s626_ai_cmd() Error invalid range 4096 to -1
> > > > drivers/staging/comedi/drivers/s626.c:1448 s626_ai_cmd() Error invalid range 4096 to -1
> > > > drivers/staging/comedi/drivers/s626.c:1649 s626_ai_cmdtest() Error invalid range 4096 to -1
> > > > drivers/staging/comedi/drivers/s626.c:1656 s626_ai_cmdtest() Error invalid range 4096 to -1
> > > > drivers/staging/comedi/drivers/s626.c:2504 s626_attach_pci() warn: '(dev->private)->base_addr' was not released on error
> > > > drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: '(dev->private)->base_addr' was not released on error
> > > > + drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: 'pcidev->irq' was not released on error
>
> Gar. That check produces too many false positives because of logic
> like comedi's. I want to move it under --spammy.
>
> Fengguang, that would be ok with you?
I have no strong idea about this because I've not run into many such
"not released on error" warnings.
I don't quite get the "invalid range 4096 to -1" warnings and they
show up quite often. What's your typical way to tell whether it's a
false warning?
Thanks,
Fengguang
prev parent reply other threads:[~2012-09-27 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 1:11 [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: Fengguang Wu
2012-09-27 5:00 ` [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn H Hartley Sweeten
2012-09-27 5:18 ` Fengguang Wu
2012-09-27 7:27 ` Dan Carpenter
2012-09-27 7:38 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927073852.GD31500@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.