From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
hpa@zytor.com, xemul@parallels.com
Subject: Re: [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c
Date: Thu, 27 Sep 2012 22:18:58 +0400 [thread overview]
Message-ID: <20120927181858.GV6618@moon> (raw)
In-Reply-To: <20120927181417.GA10536@kroah.com>
On Thu, Sep 27, 2012 at 11:14:17AM -0700, Greg KH wrote:
> On Thu, Sep 27, 2012 at 09:37:14PM +0400, Cyrill Gorcunov wrote:
> > On Thu, Sep 27, 2012 at 07:33:27PM +0200, Jiri Slaby wrote:
> > >
> > > Hi!
> > >
> > > This check is not needed as the ioctls are master-only.
> >
> > Hi, thanks, Jiri, i'll update (was hurry to provide patches
> > so missed this ;)
>
> Don't rush, anything you do here will be for 3.8, not 3.7, it's too late
> for that, the tty tree already has lots of changes for 3.7.
>
> So take your time please.
Sure, patching other archs ioctls is not as simple as I thought,
need to recheck everything and I think better to do all this in
3 patches
- move ptkmode setting into pty
- introduce new ioctl codes (including patching other archs)
- add real handlers for this new ioctl codes
this will help for bisection.
Cyrill
next prev parent reply other threads:[~2012-09-27 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 16:59 [patch 0/2] Add get- ioctls to fetch some bits from tty/pty status Cyrill Gorcunov
2012-09-27 16:59 ` [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c Cyrill Gorcunov
2012-09-27 17:33 ` Jiri Slaby
2012-09-27 17:37 ` Cyrill Gorcunov
2012-09-27 18:14 ` Greg KH
2012-09-27 18:18 ` Cyrill Gorcunov [this message]
2012-09-27 17:40 ` Cyrill Gorcunov
2012-09-27 17:00 ` [patch 2/2] tty: Add get- ioctls to fetch tty status v2 Cyrill Gorcunov
2012-09-27 17:42 ` Cyrill Gorcunov
2012-09-27 17:49 ` Jiri Slaby
2012-09-27 17:58 ` Cyrill Gorcunov
2012-09-27 18:01 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927181858.GV6618@moon \
--to=gorcunov@openvz.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.