From: Jiri Slaby <jslaby@suse.cz>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
hpa@zytor.com, gregkh@linuxfoundation.org, xemul@parallels.com
Subject: Re: [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c
Date: Thu, 27 Sep 2012 19:33:27 +0200 [thread overview]
Message-ID: <50648DE7.2060904@suse.cz> (raw)
In-Reply-To: <20120927170137.722717394@openvz.org>
On 09/27/2012 06:59 PM, Cyrill Gorcunov wrote:
> --- tty.git.orig/drivers/tty/pty.c
> +++ tty.git/drivers/tty/pty.c
> @@ -174,6 +174,31 @@ static int pty_set_lock(struct tty_struc
> return 0;
> }
>
> +/* Set the packet mode on a pty */
> +static int pty_set_pktmode(struct tty_struct *tty, int __user *arg)
> +{
> + unsigned long flags;
> + int pktmode;
> +
> + if (tty->driver->subtype != PTY_TYPE_MASTER)
> + return -ENOTTY;
Hi!
This check is not needed as the ioctls are master-only.
--
js
suse labs
next prev parent reply other threads:[~2012-09-27 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 16:59 [patch 0/2] Add get- ioctls to fetch some bits from tty/pty status Cyrill Gorcunov
2012-09-27 16:59 ` [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c Cyrill Gorcunov
2012-09-27 17:33 ` Jiri Slaby [this message]
2012-09-27 17:37 ` Cyrill Gorcunov
2012-09-27 18:14 ` Greg KH
2012-09-27 18:18 ` Cyrill Gorcunov
2012-09-27 17:40 ` Cyrill Gorcunov
2012-09-27 17:00 ` [patch 2/2] tty: Add get- ioctls to fetch tty status v2 Cyrill Gorcunov
2012-09-27 17:42 ` Cyrill Gorcunov
2012-09-27 17:49 ` Jiri Slaby
2012-09-27 17:58 ` Cyrill Gorcunov
2012-09-27 18:01 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50648DE7.2060904@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gorcunov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.