* [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6
@ 2012-09-11 18:56 John Stultz
2012-09-11 18:56 ` [PATCH 1/3] 3.5.y: time: Improve sanity checking of timekeeping inputs John Stultz
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: John Stultz @ 2012-09-11 18:56 UTC (permalink / raw)
To: stable; +Cc: John Stultz, Prarit Bhargava, Thomas Gleixner, Linux Kernel
Just wanted to send out a few timekeeping fixes that were merged
in 3.6 which are appropriate for -stable.
This queue backports the following fixes:
-----------------------------------------
cee58483cf56e0ba355fdd97ff5e8925329aa936 time: Move ktime_t overflow checking into timespec_valid_strict
bf2ac312195155511a0f79325515cbb61929898a time: Avoid making adjustments if we haven't accumulated anything
4e8b14526ca7fb046a81c94002c1c43b6fdf0e9b time: Improve sanity checking of timekeeping inputs
I've run these through my timetest suite w/ kvm on both i386
& x86_64. But more testing would be of course appreciated.
https://github.com/johnstultz-work/timetests
I also have patch queues for all the -stable trees that I'll be
sending out as my testing completes for those trees.
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
John Stultz (3):
3.5.y: time: Improve sanity checking of timekeeping inputs
3.5.y: time: Avoid making adjustments if we haven't accumulated
anything
3.5.y: time: Move ktime_t overflow checking into
timespec_valid_strict
include/linux/ktime.h | 7 -------
include/linux/time.h | 29 +++++++++++++++++++++++++++--
kernel/time/timekeeping.c | 32 +++++++++++++++++++++++++++++---
3 files changed, 56 insertions(+), 12 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/3] 3.5.y: time: Improve sanity checking of timekeeping inputs 2012-09-11 18:56 [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 John Stultz @ 2012-09-11 18:56 ` John Stultz 2012-09-27 20:49 ` Patch "time: Improve sanity checking of timekeeping inputs" has been added to the 3.5-stable tree gregkh 2012-09-11 18:56 ` [PATCH 2/3] 3.5.y: time: Avoid making adjustments if we haven't accumulated anything John Stultz ` (2 subsequent siblings) 3 siblings, 1 reply; 6+ messages in thread From: John Stultz @ 2012-09-11 18:56 UTC (permalink / raw) To: stable Cc: John Stultz, Peter Zijlstra, Prarit Bhargava, Zhouping Liu, Ingo Molnar, Thomas Gleixner, Linux Kernel This is a -stable backport of 4e8b14526ca7fb046a81c94002c1c43b6fdf0e9b Unexpected behavior could occur if the time is set to a value large enough to overflow a 64bit ktime_t (which is something larger then the year 2262). Also unexpected behavior could occur if large negative offsets are injected via adjtimex. So this patch improves the sanity check timekeeping inputs by improving the timespec_valid() check, and then makes better use of timespec_valid() to make sure we don't set the time to an invalid negative value or one that overflows ktime_t. Note: This does not protect from setting the time close to overflowing ktime_t and then letting natural accumulation cause the overflow. Reported-by: CAI Qian <caiqian@redhat.com> Reported-by: Sasha Levin <levinsasha928@gmail.com> Signed-off-by: John Stultz <john.stultz@linaro.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Zhouping Liu <zliu@redhat.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1344454580-17031-1-git-send-email-john.stultz@linaro.org Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Linux Kernel <linux-kernel@vger.kernel.org> Signed-off-by: John Stultz <john.stultz@linaro.org> --- include/linux/ktime.h | 7 ------- include/linux/time.h | 22 ++++++++++++++++++++-- kernel/time/timekeeping.c | 26 ++++++++++++++++++++++++-- 3 files changed, 44 insertions(+), 11 deletions(-) diff --git a/include/linux/ktime.h b/include/linux/ktime.h index 603bec2..06177ba10 100644 --- a/include/linux/ktime.h +++ b/include/linux/ktime.h @@ -58,13 +58,6 @@ union ktime { typedef union ktime ktime_t; /* Kill this */ -#define KTIME_MAX ((s64)~((u64)1 << 63)) -#if (BITS_PER_LONG == 64) -# define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC) -#else -# define KTIME_SEC_MAX LONG_MAX -#endif - /* * ktime_t definitions when using the 64-bit scalar representation: */ diff --git a/include/linux/time.h b/include/linux/time.h index c81c5e4..b0bbd8f 100644 --- a/include/linux/time.h +++ b/include/linux/time.h @@ -107,11 +107,29 @@ static inline struct timespec timespec_sub(struct timespec lhs, return ts_delta; } +#define KTIME_MAX ((s64)~((u64)1 << 63)) +#if (BITS_PER_LONG == 64) +# define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC) +#else +# define KTIME_SEC_MAX LONG_MAX +#endif + /* * Returns true if the timespec is norm, false if denorm: */ -#define timespec_valid(ts) \ - (((ts)->tv_sec >= 0) && (((unsigned long) (ts)->tv_nsec) < NSEC_PER_SEC)) +static inline bool timespec_valid(const struct timespec *ts) +{ + /* Dates before 1970 are bogus */ + if (ts->tv_sec < 0) + return false; + /* Can't have more nanoseconds then a second */ + if ((unsigned long)ts->tv_nsec >= NSEC_PER_SEC) + return false; + /* Disallow values that could overflow ktime_t */ + if ((unsigned long long)ts->tv_sec >= KTIME_SEC_MAX) + return false; + return true; +} extern void read_persistent_clock(struct timespec *ts); extern void read_boot_clock(struct timespec *ts); diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 3447cfa..fd06ae8 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -384,7 +384,7 @@ int do_settimeofday(const struct timespec *tv) struct timespec ts_delta; unsigned long flags; - if ((unsigned long)tv->tv_nsec >= NSEC_PER_SEC) + if (!timespec_valid(tv)) return -EINVAL; write_seqlock_irqsave(&timekeeper.lock, flags); @@ -418,6 +418,8 @@ EXPORT_SYMBOL(do_settimeofday); int timekeeping_inject_offset(struct timespec *ts) { unsigned long flags; + struct timespec tmp; + int ret = 0; if ((unsigned long)ts->tv_nsec >= NSEC_PER_SEC) return -EINVAL; @@ -426,10 +428,17 @@ int timekeeping_inject_offset(struct timespec *ts) timekeeping_forward_now(); + tmp = timespec_add(timekeeper.xtime, *ts); + if (!timespec_valid(&tmp)) { + ret = -EINVAL; + goto error; + } + timekeeper.xtime = timespec_add(timekeeper.xtime, *ts); timekeeper.wall_to_monotonic = timespec_sub(timekeeper.wall_to_monotonic, *ts); +error: /* even if we error out, we forwarded the time, so call update */ timekeeping_update(true); write_sequnlock_irqrestore(&timekeeper.lock, flags); @@ -437,7 +446,7 @@ int timekeeping_inject_offset(struct timespec *ts) /* signal hrtimers about time change */ clock_was_set(); - return 0; + return ret; } EXPORT_SYMBOL(timekeeping_inject_offset); @@ -597,7 +606,20 @@ void __init timekeeping_init(void) struct timespec now, boot; read_persistent_clock(&now); + if (!timespec_valid(&now)) { + pr_warn("WARNING: Persistent clock returned invalid value!\n" + " Check your CMOS/BIOS settings.\n"); + now.tv_sec = 0; + now.tv_nsec = 0; + } + read_boot_clock(&boot); + if (!timespec_valid(&boot)) { + pr_warn("WARNING: Boot clock returned invalid value!\n" + " Check your CMOS/BIOS settings.\n"); + boot.tv_sec = 0; + boot.tv_nsec = 0; + } seqlock_init(&timekeeper.lock); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Patch "time: Improve sanity checking of timekeeping inputs" has been added to the 3.5-stable tree 2012-09-11 18:56 ` [PATCH 1/3] 3.5.y: time: Improve sanity checking of timekeeping inputs John Stultz @ 2012-09-27 20:49 ` gregkh 0 siblings, 0 replies; 6+ messages in thread From: gregkh @ 2012-09-27 20:49 UTC (permalink / raw) To: john.stultz, a.p.zijlstra, caiqian, gregkh, levinsasha928, mingo, prarit, tglx, zliu Cc: stable, stable-commits This is a note to let you know that I've just added the patch titled time: Improve sanity checking of timekeeping inputs to the 3.5-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: time-improve-sanity-checking-of-timekeeping-inputs.patch and it can be found in the queue-3.5 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@vger.kernel.org> know about it. >From john.stultz@linaro.org Thu Sep 27 13:27:22 2012 From: John Stultz <john.stultz@linaro.org> Date: Tue, 11 Sep 2012 14:56:19 -0400 Subject: time: Improve sanity checking of timekeeping inputs To: stable@vger.kernel.org Cc: John Stultz <john.stultz@linaro.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Prarit Bhargava <prarit@redhat.com>, Zhouping Liu <zliu@redhat.com>, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de> Message-ID: <1347389781-54602-2-git-send-email-john.stultz@linaro.org> From: John Stultz <john.stultz@linaro.org> commit 4e8b14526ca7fb046a81c94002c1c43b6fdf0e9b upstream. Unexpected behavior could occur if the time is set to a value large enough to overflow a 64bit ktime_t (which is something larger then the year 2262). Also unexpected behavior could occur if large negative offsets are injected via adjtimex. So this patch improves the sanity check timekeeping inputs by improving the timespec_valid() check, and then makes better use of timespec_valid() to make sure we don't set the time to an invalid negative value or one that overflows ktime_t. Note: This does not protect from setting the time close to overflowing ktime_t and then letting natural accumulation cause the overflow. Reported-by: CAI Qian <caiqian@redhat.com> Reported-by: Sasha Levin <levinsasha928@gmail.com> Signed-off-by: John Stultz <john.stultz@linaro.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Zhouping Liu <zliu@redhat.com> Cc: Ingo Molnar <mingo@kernel.org> Link: http://lkml.kernel.org/r/1344454580-17031-1-git-send-email-john.stultz@linaro.org Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: John Stultz <john.stultz@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- include/linux/ktime.h | 7 ------- include/linux/time.h | 22 ++++++++++++++++++++-- kernel/time/timekeeping.c | 26 ++++++++++++++++++++++++-- 3 files changed, 44 insertions(+), 11 deletions(-) --- a/include/linux/ktime.h +++ b/include/linux/ktime.h @@ -58,13 +58,6 @@ union ktime { typedef union ktime ktime_t; /* Kill this */ -#define KTIME_MAX ((s64)~((u64)1 << 63)) -#if (BITS_PER_LONG == 64) -# define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC) -#else -# define KTIME_SEC_MAX LONG_MAX -#endif - /* * ktime_t definitions when using the 64-bit scalar representation: */ --- a/include/linux/time.h +++ b/include/linux/time.h @@ -107,11 +107,29 @@ static inline struct timespec timespec_s return ts_delta; } +#define KTIME_MAX ((s64)~((u64)1 << 63)) +#if (BITS_PER_LONG == 64) +# define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC) +#else +# define KTIME_SEC_MAX LONG_MAX +#endif + /* * Returns true if the timespec is norm, false if denorm: */ -#define timespec_valid(ts) \ - (((ts)->tv_sec >= 0) && (((unsigned long) (ts)->tv_nsec) < NSEC_PER_SEC)) +static inline bool timespec_valid(const struct timespec *ts) +{ + /* Dates before 1970 are bogus */ + if (ts->tv_sec < 0) + return false; + /* Can't have more nanoseconds then a second */ + if ((unsigned long)ts->tv_nsec >= NSEC_PER_SEC) + return false; + /* Disallow values that could overflow ktime_t */ + if ((unsigned long long)ts->tv_sec >= KTIME_SEC_MAX) + return false; + return true; +} extern void read_persistent_clock(struct timespec *ts); extern void read_boot_clock(struct timespec *ts); --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -384,7 +384,7 @@ int do_settimeofday(const struct timespe struct timespec ts_delta; unsigned long flags; - if ((unsigned long)tv->tv_nsec >= NSEC_PER_SEC) + if (!timespec_valid(tv)) return -EINVAL; write_seqlock_irqsave(&timekeeper.lock, flags); @@ -418,6 +418,8 @@ EXPORT_SYMBOL(do_settimeofday); int timekeeping_inject_offset(struct timespec *ts) { unsigned long flags; + struct timespec tmp; + int ret = 0; if ((unsigned long)ts->tv_nsec >= NSEC_PER_SEC) return -EINVAL; @@ -426,10 +428,17 @@ int timekeeping_inject_offset(struct tim timekeeping_forward_now(); + tmp = timespec_add(timekeeper.xtime, *ts); + if (!timespec_valid(&tmp)) { + ret = -EINVAL; + goto error; + } + timekeeper.xtime = timespec_add(timekeeper.xtime, *ts); timekeeper.wall_to_monotonic = timespec_sub(timekeeper.wall_to_monotonic, *ts); +error: /* even if we error out, we forwarded the time, so call update */ timekeeping_update(true); write_sequnlock_irqrestore(&timekeeper.lock, flags); @@ -437,7 +446,7 @@ int timekeeping_inject_offset(struct tim /* signal hrtimers about time change */ clock_was_set(); - return 0; + return ret; } EXPORT_SYMBOL(timekeeping_inject_offset); @@ -597,7 +606,20 @@ void __init timekeeping_init(void) struct timespec now, boot; read_persistent_clock(&now); + if (!timespec_valid(&now)) { + pr_warn("WARNING: Persistent clock returned invalid value!\n" + " Check your CMOS/BIOS settings.\n"); + now.tv_sec = 0; + now.tv_nsec = 0; + } + read_boot_clock(&boot); + if (!timespec_valid(&boot)) { + pr_warn("WARNING: Boot clock returned invalid value!\n" + " Check your CMOS/BIOS settings.\n"); + boot.tv_sec = 0; + boot.tv_nsec = 0; + } seqlock_init(&timekeeper.lock); Patches currently in stable-queue which might be from john.stultz@linaro.org are queue-3.5/time-avoid-making-adjustments-if-we-haven-t-accumulated-anything.patch queue-3.5/time-move-ktime_t-overflow-checking-into-timespec_valid_strict.patch queue-3.5/time-improve-sanity-checking-of-timekeeping-inputs.patch ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] 3.5.y: time: Avoid making adjustments if we haven't accumulated anything 2012-09-11 18:56 [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 John Stultz 2012-09-11 18:56 ` [PATCH 1/3] 3.5.y: time: Improve sanity checking of timekeeping inputs John Stultz @ 2012-09-11 18:56 ` John Stultz 2012-09-11 18:56 ` [PATCH 3/3] 3.5.y: time: Move ktime_t overflow checking into timespec_valid_strict John Stultz 2012-09-27 20:30 ` [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 Greg KH 3 siblings, 0 replies; 6+ messages in thread From: John Stultz @ 2012-09-11 18:56 UTC (permalink / raw) To: stable Cc: John Stultz, Prarit Bhargava, Ingo Molnar, Thomas Gleixner, Linux Kernel This is a -stable backport of bf2ac312195155511a0f79325515cbb61929898a If update_wall_time() is called and the current offset isn't large enough to accumulate, avoid re-calling timekeeping_adjust which may change the clock freq and can cause 1ns inconsistencies with CLOCK_REALTIME_COARSE/CLOCK_MONOTONIC_COARSE. Signed-off-by: John Stultz <john.stultz@linaro.org> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1345595449-34965-5-git-send-email-john.stultz@linaro.org Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Linux Kernel <linux-kernel@vger.kernel.org> Signed-off-by: John Stultz <john.stultz@linaro.org> --- kernel/time/timekeeping.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index fd06ae8..df9447b 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -1055,6 +1055,10 @@ static void update_wall_time(void) #else offset = (clock->read(clock) - clock->cycle_last) & clock->mask; #endif + /* Check if there's really nothing to do */ + if (offset < timekeeper.cycle_interval) + goto out; + timekeeper.xtime_nsec = (s64)timekeeper.xtime.tv_nsec << timekeeper.shift; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] 3.5.y: time: Move ktime_t overflow checking into timespec_valid_strict 2012-09-11 18:56 [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 John Stultz 2012-09-11 18:56 ` [PATCH 1/3] 3.5.y: time: Improve sanity checking of timekeeping inputs John Stultz 2012-09-11 18:56 ` [PATCH 2/3] 3.5.y: time: Avoid making adjustments if we haven't accumulated anything John Stultz @ 2012-09-11 18:56 ` John Stultz 2012-09-27 20:30 ` [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 Greg KH 3 siblings, 0 replies; 6+ messages in thread From: John Stultz @ 2012-09-11 18:56 UTC (permalink / raw) To: stable Cc: John Stultz, Zhouping Liu, Ingo Molnar, Prarit Bhargava, Thomas Gleixner, Linus Torvalds, Linux Kernel This is a -stable backport of cee58483cf56e0ba355fdd97ff5e8925329aa936 Andreas Bombe reported that the added ktime_t overflow checking added to timespec_valid in commit 4e8b14526ca7 ("time: Improve sanity checking of timekeeping inputs") was causing problems with X.org because it caused timeouts larger then KTIME_T to be invalid. Previously, these large timeouts would be clamped to KTIME_MAX and would never expire, which is valid. This patch splits the ktime_t overflow checking into a new timespec_valid_strict function, and converts the timekeeping codes internal checking to use this more strict function. Reported-and-tested-by: Andreas Bombe <aeb@debian.org> Cc: Zhouping Liu <zliu@redhat.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: stable@vger.kernel.org Signed-off-by: John Stultz <john.stultz@linaro.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Linux Kernel <linux-kernel@vger.kernel.org> Signed-off-by: John Stultz <john.stultz@linaro.org> --- include/linux/time.h | 7 +++++++ kernel/time/timekeeping.c | 10 +++++----- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/include/linux/time.h b/include/linux/time.h index b0bbd8f..b51e664 100644 --- a/include/linux/time.h +++ b/include/linux/time.h @@ -125,6 +125,13 @@ static inline bool timespec_valid(const struct timespec *ts) /* Can't have more nanoseconds then a second */ if ((unsigned long)ts->tv_nsec >= NSEC_PER_SEC) return false; + return true; +} + +static inline bool timespec_valid_strict(const struct timespec *ts) +{ + if (!timespec_valid(ts)) + return false; /* Disallow values that could overflow ktime_t */ if ((unsigned long long)ts->tv_sec >= KTIME_SEC_MAX) return false; diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index df9447b..63c88c1 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -384,7 +384,7 @@ int do_settimeofday(const struct timespec *tv) struct timespec ts_delta; unsigned long flags; - if (!timespec_valid(tv)) + if (!timespec_valid_strict(tv)) return -EINVAL; write_seqlock_irqsave(&timekeeper.lock, flags); @@ -429,7 +429,7 @@ int timekeeping_inject_offset(struct timespec *ts) timekeeping_forward_now(); tmp = timespec_add(timekeeper.xtime, *ts); - if (!timespec_valid(&tmp)) { + if (!timespec_valid_strict(&tmp)) { ret = -EINVAL; goto error; } @@ -606,7 +606,7 @@ void __init timekeeping_init(void) struct timespec now, boot; read_persistent_clock(&now); - if (!timespec_valid(&now)) { + if (!timespec_valid_strict(&now)) { pr_warn("WARNING: Persistent clock returned invalid value!\n" " Check your CMOS/BIOS settings.\n"); now.tv_sec = 0; @@ -614,7 +614,7 @@ void __init timekeeping_init(void) } read_boot_clock(&boot); - if (!timespec_valid(&boot)) { + if (!timespec_valid_strict(&boot)) { pr_warn("WARNING: Boot clock returned invalid value!\n" " Check your CMOS/BIOS settings.\n"); boot.tv_sec = 0; @@ -665,7 +665,7 @@ static void update_sleep_time(struct timespec t) */ static void __timekeeping_inject_sleeptime(struct timespec *delta) { - if (!timespec_valid(delta)) { + if (!timespec_valid_strict(delta)) { printk(KERN_WARNING "__timekeeping_inject_sleeptime: Invalid " "sleep delta value!\n"); return; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 2012-09-11 18:56 [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 John Stultz ` (2 preceding siblings ...) 2012-09-11 18:56 ` [PATCH 3/3] 3.5.y: time: Move ktime_t overflow checking into timespec_valid_strict John Stultz @ 2012-09-27 20:30 ` Greg KH 3 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2012-09-27 20:30 UTC (permalink / raw) To: John Stultz; +Cc: stable, Prarit Bhargava, Thomas Gleixner, Linux Kernel On Tue, Sep 11, 2012 at 02:56:18PM -0400, John Stultz wrote: > Just wanted to send out a few timekeeping fixes that were merged > in 3.6 which are appropriate for -stable. > > This queue backports the following fixes: > ----------------------------------------- > cee58483cf56e0ba355fdd97ff5e8925329aa936 time: Move ktime_t overflow checking into timespec_valid_strict > bf2ac312195155511a0f79325515cbb61929898a time: Avoid making adjustments if we haven't accumulated anything > 4e8b14526ca7fb046a81c94002c1c43b6fdf0e9b time: Improve sanity checking of timekeeping inputs > > I've run these through my timetest suite w/ kvm on both i386 > & x86_64. But more testing would be of course appreciated. > https://github.com/johnstultz-work/timetests > > I also have patch queues for all the -stable trees that I'll be > sending out as my testing completes for those trees. Applied, thanks. greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-27 20:49 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-11 18:56 [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 John Stultz 2012-09-11 18:56 ` [PATCH 1/3] 3.5.y: time: Improve sanity checking of timekeeping inputs John Stultz 2012-09-27 20:49 ` Patch "time: Improve sanity checking of timekeeping inputs" has been added to the 3.5-stable tree gregkh 2012-09-11 18:56 ` [PATCH 2/3] 3.5.y: time: Avoid making adjustments if we haven't accumulated anything John Stultz 2012-09-11 18:56 ` [PATCH 3/3] 3.5.y: time: Move ktime_t overflow checking into timespec_valid_strict John Stultz 2012-09-27 20:30 ` [PATCH 0/3] 3.5-stable timekeeping fixes merged in 3.6 Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.