From: Fengguang Wu <fengguang.wu@intel.com>
To: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
Cc: kernel-janitors@vger.kernel.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Andrei Emeltchenko <andrei.emeltchenko@intel.com>,
linux-bluetooth@vger.kernel.org
Subject: [bluetooth:master 231/247] net/bluetooth/amp.c:150:55: sparse: bad constant expression
Date: Fri, 28 Sep 2012 01:24:17 +0000 [thread overview]
Message-ID: <20120928012417.GH5522@localhost> (raw)
Hi Dmitry,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
head: 29d8a5909bba10accb82eb805c884a2943d7710f
commit: ba221bbabadd5fc2c80677b52178138fd694cc26 [231/247] Bluetooth: Add function to derive AMP key using hmac
+ net/bluetooth/amp.c:150:55: sparse: bad constant expression
net/bluetooth/amp.c:130:12: warning: 'hmac_sha256' defined but not used [-Wunused-function]
vim +150 net/bluetooth/amp.c
ba221bba (Dmitry Kasatkin 2012-09-27 144) ret = crypto_shash_setkey(tfm, key, ksize);
ba221bba (Dmitry Kasatkin 2012-09-27 145) if (ret) {
ba221bba (Dmitry Kasatkin 2012-09-27 146) BT_DBG("crypto_ahash_setkey failed: err %d", ret);
ba221bba (Dmitry Kasatkin 2012-09-27 147) } else {
ba221bba (Dmitry Kasatkin 2012-09-27 148) struct {
ba221bba (Dmitry Kasatkin 2012-09-27 149) struct shash_desc shash;
ba221bba (Dmitry Kasatkin 2012-09-27 @150) char ctx[crypto_shash_descsize(tfm)];
ba221bba (Dmitry Kasatkin 2012-09-27 151) } desc;
ba221bba (Dmitry Kasatkin 2012-09-27 152)
ba221bba (Dmitry Kasatkin 2012-09-27 153) desc.shash.tfm = tfm;
ba221bba (Dmitry Kasatkin 2012-09-27 154) desc.shash.flags = CRYPTO_TFM_REQ_MAY_SLEEP;
ba221bba (Dmitry Kasatkin 2012-09-27 155)
ba221bba (Dmitry Kasatkin 2012-09-27 156) ret = crypto_shash_digest(&desc.shash, plaintext, psize,
ba221bba (Dmitry Kasatkin 2012-09-27 157) output);
ba221bba (Dmitry Kasatkin 2012-09-27 158) }
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
Cc: kernel-janitors@vger.kernel.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Andrei Emeltchenko <andrei.emeltchenko@intel.com>,
linux-bluetooth@vger.kernel.org
Subject: [bluetooth:master 231/247] net/bluetooth/amp.c:150:55: sparse: bad constant expression
Date: Fri, 28 Sep 2012 09:24:17 +0800 [thread overview]
Message-ID: <20120928012417.GH5522@localhost> (raw)
Hi Dmitry,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
head: 29d8a5909bba10accb82eb805c884a2943d7710f
commit: ba221bbabadd5fc2c80677b52178138fd694cc26 [231/247] Bluetooth: Add function to derive AMP key using hmac
+ net/bluetooth/amp.c:150:55: sparse: bad constant expression
net/bluetooth/amp.c:130:12: warning: 'hmac_sha256' defined but not used [-Wunused-function]
vim +150 net/bluetooth/amp.c
ba221bba (Dmitry Kasatkin 2012-09-27 144) ret = crypto_shash_setkey(tfm, key, ksize);
ba221bba (Dmitry Kasatkin 2012-09-27 145) if (ret) {
ba221bba (Dmitry Kasatkin 2012-09-27 146) BT_DBG("crypto_ahash_setkey failed: err %d", ret);
ba221bba (Dmitry Kasatkin 2012-09-27 147) } else {
ba221bba (Dmitry Kasatkin 2012-09-27 148) struct {
ba221bba (Dmitry Kasatkin 2012-09-27 149) struct shash_desc shash;
ba221bba (Dmitry Kasatkin 2012-09-27 @150) char ctx[crypto_shash_descsize(tfm)];
ba221bba (Dmitry Kasatkin 2012-09-27 151) } desc;
ba221bba (Dmitry Kasatkin 2012-09-27 152)
ba221bba (Dmitry Kasatkin 2012-09-27 153) desc.shash.tfm = tfm;
ba221bba (Dmitry Kasatkin 2012-09-27 154) desc.shash.flags = CRYPTO_TFM_REQ_MAY_SLEEP;
ba221bba (Dmitry Kasatkin 2012-09-27 155)
ba221bba (Dmitry Kasatkin 2012-09-27 156) ret = crypto_shash_digest(&desc.shash, plaintext, psize,
ba221bba (Dmitry Kasatkin 2012-09-27 157) output);
ba221bba (Dmitry Kasatkin 2012-09-27 158) }
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
next reply other threads:[~2012-09-28 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 1:24 Fengguang Wu [this message]
2012-09-28 1:24 ` [bluetooth:master 231/247] net/bluetooth/amp.c:150:55: sparse: bad constant expression Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928012417.GH5522@localhost \
--to=fengguang.wu@intel.com \
--cc=andrei.emeltchenko@intel.com \
--cc=dmitry.kasatkin@intel.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.