From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: sameo@linux.intel.com, marex@denx.de,
ashish.jangam@kpitcummins.com, dchen@diasemi.com, arnd@arndb.de,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe
Date: Fri, 28 Sep 2012 11:49:44 +0100 [thread overview]
Message-ID: <20120928104944.GB30869@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1348797458-2562-1-git-send-email-festevam@gmail.com>
On Thu, Sep 27, 2012 at 10:57:38PM -0300, Fabio Estevam wrote:
> - da9052->irq_base = regmap_irq_chip_get_base(da9052->irq_data);
> + da9052->irq = regmap_irq_get_virq(da9052->irq_data, DA9052_IRQ_ADC_EOM);
>
> - ret = request_threaded_irq(DA9052_IRQ_ADC_EOM, NULL, da9052_auxadc_irq,
> + if (da9052->irq < 0) {
> + ret = da9052->irq;
> + dev_err(da9052->dev, "regmap_irq_get_virq failed: %d\n", ret);
> + goto regmap_err;
> + }
> +
> + ret = request_threaded_irq(da9052->irq, NULL, da9052_auxadc_irq,
This will fix the problem but the usage of da9052->irq here is very odd,
normally that'd be the primary IRQ for the device but this is actually
just the interrupt for the ADC.
Otherwise
Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2012-09-28 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 1:57 [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe Fabio Estevam
2012-09-28 6:42 ` Arnd Bergmann
2012-09-28 10:45 ` Fabio Estevam
2012-09-28 11:34 ` Arnd Bergmann
2012-09-28 10:52 ` Mark Brown
2012-09-28 11:35 ` Arnd Bergmann
2012-09-28 10:49 ` Mark Brown [this message]
2012-09-28 14:33 ` Fabio Estevam
2012-09-28 14:29 ` Mark Brown
2012-09-28 15:37 ` Fabio Estevam
2012-09-28 15:51 ` Mark Brown
2012-09-28 20:34 ` Fabio Estevam
2012-10-01 10:22 ` Mark Brown
2012-10-03 16:04 ` Fabio Estevam
2012-10-03 18:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928104944.GB30869@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.