From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Fabio Estevam <festevam@gmail.com>,
sameo@linux.intel.com, Marek Vasut <marex@denx.de>,
ashish.jangam@kpitcummins.com, dchen@diasemi.com, arnd@arndb.de,
kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe
Date: Fri, 28 Sep 2012 15:29:24 +0100 [thread overview]
Message-ID: <20120928142924.GA22101@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5065B534.7040602@freescale.com>
On Fri, Sep 28, 2012 at 11:33:24AM -0300, Fabio Estevam wrote:
> Would you prefer the version below? If so, I can send it as v3:
> - da9052->irq_base = regmap_irq_chip_get_base(da9052->irq_data);
> + da9052->irq = regmap_irq_get_virq(da9052->irq_data, 0);
No, this doesn't support linear domains, if you're going to do this it'd
be better to just leave it as irq_base though as discussed that's not
ideal. When I've done these conversions I've just done the virq
conversion at every use.
next prev parent reply other threads:[~2012-09-28 14:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 1:57 [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe Fabio Estevam
2012-09-28 6:42 ` Arnd Bergmann
2012-09-28 10:45 ` Fabio Estevam
2012-09-28 11:34 ` Arnd Bergmann
2012-09-28 10:52 ` Mark Brown
2012-09-28 11:35 ` Arnd Bergmann
2012-09-28 10:49 ` Mark Brown
2012-09-28 14:33 ` Fabio Estevam
2012-09-28 14:29 ` Mark Brown [this message]
2012-09-28 15:37 ` Fabio Estevam
2012-09-28 15:51 ` Mark Brown
2012-09-28 20:34 ` Fabio Estevam
2012-10-01 10:22 ` Mark Brown
2012-10-03 16:04 ` Fabio Estevam
2012-10-03 18:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928142924.GA22101@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.