From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 06/13] xfs: xfs_sync_data is redundant.
Date: Fri, 28 Sep 2012 08:34:43 -0400 [thread overview]
Message-ID: <20120928123443.GD14284@infradead.org> (raw)
In-Reply-To: <1348807485-20165-7-git-send-email-david@fromorbit.com>
> /*
> + * Flush all dirty data to disk. Must not be called while holding an XFS_ILOCK
slightly too long line.
> + * or a page lock.
> + */
> +static inline void
> +xfs_flush_inodes(struct xfs_inode *ip)
> +{
> + writeback_inodes_sb_if_idle(VFS_I(ip)->i_sb, WB_REASON_FS_FREE_SPACE);
> +}
Passing an inode here seems very odd, an xfs_mount would be the proper
interface.
Looks fine modulo these cosmetic changes, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-28 12:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 4:44 [PATCH V3 00/13] xfs: remove the xfssyncd mess Dave Chinner
2012-09-28 4:44 ` [PATCH 01/13] xfs: xfs_syncd_stop must die Dave Chinner
2012-09-28 4:44 ` [PATCH 02/13] xfs: rationalise xfs_mount_wq users Dave Chinner
2012-09-28 12:27 ` Christoph Hellwig
2012-09-28 4:44 ` [PATCH 03/13] xfs: don't run the sync work if the filesystem is read-only Dave Chinner
2012-09-28 12:27 ` Christoph Hellwig
2012-09-28 4:44 ` [PATCH 04/13] xfs: sync work is now only periodic log work Dave Chinner
2012-09-28 12:31 ` Christoph Hellwig
2012-09-28 4:44 ` [PATCH 05/13] xfs: Bring some sanity to log unmounting Dave Chinner
2012-09-28 4:44 ` [PATCH 06/13] xfs: xfs_sync_data is redundant Dave Chinner
2012-09-28 12:34 ` Christoph Hellwig [this message]
2012-10-01 17:44 ` Ben Myers
2012-10-02 0:14 ` Dave Chinner
2012-10-02 19:39 ` Ben Myers
2012-09-28 21:44 ` Mark Tinguely
2012-10-01 20:14 ` Brian Foster
2012-10-01 21:31 ` Mark Tinguely
2012-10-02 0:10 ` Dave Chinner
2012-10-02 0:44 ` Brian Foster
2012-10-02 13:01 ` Brian Foster
2012-10-02 20:51 ` Dave Chinner
2012-10-02 21:13 ` Brian Foster
2012-10-04 0:05 ` Ben Myers
2012-10-04 1:07 ` Dave Chinner
2012-10-02 13:22 ` Christoph Hellwig
2012-10-02 20:24 ` Dave Chinner
2012-10-02 20:25 ` Ben Myers
2012-09-28 4:44 ` [PATCH 07/13] xfs: syncd workqueue is no more Dave Chinner
2012-09-28 12:35 ` Christoph Hellwig
2012-09-28 18:17 ` Mark Tinguely
2012-10-01 17:54 ` Ben Myers
2012-09-28 4:44 ` [PATCH 08/13] xfs: xfs_sync_fsdata is redundant Dave Chinner
2012-09-28 4:44 ` [PATCH 09/13] xfs: move xfs_quiesce_attr() into xfs_super.c Dave Chinner
2012-09-28 4:44 ` [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like unmount Dave Chinner
2012-09-28 4:44 ` [PATCH 11/13] xfs: rename xfs_sync.[ch] to xfs_icache.[ch] Dave Chinner
2012-09-28 4:44 ` [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c Dave Chinner
2012-09-28 4:44 ` [PATCH 13/13] xfs: remove xfs_iget.c Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928123443.GD14284@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.