All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 07/13] xfs: syncd workqueue is no more
Date: Mon, 1 Oct 2012 12:54:02 -0500	[thread overview]
Message-ID: <20121001175402.GL13214@sgi.com> (raw)
In-Reply-To: <5065E9A3.3040707@sgi.com>

On Fri, Sep 28, 2012 at 01:17:07PM -0500, Mark Tinguely wrote:
> On 09/27/12 23:44, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >With the syncd functions moved to the log and/or removed, the syncd
> >workqueue is the only remaining bit left. It is used by the log
> >covering/ail pushing work, as well as by the inode reclaim work.
> >
> >Given how cheap workqueues are these days, give the log and inode
> >reclaim work their own work queues and kill the syncd work queue.
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
> 
> <deleted info>
> 
> >diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> >index fed1eb2..65cf42c 100644
> >--- a/fs/xfs/xfs_super.c
> >+++ b/fs/xfs/xfs_super.c
> >@@ -776,8 +776,23 @@ xfs_init_mount_workqueues(
> >  			WQ_MEM_RECLAIM, 0, mp->m_fsname);
> >  	if (!mp->m_cil_workqueue)
> >  		goto out_destroy_unwritten;
> >+
> >+	mp->m_reclaim_workqueue = alloc_workqueue("xfs-reclaim/%s",
> >+			WQ_NON_REENTRANT, 0, mp->m_fsname);
> >+	if (!mp->m_reclaim_workqueue)
> >+		goto out_destroy_cil;
> >+
> >+	mp->m_log_workqueue = alloc_workqueue("xfs-reclaim/%s",
> >+			WQ_NON_REENTRANT, 0, mp->m_fsname);

Changed this to "xfs-log/%s" on Dave's behalf.

-Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-10-01 17:52 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28  4:44 [PATCH V3 00/13] xfs: remove the xfssyncd mess Dave Chinner
2012-09-28  4:44 ` [PATCH 01/13] xfs: xfs_syncd_stop must die Dave Chinner
2012-09-28  4:44 ` [PATCH 02/13] xfs: rationalise xfs_mount_wq users Dave Chinner
2012-09-28 12:27   ` Christoph Hellwig
2012-09-28  4:44 ` [PATCH 03/13] xfs: don't run the sync work if the filesystem is read-only Dave Chinner
2012-09-28 12:27   ` Christoph Hellwig
2012-09-28  4:44 ` [PATCH 04/13] xfs: sync work is now only periodic log work Dave Chinner
2012-09-28 12:31   ` Christoph Hellwig
2012-09-28  4:44 ` [PATCH 05/13] xfs: Bring some sanity to log unmounting Dave Chinner
2012-09-28  4:44 ` [PATCH 06/13] xfs: xfs_sync_data is redundant Dave Chinner
2012-09-28 12:34   ` Christoph Hellwig
2012-10-01 17:44     ` Ben Myers
2012-10-02  0:14       ` Dave Chinner
2012-10-02 19:39         ` Ben Myers
2012-09-28 21:44   ` Mark Tinguely
2012-10-01 20:14   ` Brian Foster
2012-10-01 21:31     ` Mark Tinguely
2012-10-02  0:10     ` Dave Chinner
2012-10-02  0:44       ` Brian Foster
2012-10-02 13:01         ` Brian Foster
2012-10-02 20:51           ` Dave Chinner
2012-10-02 21:13             ` Brian Foster
2012-10-04  0:05             ` Ben Myers
2012-10-04  1:07               ` Dave Chinner
2012-10-02 13:22       ` Christoph Hellwig
2012-10-02 20:24         ` Dave Chinner
2012-10-02 20:25     ` Ben Myers
2012-09-28  4:44 ` [PATCH 07/13] xfs: syncd workqueue is no more Dave Chinner
2012-09-28 12:35   ` Christoph Hellwig
2012-09-28 18:17   ` Mark Tinguely
2012-10-01 17:54     ` Ben Myers [this message]
2012-09-28  4:44 ` [PATCH 08/13] xfs: xfs_sync_fsdata is redundant Dave Chinner
2012-09-28  4:44 ` [PATCH 09/13] xfs: move xfs_quiesce_attr() into xfs_super.c Dave Chinner
2012-09-28  4:44 ` [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like unmount Dave Chinner
2012-09-28  4:44 ` [PATCH 11/13] xfs: rename xfs_sync.[ch] to xfs_icache.[ch] Dave Chinner
2012-09-28  4:44 ` [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c Dave Chinner
2012-09-28  4:44 ` [PATCH 13/13] xfs: remove xfs_iget.c Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121001175402.GL13214@sgi.com \
    --to=bpm@sgi.com \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.