From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Nazarewicz <mina86@mina86.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] CMA: decrease cc.nr_migratepages after reclaiming pagelist
Date: Fri, 28 Sep 2012 14:10:43 +0100 [thread overview]
Message-ID: <20120928131043.GD29125@suse.de> (raw)
In-Reply-To: <1348642212-29394-1-git-send-email-minchan@kernel.org>
On Wed, Sep 26, 2012 at 03:50:12PM +0900, Minchan Kim wrote:
> The reclaim_clean_pages_from_list reclaims clean pages before
> migration so cc.nr_migratepages should be updated.
> Currently, there is no problem but it can be wrong if we
> try to use the vaule in future.
>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Michal Nazarewicz <mina86@mina86.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Yeah ok. As you say, it shouldn't actually affect anything currently and
cc.migratepages is expected to go out of date after migration meaning we
need update_nr_listpages. This patch looks ok though.
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Nazarewicz <mina86@mina86.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] CMA: decrease cc.nr_migratepages after reclaiming pagelist
Date: Fri, 28 Sep 2012 14:10:43 +0100 [thread overview]
Message-ID: <20120928131043.GD29125@suse.de> (raw)
In-Reply-To: <1348642212-29394-1-git-send-email-minchan@kernel.org>
On Wed, Sep 26, 2012 at 03:50:12PM +0900, Minchan Kim wrote:
> The reclaim_clean_pages_from_list reclaims clean pages before
> migration so cc.nr_migratepages should be updated.
> Currently, there is no problem but it can be wrong if we
> try to use the vaule in future.
>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Michal Nazarewicz <mina86@mina86.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Yeah ok. As you say, it shouldn't actually affect anything currently and
cc.migratepages is expected to go out of date after migration meaning we
need update_nr_listpages. This patch looks ok though.
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2012-09-28 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 6:50 [PATCH] CMA: decrease cc.nr_migratepages after reclaiming pagelist Minchan Kim
2012-09-26 6:50 ` Minchan Kim
2012-09-28 13:10 ` Mel Gorman [this message]
2012-09-28 13:10 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928131043.GD29125@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.