From: Tony Lindgren <tony@atomide.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap
Date: Fri, 28 Sep 2012 08:05:38 -0700 [thread overview]
Message-ID: <20120928150538.GB4840@atomide.com> (raw)
In-Reply-To: <CAMQu2gw9DJSZ4QVvo83atTpnsXyegneuQ2rJKBc+5ioiwEaqaQ@mail.gmail.com>
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120928 08:02]:
> On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Lokesh Vutla <lokeshvutla@ti.com> [120928 06:41]:
> > > Move plat/dma.h header to platform_data/dma-omap.h as
> > > part of the single zImage work.
> >
> > Hmm there's no platform data in this header, just
> > exported things for drivers to use. So it should not
> > be placed into platform_data.
> >
> > Maybe it should be #include <asm/mach/dma-omap.h> for now?
> >
> I wasn't sure either when the file was placed under platform-data.
> I agree for now we can keep it mach layer but than means OMAP1 and
> OMAP2+ DMA header and source code needs to be split. That
> is not so straight forward.
No need for that, the path I'm suggesting is located under
arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.
> With DMA engine conversion hopefully, we might get rid of the
> header eventually, but for now not sure whether we should
> go ahead and follow the splitting part.
>
> Thoughts ?
No need for splitting anything :)
The other possible location would be just include <linux/dma-omap.h>,
but as we all know that will be going away, <asm/mach/dma-omap.h>
is probably better.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap
Date: Fri, 28 Sep 2012 08:05:38 -0700 [thread overview]
Message-ID: <20120928150538.GB4840@atomide.com> (raw)
In-Reply-To: <CAMQu2gw9DJSZ4QVvo83atTpnsXyegneuQ2rJKBc+5ioiwEaqaQ@mail.gmail.com>
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120928 08:02]:
> On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Lokesh Vutla <lokeshvutla@ti.com> [120928 06:41]:
> > > Move plat/dma.h header to platform_data/dma-omap.h as
> > > part of the single zImage work.
> >
> > Hmm there's no platform data in this header, just
> > exported things for drivers to use. So it should not
> > be placed into platform_data.
> >
> > Maybe it should be #include <asm/mach/dma-omap.h> for now?
> >
> I wasn't sure either when the file was placed under platform-data.
> I agree for now we can keep it mach layer but than means OMAP1 and
> OMAP2+ DMA header and source code needs to be split. That
> is not so straight forward.
No need for that, the path I'm suggesting is located under
arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.
> With DMA engine conversion hopefully, we might get rid of the
> header eventually, but for now not sure whether we should
> go ahead and follow the splitting part.
>
> Thoughts ?
No need for splitting anything :)
The other possible location would be just include <linux/dma-omap.h>,
but as we all know that will be going away, <asm/mach/dma-omap.h>
is probably better.
Tony
next prev parent reply other threads:[~2012-09-28 15:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 13:40 [PATCH 0/4] ARM: OMAP: Move plat/dma*.h,omap-secure.h headers as part of single zImage work Lokesh Vutla
2012-09-28 13:40 ` [PATCH 0/4] ARM: OMAP: Move plat/dma*.h, omap-secure.h " Lokesh Vutla
2012-09-28 13:40 ` [PATCH 1/4] ARM: OMAP: DMA: Removing plat/dma-44xx.h Lokesh Vutla
2012-09-28 13:40 ` Lokesh Vutla
2012-09-28 13:40 ` [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap Lokesh Vutla
2012-09-28 13:40 ` Lokesh Vutla
2012-09-28 14:55 ` Tony Lindgren
2012-09-28 14:55 ` Tony Lindgren
2012-09-28 15:01 ` Shilimkar, Santosh
2012-09-28 15:01 ` Shilimkar, Santosh
2012-09-28 15:05 ` Tony Lindgren [this message]
2012-09-28 15:05 ` Tony Lindgren
2012-09-28 15:11 ` Shilimkar, Santosh
2012-09-28 15:11 ` Shilimkar, Santosh
2012-09-28 15:54 ` Russell King - ARM Linux
2012-09-28 15:54 ` Russell King - ARM Linux
2012-09-28 19:35 ` Jon Hunter
2012-09-28 19:35 ` Jon Hunter
2012-09-29 16:57 ` Tony Lindgren
2012-09-29 16:57 ` Tony Lindgren
2012-10-01 8:51 ` Vutla, Lokesh
2012-10-01 8:51 ` Vutla, Lokesh
2012-09-28 13:40 ` [PATCH 3/4] ARM: OMAP: Move omap_reserve() locally to mach-omap1/2 Lokesh Vutla
2012-09-28 13:40 ` Lokesh Vutla
2012-09-29 19:39 ` Russell King - ARM Linux
2012-09-29 19:39 ` Russell King - ARM Linux
2012-09-30 8:20 ` Shilimkar, Santosh
2012-09-30 8:20 ` Shilimkar, Santosh
2012-09-30 18:05 ` Tony Lindgren
2012-09-30 18:05 ` Tony Lindgren
2012-10-01 5:01 ` Vutla, Lokesh
2012-10-01 5:01 ` Vutla, Lokesh
2012-09-28 13:40 ` [PATCH 4/4] ARM: OMAP: Move plat/omap-secure.h locally to mach-omap2 Lokesh Vutla
2012-09-28 13:40 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928150538.GB4840@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.