All of lore.kernel.org
 help / color / mirror / Atom feed
* re: ceph: factor out libceph from Ceph file system
@ 2012-09-28 15:46 Dan Carpenter
  2012-09-28 16:06 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-09-28 15:46 UTC (permalink / raw)
  To: yehuda; +Cc: ceph-devel

Hello Yehuda Sadeh,

This is a semi-automatic email about new static checker warnings.

The patch 3d14c5d2b6e1: "ceph: factor out libceph from Ceph file 
system" from Apr 6, 2010, leads to the following Smatch complaint:

fs/ceph/super.c:279 strcmp_null()
	 error: we previously assumed 's1' could be null (see line 277)

fs/ceph/super.c
   276			return -1;
   277		if (!s1 && s2)
                    ^^^^^^^^^
Check.

   278			return 1;
   279		return strcmp(s1, s2);
                       ^^^^^^^^^^^^^^
Dereference inside function call.

   280	}
   281	

regards,
dan carpenter

See also:

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: ceph: factor out libceph from Ceph file system
  2012-09-28 15:46 ceph: factor out libceph from Ceph file system Dan Carpenter
@ 2012-09-28 16:06 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-09-28 16:06 UTC (permalink / raw)
  To: yehuda; +Cc: ceph-devel

Oh crap.  I didn't read this at all.  Obviously a false positive.

Sorry about that.

regards,
dan carpenter



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-28 16:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-28 15:46 ceph: factor out libceph from Ceph file system Dan Carpenter
2012-09-28 16:06 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.