From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Ramesh Nagappa <ramesh.nagappa@ericsson.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"michel@digirati.com.br" <michel@digirati.com.br>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic
Date: Fri, 28 Sep 2012 17:57:21 -0700 [thread overview]
Message-ID: <20120929005721.GA13335@kroah.com> (raw)
In-Reply-To: <CA3E5132752D1F49871ED0FC40D56BBA43ECE2E743@EUSAACMS0701.eamcs.ericsson.se>
On Fri, Sep 28, 2012 at 08:26:51PM -0400, Ramesh Nagappa wrote:
> >
> > Why is all of this in the middle of the changelog section?
> >
> > I'm guessing you didn't use 'git send-email' for this?
> >
> > And why are you copying me on the patch?
>
> I got the CC list from scripts/get_maintainers.pl
>
> asglx-2-300 $ scripts/get_maintainer.pl 0001-net-fix-neigh_resolve_output-can-cause-skb_under_pan.patch
> "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL],commit_signer:3/4=75%)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:3/4=75%)
> Eric Dumazet <eric.dumazet@gmail.com> (commit_signer:2/4=50%)
> Shawn Lu <shawn.lu@ericsson.com> (commit_signer:1/4=25%)
> Michel Machado <michel@digirati.com.br> (commit_signer:1/4=25%)
> netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
> linux-kernel@vger.kernel.org (open list)
I can't reproduce this:
$ ./scripts/get_maintainer.pl --file net/core/neighbour.c
"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL],commit_signer:22/22=100%)
Eric Dumazet <edumazet@google.com> (commit_signer:4/22=18%)
"Eric W. Biederman" <ebiederm@xmission.com> (commit_signer:2/22=9%)
Pavel Emelyanov <xemul@parallels.com> (commit_signer:2/22=9%)
netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
linux-kernel@vger.kernel.org (open list)
What tree are you doing that against?
> > You need a blank line before the first Signed-off-by: line.
> > Surely one of the reviewers should have caught this basic thing?
>
> Outlook mangled the patch. I am unable to use git send-email because of
> a corporate firewall on the build machine.
Then your patch would also be corrupted, Outlook, and Exchange, can not
handle patches at all. Please read Documentation/email_clients.txt for
more details.
Also, ask your coworkers who properly submit patches what they do to
work around your broken email infrastructure.
good luck,
greg k-h
next prev parent reply other threads:[~2012-09-29 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 23:40 [PATCH] net: fix neigh_resolve_output can cause skb_under_panic Ramesh Nagappa
2012-09-28 23:52 ` gregkh
2012-09-29 0:17 ` Ramesh Nagappa
2012-09-29 0:26 ` Ramesh Nagappa
2012-09-29 0:57 ` gregkh [this message]
2012-10-01 18:00 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120929005721.GA13335@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@digirati.com.br \
--cc=netdev@vger.kernel.org \
--cc=ramesh.nagappa@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.