From: Fengguang Wu <fengguang.wu@intel.com>
To: stephen hemminger <shemminger@vyatta.com>
Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org
Subject: [wireless-next:for-davem 123/299] net/ipv4/ip_gre.c:222:29: sparse: restricted __be16 degrades to in
Date: Sat, 29 Sep 2012 01:12:10 +0000 [thread overview]
Message-ID: <20120929011210.GA10053@localhost> (raw)
Hi stephen,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git for-davem
head: c487606f835a93a725bac1aefd536be98f22474d
commit: d208328765a0ab425e36b5b828285f3337a85451 [123/299] gre: fix handling of key 0
+ net/ipv4/ip_gre.c:222:29: sparse: restricted __be16 degrades to integer
net/ipv4/ip_gre.c:227:34: sparse: restricted __be16 degrades to integer
+ net/ipv4/ip_gre.c:562:33: sparse: incorrect type in argument 4 (different base types)
net/ipv4/ip_gre.c:562:33: expected unsigned int [unsigned] [usertype] flags
net/ipv4/ip_gre.c:562:33: got restricted __be16 [assigned] [usertype] flags
net/ipv4/ip_gre.c:669:62: sparse: incorrect type in argument 4 (different base types)
net/ipv4/ip_gre.c:669:62: expected unsigned int [unsigned] [usertype] flags
net/ipv4/ip_gre.c:669:62: got restricted __be16 [assigned] [usertype] flags
vim +222 net/ipv4/ip_gre.c
d2083287 (stephen hemminger 2012-09-24 217) /* Does key in tunnel parameters match packet */
d2083287 (stephen hemminger 2012-09-24 218) static bool ipgre_key_match(const struct ip_tunnel_parm *p,
d2083287 (stephen hemminger 2012-09-24 219) __u32 flags, __be32 key)
d2083287 (stephen hemminger 2012-09-24 220) {
d2083287 (stephen hemminger 2012-09-24 221) if (p->i_flags & GRE_KEY) {
d2083287 (stephen hemminger 2012-09-24 @222) if (flags & GRE_KEY)
d2083287 (stephen hemminger 2012-09-24 223) return key = p->i_key;
d2083287 (stephen hemminger 2012-09-24 224) else
d2083287 (stephen hemminger 2012-09-24 225) return false; /* key expected, none present */
d2083287 (stephen hemminger 2012-09-24 226) } else
d2083287 (stephen hemminger 2012-09-24 227) return !(flags & GRE_KEY);
d2083287 (stephen hemminger 2012-09-24 228) }
d2083287 (stephen hemminger 2012-09-24 229)
^1da177e (Linus Torvalds 2005-04-16 230) /* Given src, dst and key, find appropriate for input tunnel. */
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: stephen hemminger <shemminger@vyatta.com>
Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org
Subject: [wireless-next:for-davem 123/299] net/ipv4/ip_gre.c:222:29: sparse: restricted __be16 degrades to integer
Date: Sat, 29 Sep 2012 09:12:10 +0800 [thread overview]
Message-ID: <20120929011210.GA10053@localhost> (raw)
Hi stephen,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git for-davem
head: c487606f835a93a725bac1aefd536be98f22474d
commit: d208328765a0ab425e36b5b828285f3337a85451 [123/299] gre: fix handling of key 0
+ net/ipv4/ip_gre.c:222:29: sparse: restricted __be16 degrades to integer
net/ipv4/ip_gre.c:227:34: sparse: restricted __be16 degrades to integer
+ net/ipv4/ip_gre.c:562:33: sparse: incorrect type in argument 4 (different base types)
net/ipv4/ip_gre.c:562:33: expected unsigned int [unsigned] [usertype] flags
net/ipv4/ip_gre.c:562:33: got restricted __be16 [assigned] [usertype] flags
net/ipv4/ip_gre.c:669:62: sparse: incorrect type in argument 4 (different base types)
net/ipv4/ip_gre.c:669:62: expected unsigned int [unsigned] [usertype] flags
net/ipv4/ip_gre.c:669:62: got restricted __be16 [assigned] [usertype] flags
vim +222 net/ipv4/ip_gre.c
d2083287 (stephen hemminger 2012-09-24 217) /* Does key in tunnel parameters match packet */
d2083287 (stephen hemminger 2012-09-24 218) static bool ipgre_key_match(const struct ip_tunnel_parm *p,
d2083287 (stephen hemminger 2012-09-24 219) __u32 flags, __be32 key)
d2083287 (stephen hemminger 2012-09-24 220) {
d2083287 (stephen hemminger 2012-09-24 221) if (p->i_flags & GRE_KEY) {
d2083287 (stephen hemminger 2012-09-24 @222) if (flags & GRE_KEY)
d2083287 (stephen hemminger 2012-09-24 223) return key == p->i_key;
d2083287 (stephen hemminger 2012-09-24 224) else
d2083287 (stephen hemminger 2012-09-24 225) return false; /* key expected, none present */
d2083287 (stephen hemminger 2012-09-24 226) } else
d2083287 (stephen hemminger 2012-09-24 227) return !(flags & GRE_KEY);
d2083287 (stephen hemminger 2012-09-24 228) }
d2083287 (stephen hemminger 2012-09-24 229)
^1da177e (Linus Torvalds 2005-04-16 230) /* Given src, dst and key, find appropriate for input tunnel. */
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
next reply other threads:[~2012-09-29 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 1:12 Fengguang Wu [this message]
2012-09-29 1:12 ` [wireless-next:for-davem 123/299] net/ipv4/ip_gre.c:222:29: sparse: restricted __be16 degrades to integer Fengguang Wu
2012-10-01 15:21 ` [PATCH] gre: fix sparse warning Stephen Hemminger
2012-10-01 15:21 ` Stephen Hemminger
2012-10-01 21:36 ` David Miller
2012-10-01 21:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120929011210.GA10053@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.