Re: [PATCH] kbuild: Fix gcc -x syntax

[Ingo Molnar <mingo@kernel.org>]

* Bernhard Walle <bernhard@bwalle.de> wrote:

> Hi,
> 
> * Ingo Molnar <mingo@kernel.org> [2012-09-29 08:37]:
> > * Jean Delvare <jdelvare@suse.de> wrote:
> > 
> > > The correct syntax for gcc -x is "gcc -x assembler", not "gcc 
> > > -xassembler". Even though the latter happens to work, the 
> > > former is what is documented in the manual page and thus what 
> > > gcc wrappers such as icecream do expect.
> > > 
> > > This isn't a cosmetic change. The missing space prevents 
> > > icecream from recognizing compilation tasks it can't handle, 
> > > leading to silent kernel miscompilations.
> > 
> > Although we can apply this patch, it won't solve the problem of 
> > building older kernels (and bisecting, etc.).
> > 
> > Wouldn't it be prudent to increase the compatibility of 
> > icecream, so that it accepts what GCC accepts in practice,
> > such as -xassembler?
> 
> Wouldn't it make sense to do both? Using the documented syntax 
> in the build system *and* increase compatibility in 3rd party 
> tools?

Yes.

Thanks,

	Ingo