[PATCH] leds-ot200: Fix error caused by shifted mask

[PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

During the development of this driver an in-house register
documentation was used. The last weeks some integration tests
were done and this problem was found. It turned out that
the released register documentation is wrong.

The fix is very simple: shift all mask by one.

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
 drivers/leds/leds-ot200.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
index c464682..676e729 100644
--- a/drivers/leds/leds-ot200.c
+++ b/drivers/leds/leds-ot200.c
@@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
 	{
 		.name = "led_1",
 		.port = 0x49,
-		.mask = BIT(7),
+		.mask = BIT(6),
 	},
 	{
 		.name = "led_2",
 		.port = 0x49,
-		.mask = BIT(6),
+		.mask = BIT(5),
 	},
 	{
 		.name = "led_3",
 		.port = 0x49,
-		.mask = BIT(5),
+		.mask = BIT(4),
 	},
 	{
 		.name = "led_4",
 		.port = 0x49,
-		.mask = BIT(4),
+		.mask = BIT(3),
 	},
 	{
 		.name = "led_5",
 		.port = 0x49,
-		.mask = BIT(3),
+		.mask = BIT(2),
 	},
 	{
 		.name = "led_6",
 		.port = 0x49,
-		.mask = BIT(2),
+		.mask = BIT(1),
 	},
 	{
 		.name = "led_7",
 		.port = 0x49,
-		.mask = BIT(1),
+		.mask = BIT(0),
 	}
 };
 
-- 
1.7.12.2.421.g261b511

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Greg KH]

On Mon, Oct 01, 2012 at 02:50:40PM +0200, Christian Gmeiner wrote:
> During the development of this driver an in-house register
> documentation was used. The last weeks some integration tests
> were done and this problem was found. It turned out that
> the released register documentation is wrong.
> 
> The fix is very simple: shift all mask by one.
> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  drivers/leds/leds-ot200.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

2012/10/1 Greg KH <greg@kroah.com>:
> On Mon, Oct 01, 2012 at 02:50:40PM +0200, Christian Gmeiner wrote:
>> During the development of this driver an in-house register
>> documentation was used. The last weeks some integration tests
>> were done and this problem was found. It turned out that
>> the released register documentation is wrong.
>>
>> The fix is very simple: shift all mask by one.
>>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> ---
>>  drivers/leds/leds-ot200.c | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>

Thanks... I will inform stable team again if this patch gets into
mainline - hopefully soon.
--
Christian Gmeiner, MSc

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

2012/10/12 Christian Gmeiner <christian.gmeiner@gmail.com>:
> 2012/10/1 Greg KH <greg@kroah.com>:
>> On Mon, Oct 01, 2012 at 02:50:40PM +0200, Christian Gmeiner wrote:
>>> During the development of this driver an in-house register
>>> documentation was used. The last weeks some integration tests
>>> were done and this problem was found. It turned out that
>>> the released register documentation is wrong.
>>>
>>> The fix is very simple: shift all mask by one.
>>>
>>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>>> ---
>>>  drivers/leds/leds-ot200.c | 14 +++++++-------
>>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> <formletter>
>>
>> This is not the correct way to submit patches for inclusion in the
>> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
>> for how to do this properly.
>>
>> </formletter>
>
> Thanks... I will inform stable team again if this patch gets into
> mainline - hopefully soon.

Is something missing to get this patch mainline?

thanks
--
Christian Gmeiner, MSc

[PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

During the development of this driver an in-house register
documentation was used. The last weeks some integration tests
were done and this problem was found. It turned out that
the released register documentation is wrong.

The fix is very simple: shift all masks by one.

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
 drivers/leds/leds-ot200.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
index c464682..676e729 100644
--- a/drivers/leds/leds-ot200.c
+++ b/drivers/leds/leds-ot200.c
@@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
 	{
 		.name = "led_1",
 		.port = 0x49,
-		.mask = BIT(7),
+		.mask = BIT(6),
 	},
 	{
 		.name = "led_2",
 		.port = 0x49,
-		.mask = BIT(6),
+		.mask = BIT(5),
 	},
 	{
 		.name = "led_3",
 		.port = 0x49,
-		.mask = BIT(5),
+		.mask = BIT(4),
 	},
 	{
 		.name = "led_4",
 		.port = 0x49,
-		.mask = BIT(4),
+		.mask = BIT(3),
 	},
 	{
 		.name = "led_5",
 		.port = 0x49,
-		.mask = BIT(3),
+		.mask = BIT(2),
 	},
 	{
 		.name = "led_6",
 		.port = 0x49,
-		.mask = BIT(2),
+		.mask = BIT(1),
 	},
 	{
 		.name = "led_7",
 		.port = 0x49,
-		.mask = BIT(1),
+		.mask = BIT(0),
 	}
 };
 
-- 
1.7.10.4

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

> During the development of this driver an in-house register
> documentation was used. The last weeks some integration tests
> were done and this problem was found. It turned out that
> the released register documentation is wrong.
>
> The fix is very simple: shift all masks by one.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  drivers/leds/leds-ot200.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
> index c464682..676e729 100644
> --- a/drivers/leds/leds-ot200.c
> +++ b/drivers/leds/leds-ot200.c
> @@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
>         {
>                 .name = "led_1",
>                 .port = 0x49,
> -               .mask = BIT(7),
> +               .mask = BIT(6),
>         },
>         {
>                 .name = "led_2",
>                 .port = 0x49,
> -               .mask = BIT(6),
> +               .mask = BIT(5),
>         },
>         {
>                 .name = "led_3",
>                 .port = 0x49,
> -               .mask = BIT(5),
> +               .mask = BIT(4),
>         },
>         {
>                 .name = "led_4",
>                 .port = 0x49,
> -               .mask = BIT(4),
> +               .mask = BIT(3),
>         },
>         {
>                 .name = "led_5",
>                 .port = 0x49,
> -               .mask = BIT(3),
> +               .mask = BIT(2),
>         },
>         {
>                 .name = "led_6",
>                 .port = 0x49,
> -               .mask = BIT(2),
> +               .mask = BIT(1),
>         },
>         {
>                 .name = "led_7",
>                 .port = 0x49,
> -               .mask = BIT(1),
> +               .mask = BIT(0),
>         }
>  };
>
> --
> 1.7.10.4
>

Is something missing to get this patch merged?
--
Christian Gmeiner, MSc

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

2012/12/13 Christian Gmeiner <christian.gmeiner@gmail.com>:
>> During the development of this driver an in-house register
>> documentation was used. The last weeks some integration tests
>> were done and this problem was found. It turned out that
>> the released register documentation is wrong.
>>
>> The fix is very simple: shift all masks by one.
>>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> ---
>>  drivers/leds/leds-ot200.c |   14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
>> index c464682..676e729 100644
>> --- a/drivers/leds/leds-ot200.c
>> +++ b/drivers/leds/leds-ot200.c
>> @@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
>>         {
>>                 .name = "led_1",
>>                 .port = 0x49,
>> -               .mask = BIT(7),
>> +               .mask = BIT(6),
>>         },
>>         {
>>                 .name = "led_2",
>>                 .port = 0x49,
>> -               .mask = BIT(6),
>> +               .mask = BIT(5),
>>         },
>>         {
>>                 .name = "led_3",
>>                 .port = 0x49,
>> -               .mask = BIT(5),
>> +               .mask = BIT(4),
>>         },
>>         {
>>                 .name = "led_4",
>>                 .port = 0x49,
>> -               .mask = BIT(4),
>> +               .mask = BIT(3),
>>         },
>>         {
>>                 .name = "led_5",
>>                 .port = 0x49,
>> -               .mask = BIT(3),
>> +               .mask = BIT(2),
>>         },
>>         {
>>                 .name = "led_6",
>>                 .port = 0x49,
>> -               .mask = BIT(2),
>> +               .mask = BIT(1),
>>         },
>>         {
>>                 .name = "led_7",
>>                 .port = 0x49,
>> -               .mask = BIT(1),
>> +               .mask = BIT(0),
>>         }
>>  };
>>
>> --
>> 1.7.10.4
>>
>
> Is something missing to get this patch merged?
> --
> Christian Gmeiner, MSc


ping
--
Christian Gmeiner, MSc

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

ping
--
Christian Gmeiner, MSc


2012/12/17 Christian Gmeiner <christian.gmeiner@gmail.com>:
> 2012/12/13 Christian Gmeiner <christian.gmeiner@gmail.com>:
>>> During the development of this driver an in-house register
>>> documentation was used. The last weeks some integration tests
>>> were done and this problem was found. It turned out that
>>> the released register documentation is wrong.
>>>
>>> The fix is very simple: shift all masks by one.
>>>
>>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>>> ---
>>>  drivers/leds/leds-ot200.c |   14 +++++++-------
>>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
>>> index c464682..676e729 100644
>>> --- a/drivers/leds/leds-ot200.c
>>> +++ b/drivers/leds/leds-ot200.c
>>> @@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
>>>         {
>>>                 .name = "led_1",
>>>                 .port = 0x49,
>>> -               .mask = BIT(7),
>>> +               .mask = BIT(6),
>>>         },
>>>         {
>>>                 .name = "led_2",
>>>                 .port = 0x49,
>>> -               .mask = BIT(6),
>>> +               .mask = BIT(5),
>>>         },
>>>         {
>>>                 .name = "led_3",
>>>                 .port = 0x49,
>>> -               .mask = BIT(5),
>>> +               .mask = BIT(4),
>>>         },
>>>         {
>>>                 .name = "led_4",
>>>                 .port = 0x49,
>>> -               .mask = BIT(4),
>>> +               .mask = BIT(3),
>>>         },
>>>         {
>>>                 .name = "led_5",
>>>                 .port = 0x49,
>>> -               .mask = BIT(3),
>>> +               .mask = BIT(2),
>>>         },
>>>         {
>>>                 .name = "led_6",
>>>                 .port = 0x49,
>>> -               .mask = BIT(2),
>>> +               .mask = BIT(1),
>>>         },
>>>         {
>>>                 .name = "led_7",
>>>                 .port = 0x49,
>>> -               .mask = BIT(1),
>>> +               .mask = BIT(0),
>>>         }
>>>  };
>>>
>>> --
>>> 1.7.10.4
>>>
>>
>> Is something missing to get this patch merged?
>> --
>> Christian Gmeiner, MSc
>
>
> ping
> --
> Christian Gmeiner, MSc

[PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

During the development of this driver an in-house register
documentation was used. The last weeks some integration tests
were done and this problem was found. It turned out that
the released register documentation is wrong.

The fix is very simple: shift all masks by one.

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
 drivers/leds/leds-ot200.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
index ee14662..98cae52 100644
--- a/drivers/leds/leds-ot200.c
+++ b/drivers/leds/leds-ot200.c
@@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
 	{
 		.name = "led_1",
 		.port = 0x49,
-		.mask = BIT(7),
+		.mask = BIT(6),
 	},
 	{
 		.name = "led_2",
 		.port = 0x49,
-		.mask = BIT(6),
+		.mask = BIT(5),
 	},
 	{
 		.name = "led_3",
 		.port = 0x49,
-		.mask = BIT(5),
+		.mask = BIT(4),
 	},
 	{
 		.name = "led_4",
 		.port = 0x49,
-		.mask = BIT(4),
+		.mask = BIT(3),
 	},
 	{
 		.name = "led_5",
 		.port = 0x49,
-		.mask = BIT(3),
+		.mask = BIT(2),
 	},
 	{
 		.name = "led_6",
 		.port = 0x49,
-		.mask = BIT(2),
+		.mask = BIT(1),
 	},
 	{
 		.name = "led_7",
 		.port = 0x49,
-		.mask = BIT(1),
+		.mask = BIT(0),
 	}
 };
 
-- 
1.7.12.2.421.g261b511

AW: [PATCH] leds-ot200: Fix error caused by shifted mask

[GMEINER.Christian]

> -----Ursprüngliche Nachricht-----
> Von: Christian Gmeiner [mailto:christian.gmeiner@gmail.com]
> Gesendet: Mittwoch, 23. Januar 2013 09:11
> An: linux-next@vger.kernel.org; akpm@linux-foundation.org;
> rpurdie@rpsys.net; linux-kernel@vger.kernel.org; GMEINER.Christian
> Cc: Christian Gmeiner
> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
> 
> During the development of this driver an in-house register documentation
> was used. The last weeks some integration tests were done and this problem
> was found. It turned out that the released register documentation is wrong.
> 
> The fix is very simple: shift all masks by one.
> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>


Acked-by: Christian Gmeiner <c.gmeiner@bachmann.info>
Tested-by: Christian Gmeiner <c.gmeiner@bachmann.info>

> ---
>  drivers/leds/leds-ot200.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c index
> ee14662..98cae52 100644
> --- a/drivers/leds/leds-ot200.c
> +++ b/drivers/leds/leds-ot200.c
> @@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
>  	{
>  		.name = "led_1",
>  		.port = 0x49,
> -		.mask = BIT(7),
> +		.mask = BIT(6),
>  	},
>  	{
>  		.name = "led_2",
>  		.port = 0x49,
> -		.mask = BIT(6),
> +		.mask = BIT(5),
>  	},
>  	{
>  		.name = "led_3",
>  		.port = 0x49,
> -		.mask = BIT(5),
> +		.mask = BIT(4),
>  	},
>  	{
>  		.name = "led_4",
>  		.port = 0x49,
> -		.mask = BIT(4),
> +		.mask = BIT(3),
>  	},
>  	{
>  		.name = "led_5",
>  		.port = 0x49,
> -		.mask = BIT(3),
> +		.mask = BIT(2),
>  	},
>  	{
>  		.name = "led_6",
>  		.port = 0x49,
> -		.mask = BIT(2),
> +		.mask = BIT(1),
>  	},
>  	{
>  		.name = "led_7",
>  		.port = 0x49,
> -		.mask = BIT(1),
> +		.mask = BIT(0),
>  	}
>  };
> 
> --
> 1.7.12.2.421.g261b511

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

ping
--
Christian Gmeiner, MSc


2013/1/23 GMEINER.Christian <C.GMEINER@bachmann.info>:
>> -----Ursprüngliche Nachricht-----
>> Von: Christian Gmeiner [mailto:christian.gmeiner@gmail.com]
>> Gesendet: Mittwoch, 23. Januar 2013 09:11
>> An: linux-next@vger.kernel.org; akpm@linux-foundation.org;
>> rpurdie@rpsys.net; linux-kernel@vger.kernel.org; GMEINER.Christian
>> Cc: Christian Gmeiner
>> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
>>
>> During the development of this driver an in-house register documentation
>> was used. The last weeks some integration tests were done and this problem
>> was found. It turned out that the released register documentation is wrong.
>>
>> The fix is very simple: shift all masks by one.
>>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>
>
> Acked-by: Christian Gmeiner <c.gmeiner@bachmann.info>
> Tested-by: Christian Gmeiner <c.gmeiner@bachmann.info>
>
>> ---
>>  drivers/leds/leds-ot200.c | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c index
>> ee14662..98cae52 100644
>> --- a/drivers/leds/leds-ot200.c
>> +++ b/drivers/leds/leds-ot200.c
>> @@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
>>       {
>>               .name = "led_1",
>>               .port = 0x49,
>> -             .mask = BIT(7),
>> +             .mask = BIT(6),
>>       },
>>       {
>>               .name = "led_2",
>>               .port = 0x49,
>> -             .mask = BIT(6),
>> +             .mask = BIT(5),
>>       },
>>       {
>>               .name = "led_3",
>>               .port = 0x49,
>> -             .mask = BIT(5),
>> +             .mask = BIT(4),
>>       },
>>       {
>>               .name = "led_4",
>>               .port = 0x49,
>> -             .mask = BIT(4),
>> +             .mask = BIT(3),
>>       },
>>       {
>>               .name = "led_5",
>>               .port = 0x49,
>> -             .mask = BIT(3),
>> +             .mask = BIT(2),
>>       },
>>       {
>>               .name = "led_6",
>>               .port = 0x49,
>> -             .mask = BIT(2),
>> +             .mask = BIT(1),
>>       },
>>       {
>>               .name = "led_7",
>>               .port = 0x49,
>> -             .mask = BIT(1),
>> +             .mask = BIT(0),
>>       }
>>  };
>>
>> --
>> 1.7.12.2.421.g261b511
>

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Andrew Morton]

On Fri, 1 Feb 2013 16:08:15 +0100
Christian Gmeiner <christian.gmeiner@gmail.com> wrote:

> ping

Bryan is handling LEDs patches (see ./MAINTAINERS).  Without a cc he
presumably missed this in the lkml flood.

> 2013/1/23 GMEINER.Christian <C.GMEINER@bachmann.info>:
> >> -----Urspr__ngliche Nachricht-----
> >> Von: Christian Gmeiner [mailto:christian.gmeiner@gmail.com]
> >> Gesendet: Mittwoch, 23. Januar 2013 09:11
> >> An: linux-next@vger.kernel.org; akpm@linux-foundation.org;
> >> rpurdie@rpsys.net; linux-kernel@vger.kernel.org; GMEINER.Christian
> >> Cc: Christian Gmeiner
> >> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
> >>
> >> During the development of this driver an in-house register documentation
> >> was used. The last weeks some integration tests were done and this problem
> >> was found. It turned out that the released register documentation is wrong.
> >>
> >> The fix is very simple: shift all masks by one.
> >>

The changelog failed to describe the effects of the bug it fixes.  This
is a grave (and all too common) omission; it makes it difficult for
others to determine whether the patch should be backported into earlier
kernels.

So, please tell us.  And feel free to explain whether you believe the
fix should be backported.

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Christian Gmeiner]

2013/2/1 Andrew Morton <akpm@linux-foundation.org>:
> On Fri, 1 Feb 2013 16:08:15 +0100
> Christian Gmeiner <christian.gmeiner@gmail.com> wrote:
>
>> ping
>
> Bryan is handling LEDs patches (see ./MAINTAINERS).  Without a cc he
> presumably missed this in the lkml flood.

You are right...

~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c
Bryan Wu <cooloney@gmail.com> (maintainer:LED SUBSYSTEM)
Richard Purdie <rpurdie@rpsys.net> (maintainer:LED SUBSYSTEM)
linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

Next time I will add Bryan to CC

>
>> 2013/1/23 GMEINER.Christian <C.GMEINER@bachmann.info>:
>> >> -----Urspr__ngliche Nachricht-----
>> >> Von: Christian Gmeiner [mailto:christian.gmeiner@gmail.com]
>> >> Gesendet: Mittwoch, 23. Januar 2013 09:11
>> >> An: linux-next@vger.kernel.org; akpm@linux-foundation.org;
>> >> rpurdie@rpsys.net; linux-kernel@vger.kernel.org; GMEINER.Christian
>> >> Cc: Christian Gmeiner
>> >> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
>> >>
>> >> During the development of this driver an in-house register documentation
>> >> was used. The last weeks some integration tests were done and this problem
>> >> was found. It turned out that the released register documentation is wrong.
>> >>
>> >> The fix is very simple: shift all masks by one.
>> >>
>
> The changelog failed to describe the effects of the bug it fixes.  This
> is a grave (and all too common) omission; it makes it difficult for
> others to determine whether the patch should be backported into earlier
> kernels.
>
> So, please tell us.  And feel free to explain whether you believe the
> fix should be backported.

Our customers can control LEDs from userspace via Java, C++ or what every. They
have running/working applications where they want to control led_3 but
led_2 get's
used. I got a bug report in our in-house bug tracker so it would be
great if this patch can make it into 3.7.x series.

thanks
--
Christian Gmeiner, MSc

Re: [PATCH] leds-ot200: Fix error caused by shifted mask

[Bryan Wu]

On Mon, Feb 4, 2013 at 6:46 AM, Christian Gmeiner
<christian.gmeiner@gmail.com> wrote:
> 2013/2/1 Andrew Morton <akpm@linux-foundation.org>:
>> On Fri, 1 Feb 2013 16:08:15 +0100
>> Christian Gmeiner <christian.gmeiner@gmail.com> wrote:
>>
>>> ping
>>
>> Bryan is handling LEDs patches (see ./MAINTAINERS).  Without a cc he
>> presumably missed this in the lkml flood.
>
> You are right...
>
> ~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c
> Bryan Wu <cooloney@gmail.com> (maintainer:LED SUBSYSTEM)
> Richard Purdie <rpurdie@rpsys.net> (maintainer:LED SUBSYSTEM)
> linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
>
> Next time I will add Bryan to CC
>
>>
>>> 2013/1/23 GMEINER.Christian <C.GMEINER@bachmann.info>:
>>> >> -----Urspr__ngliche Nachricht-----
>>> >> Von: Christian Gmeiner [mailto:christian.gmeiner@gmail.com]
>>> >> Gesendet: Mittwoch, 23. Januar 2013 09:11
>>> >> An: linux-next@vger.kernel.org; akpm@linux-foundation.org;
>>> >> rpurdie@rpsys.net; linux-kernel@vger.kernel.org; GMEINER.Christian
>>> >> Cc: Christian Gmeiner
>>> >> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
>>> >>
>>> >> During the development of this driver an in-house register documentation
>>> >> was used. The last weeks some integration tests were done and this problem
>>> >> was found. It turned out that the released register documentation is wrong.
>>> >>
>>> >> The fix is very simple: shift all masks by one.
>>> >>
>>
>> The changelog failed to describe the effects of the bug it fixes.  This
>> is a grave (and all too common) omission; it makes it difficult for
>> others to determine whether the patch should be backported into earlier
>> kernels.
>>
>> So, please tell us.  And feel free to explain whether you believe the
>> fix should be backported.
>
> Our customers can control LEDs from userspace via Java, C++ or what every. They
> have running/working applications where they want to control led_3 but
> led_2 get's
> used. I got a bug report in our in-house bug tracker so it would be
> great if this patch can make it into 3.7.x series.
>

OK, could you please update the commit message of this patch and
resubmit it? It's better to submit to -stable tree as well.

Thanks,
-Bryan