From: Matt Porter <mporter@ti.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Chris Ball <cjb@laptop.org>,
Russell King <linux@arm.linux.org.uk>,
Benoit Cousson <b-cousson@ti.com>, Arnd Bergmann <arnd@arndb.de>,
Linux Documentation List <linux-doc@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Landley <rob@landley.net>, Dan Williams <djbw@fb.com>,
Linux SPI Devel List <spi-devel-general@lists.sourceforge.net>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 10/13] spi: omap2-mcspi: dma_request_slave_channel() support for DT platforms
Date: Mon, 1 Oct 2012 12:37:24 -0400 [thread overview]
Message-ID: <20121001163723.GN5641@beef> (raw)
In-Reply-To: <1348738594.1648.9.camel@vkoul-udesk3>
On Thu, Sep 27, 2012 at 03:06:34PM +0530, Vinod Koul wrote:
> On Fri, 2012-09-21 at 14:37 -0400, Matt Porter wrote:
> > On Fri, Sep 21, 2012 at 08:42:47AM -0700, Tony Lindgren wrote:
> > >
> > > Can't we come up with a version of dma_request_slave_channel that works
> > > both ways for now:
> > >
> > > mcspi_dma->dma_rx =
> > > dma_request_slave_channel_compat(mask, omap_dma_filter_fn, &sig,
> > > &master->dev, mcspi_dma->dma_rx_ch_name);
> > > ...
> > >
> > > Then it's just question of patching away two lines later on rather than
> > > having to add all this if else to all the drivers first, then patching
> > > it away again.
> >
> > I think that something like that is workable with the implementation
> > simply checking for of_node to do the right thing.
> Yes, I think it would be better to have common API but underneath two
> implementations in transitional phase.
Ok, I'll implement something for discussion in the v2 series.
-Matt
WARNING: multiple messages have this Message-ID (diff)
From: mporter@ti.com (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 10/13] spi: omap2-mcspi: dma_request_slave_channel() support for DT platforms
Date: Mon, 1 Oct 2012 12:37:24 -0400 [thread overview]
Message-ID: <20121001163723.GN5641@beef> (raw)
In-Reply-To: <1348738594.1648.9.camel@vkoul-udesk3>
On Thu, Sep 27, 2012 at 03:06:34PM +0530, Vinod Koul wrote:
> On Fri, 2012-09-21 at 14:37 -0400, Matt Porter wrote:
> > On Fri, Sep 21, 2012 at 08:42:47AM -0700, Tony Lindgren wrote:
> > >
> > > Can't we come up with a version of dma_request_slave_channel that works
> > > both ways for now:
> > >
> > > mcspi_dma->dma_rx =
> > > dma_request_slave_channel_compat(mask, omap_dma_filter_fn, &sig,
> > > &master->dev, mcspi_dma->dma_rx_ch_name);
> > > ...
> > >
> > > Then it's just question of patching away two lines later on rather than
> > > having to add all this if else to all the drivers first, then patching
> > > it away again.
> >
> > I think that something like that is workable with the implementation
> > simply checking for of_node to do the right thing.
> Yes, I think it would be better to have common API but underneath two
> implementations in transitional phase.
Ok, I'll implement something for discussion in the v2 series.
-Matt
next prev parent reply other threads:[~2012-10-01 16:37 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 14:43 [RFC PATCH 00/13] DMA Engine support for AM33xx Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
[not found] ` <1348152226-13588-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-20 14:43 ` [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
[not found] ` <1348152226-13588-2-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-21 7:10 ` Hebbar, Gururaja
2012-09-21 7:10 ` Hebbar, Gururaja
2012-09-21 7:10 ` Hebbar, Gururaja
2012-09-21 18:24 ` Matt Porter
2012-09-21 18:24 ` Matt Porter
2012-09-21 18:24 ` Matt Porter
2012-09-21 18:24 ` Matt Porter
2012-09-21 9:29 ` Russell King - ARM Linux
2012-09-21 9:29 ` Russell King - ARM Linux
[not found] ` <20120921092923.GA31374-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-09-21 9:33 ` Hebbar, Gururaja
2012-09-21 9:33 ` Hebbar, Gururaja
2012-09-21 9:33 ` Hebbar, Gururaja
2012-09-21 9:33 ` Hebbar, Gururaja
2012-09-21 9:42 ` Russell King - ARM Linux
2012-09-21 9:42 ` Russell King - ARM Linux
[not found] ` <20120921094205.GC31374-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-09-21 18:34 ` Matt Porter
2012-09-21 18:34 ` Matt Porter
2012-09-21 18:34 ` Matt Porter
2012-09-21 18:50 ` Russell King - ARM Linux
2012-09-21 18:50 ` Russell King - ARM Linux
2012-09-24 2:44 ` Hebbar, Gururaja
2012-09-24 2:44 ` Hebbar, Gururaja
2012-09-20 14:43 ` [RFC PATCH 02/13] ARM: edma: remove unused transfer controller handlers Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 03/13] ARM: edma: add DT and runtime PM support for AM335x Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
[not found] ` <1348152226-13588-4-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-21 8:53 ` Hebbar, Gururaja
2012-09-21 8:53 ` Hebbar, Gururaja
2012-09-21 8:53 ` Hebbar, Gururaja
2012-10-09 18:58 ` Matt Porter
2012-10-09 18:58 ` Matt Porter
2012-10-09 18:58 ` Matt Porter
2012-10-09 18:58 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 04/13] dmaengine: edma: enable build " Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 05/13] dma: Add TI EDMA device tree binding Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
[not found] ` <1348152226-13588-6-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-21 8:45 ` Hebbar, Gururaja
2012-09-21 8:45 ` Hebbar, Gururaja
2012-09-21 8:45 ` Hebbar, Gururaja
2012-09-21 18:23 ` Matt Porter
2012-09-21 18:23 ` Matt Porter
2012-09-21 18:23 ` Matt Porter
2012-09-21 18:23 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 06/13] ARM: omap: add hsmmc am33xx specific init Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 07/13] mmc: omap_hsmmc: dma_request_slave_channel() support for DT platforms Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 22:16 ` Tony Lindgren
2012-09-20 22:16 ` Tony Lindgren
2012-09-20 14:43 ` [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-21 17:15 ` S, Venkatraman
2012-09-21 17:15 ` S, Venkatraman
2012-09-21 17:15 ` S, Venkatraman
2012-09-21 17:15 ` S, Venkatraman
[not found] ` <CANfBPZ81anOy8fWgKM1PgCtB4V2pEp2x1Qi4x1uPsq7QieMN5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-21 17:17 ` S, Venkatraman
2012-09-21 17:17 ` S, Venkatraman
2012-09-21 17:17 ` S, Venkatraman
2012-09-21 17:18 ` Felipe Balbi
2012-09-21 17:18 ` Felipe Balbi
2012-09-21 17:18 ` Felipe Balbi
2012-09-21 17:18 ` Felipe Balbi
[not found] ` <20120921171840.GB10409-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-09-21 17:33 ` S, Venkatraman
2012-09-21 17:33 ` S, Venkatraman
2012-09-21 17:33 ` S, Venkatraman
2012-09-21 18:54 ` Matt Porter
2012-09-21 18:54 ` Matt Porter
2012-09-21 18:54 ` Matt Porter
2012-09-21 18:54 ` Matt Porter
2012-09-21 18:42 ` Matt Porter
2012-09-21 18:42 ` Matt Porter
2012-09-21 18:42 ` Matt Porter
2012-09-21 18:42 ` Matt Porter
2012-09-21 18:47 ` Russell King - ARM Linux
2012-09-21 18:47 ` Russell King - ARM Linux
[not found] ` <20120921184721.GD31374-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-09-21 19:03 ` Matt Porter
2012-09-21 19:03 ` Matt Porter
2012-09-21 19:03 ` Matt Porter
2012-09-27 9:41 ` Vinod Koul
2012-09-27 9:41 ` Vinod Koul
2012-10-01 16:39 ` Matt Porter
2012-10-01 16:39 ` Matt Porter
2012-10-01 16:39 ` Matt Porter
2012-10-01 16:39 ` Matt Porter
2012-10-02 12:03 ` Vinod Koul
2012-10-02 12:03 ` Vinod Koul
2012-10-02 12:03 ` Vinod Koul
2012-09-20 14:43 ` [RFC PATCH 09/13] mmc: omap_hsmmc: add generic DMA request support to the DT binding Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 10/13] spi: omap2-mcspi: dma_request_slave_channel() support for DT platforms Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 22:09 ` Tony Lindgren
2012-09-20 22:09 ` Tony Lindgren
2012-09-21 8:16 ` Arnd Bergmann
2012-09-21 8:16 ` Arnd Bergmann
2012-09-21 15:42 ` Tony Lindgren
2012-09-21 15:42 ` Tony Lindgren
[not found] ` <20120921154247.GZ28835-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-09-21 18:37 ` Matt Porter
2012-09-21 18:37 ` Matt Porter
2012-09-21 18:37 ` Matt Porter
2012-09-27 9:36 ` Vinod Koul
2012-09-27 9:36 ` Vinod Koul
2012-10-01 16:37 ` Matt Porter [this message]
2012-10-01 16:37 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 11/13] spi: omap2-mcspi: add generic DMA request support to the DT binding Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 12/13] ARM: dts: add am33xx EDMA support Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` [RFC PATCH 13/13] Documentation: add schedule for removing private EDMA API Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 14:43 ` Matt Porter
2012-09-20 15:58 ` Mark Brown
2012-09-20 15:58 ` Mark Brown
2012-09-20 16:05 ` Matt Porter
2012-09-20 16:05 ` Matt Porter
2012-09-21 8:27 ` [RFC PATCH 00/13] DMA Engine support for AM33xx Hebbar, Gururaja
2012-09-21 8:27 ` Hebbar, Gururaja
2012-09-21 8:27 ` Hebbar, Gururaja
2012-09-21 18:22 ` Matt Porter
2012-09-21 18:22 ` Matt Porter
2012-09-21 18:22 ` Matt Porter
2012-09-21 18:22 ` Matt Porter
2012-09-24 11:26 ` Hebbar, Gururaja
2012-09-24 11:26 ` Hebbar, Gururaja
2012-09-24 11:26 ` Hebbar, Gururaja
2012-09-24 11:26 ` Hebbar, Gururaja
2012-09-24 12:05 ` Matt Porter
2012-09-24 12:05 ` Matt Porter
2012-09-26 8:26 ` Hebbar, Gururaja
2012-09-26 8:26 ` Hebbar, Gururaja
2012-09-26 8:26 ` Hebbar, Gururaja
2012-09-26 8:26 ` Hebbar, Gururaja
2012-09-26 13:01 ` Matt Porter
2012-09-26 13:01 ` Matt Porter
2012-09-26 13:01 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001163723.GN5641@beef \
--to=mporter@ti.com \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=djbw@fb.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tony@atomide.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.