Re: [PATCH] drm/i915: Flush the pending flips on the CRTC before modification

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Sep 28, 2012 at 01:04:03PM +0100, Chris Wilson wrote:
> On Fri, 28 Sep 2012 08:37:20 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Thu, Sep 27, 2012 at 09:25:58PM +0100, Chris Wilson wrote:
> > > This was meant to be the purpose of the
> > > intel_crtc_wait_for_pending_flips() function which is called whilst
> > > preparing the CRTC for a modeset or before disabling. However, as Ville
> > > Syrjala pointed out, we set the pending flip notification on the old
> > > framebuffer that is no longer attached to the CRTC by the time we come
> > > to flush the pending operations. Instead, we can simply wait on the
> > > pending unpin work to be finished on this CRTC, knowning that the
> > > hardware has therefore finished modifying the registers, before proceeding
> > > with our direct access.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Can I haz testcase plz?
> 
> Fixes i-g-t/flip_test

Picked up for -fixes (with the i-g-t note and cc: stable added), thanks
for the patch. I've tried to make the test work on pch platforms, too. But
those seem to simply complete the flip immediately when the pipe is off.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch