From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Flush the pending flips on the CRTC before modification
Date: Fri, 28 Sep 2012 13:04:03 +0100 [thread overview]
Message-ID: <275ffc$6pgut7@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20120928063720.GI2098@bremse>
On Fri, 28 Sep 2012 08:37:20 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Sep 27, 2012 at 09:25:58PM +0100, Chris Wilson wrote:
> > This was meant to be the purpose of the
> > intel_crtc_wait_for_pending_flips() function which is called whilst
> > preparing the CRTC for a modeset or before disabling. However, as Ville
> > Syrjala pointed out, we set the pending flip notification on the old
> > framebuffer that is no longer attached to the CRTC by the time we come
> > to flush the pending operations. Instead, we can simply wait on the
> > pending unpin work to be finished on this CRTC, knowning that the
> > hardware has therefore finished modifying the registers, before proceeding
> > with our direct access.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Can I haz testcase plz?
Fixes i-g-t/flip_test
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-09-28 12:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 20:25 [PATCH] drm/i915: Flush the pending flips on the CRTC before modification Chris Wilson
2012-09-28 6:37 ` Daniel Vetter
2012-09-28 8:10 ` Chris Wilson
2012-09-28 12:04 ` Chris Wilson [this message]
2012-10-02 9:52 ` Daniel Vetter
2012-09-28 10:05 ` Ville Syrjälä
2012-09-28 10:22 ` Chris Wilson
2012-09-28 10:31 ` Daniel Vetter
2012-09-28 10:45 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='275ffc$6pgut7@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.