From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] ARM: ux500: Stop calling the UIB init function when using Device Tree
Date: Tue, 2 Oct 2012 13:15:33 +0100 [thread overview]
Message-ID: <20121002121533.GA26783@gmail.com> (raw)
In-Reply-To: <CACRpkdaM1SxcrAn086W+b-oC+k6w=SEhxq0CGqrA_4iXmgfWYA@mail.gmail.com>
On Tue, 02 Oct 2012, Linus Walleij wrote:
> On Tue, Oct 2, 2012 at 10:13 AM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > As there will be a Device Tree created for the UIBs, there is no
> > need to call the UIB initiation functions. Each device will be
> > detailed and registered from the Device Tree instead.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Acked-by, but...
>
> > - .init_late = ux500_init_late,
> > + .init_late = NULL,
>
> Why even define it?
More to show that we're _intentionally_ not using it.
I'm happy to remove if it offends you? :)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
linus.walleij@stericsson.com
Subject: Re: [PATCH 08/10] ARM: ux500: Stop calling the UIB init function when using Device Tree
Date: Tue, 2 Oct 2012 13:15:33 +0100 [thread overview]
Message-ID: <20121002121533.GA26783@gmail.com> (raw)
In-Reply-To: <CACRpkdaM1SxcrAn086W+b-oC+k6w=SEhxq0CGqrA_4iXmgfWYA@mail.gmail.com>
On Tue, 02 Oct 2012, Linus Walleij wrote:
> On Tue, Oct 2, 2012 at 10:13 AM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > As there will be a Device Tree created for the UIBs, there is no
> > need to call the UIB initiation functions. Each device will be
> > detailed and registered from the Device Tree instead.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Acked-by, but...
>
> > - .init_late = ux500_init_late,
> > + .init_late = NULL,
>
> Why even define it?
More to show that we're _intentionally_ not using it.
I'm happy to remove if it offends you? :)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-10-02 12:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 8:13 [PATCH 00/10] Platform data clean-up and UIB device enablement Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 8:13 ` [PATCH 01/10] ARM: ux500: Move all Device Tree booting into cpu-db8500 Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 8:55 ` Linus Walleij
2012-10-02 8:55 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 02/10] ARM: ux500: Strip out duplicate touch screen platform information Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 9:07 ` Linus Walleij
2012-10-02 9:07 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 03/10] Input: bu21013_ts - Request a regulator that actually exists Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 9:16 ` Linus Walleij
2012-10-02 9:16 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 04/10] Input: bu21013_ts - Move GPIO init and exit functions into the driver Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 9:18 ` Linus Walleij
2012-10-02 9:18 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 05/10] Input: bu21013_ts - Add support for Device Tree booting Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 9:20 ` Linus Walleij
2012-10-02 9:20 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 06/10] Documentation: Detail permitted DT properties for the BU21013 Touch Screen Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 9:21 ` Linus Walleij
2012-10-02 9:21 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 07/10] ARM: ux500: Create a new Device Tree include file for boards supporting STUIBs Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 10:57 ` Linus Walleij
2012-10-02 10:57 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 08/10] ARM: ux500: Stop calling the UIB init function when using Device Tree Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 10:57 ` Linus Walleij
2012-10-02 10:57 ` Linus Walleij
2012-10-02 12:15 ` Lee Jones [this message]
2012-10-02 12:15 ` Lee Jones
2012-10-02 12:58 ` Linus Walleij
2012-10-02 12:58 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 09/10] ARM: ux500: Add all bu21013 touch screen components to supported Device Trees Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 10:58 ` Linus Walleij
2012-10-02 10:58 ` Linus Walleij
2012-10-02 8:13 ` [PATCH 10/10] ARM: ux500: Stop informing the regulator subsystem that we have full constraints Lee Jones
2012-10-02 8:13 ` Lee Jones
2012-10-02 11:00 ` Linus Walleij
2012-10-02 11:00 ` Linus Walleij
2012-10-02 11:44 ` [PATCH 00/10] Platform data clean-up and UIB device enablement Arnd Bergmann
2012-10-02 11:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002121533.GA26783@gmail.com \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.