From: Alan Cox <alan@linux.intel.com>
To: Vineet.Gupta1@synopsys.com
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial/arc-uart: Add new driver
Date: Tue, 2 Oct 2012 12:47:07 +0100 [thread overview]
Message-ID: <20121002124707.32b70292@bob.linux.org.uk> (raw)
In-Reply-To: <1349154216-7906-1-git-send-email-vgupta@synopsys.com>
> +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS)
> */ +int __attribute__((weak)) running_on_iss;
Why not pass a quirks field in your platform data instead - much
cleaner than a global.
> +static void arc_serial_set_ldisc(struct uart_port *port, int ld)
> +{
> +}
If you don't need it just remove this one
> + new->c_cflag &= ~(CMSPAR|CRTSCTS);
also force the CSIZE bits to CS8 if you only do 8N1.
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@linux.intel.com>
To: <Vineet.Gupta1@synopsys.com>
Cc: <gregkh@linuxfoundation.org>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] serial/arc-uart: Add new driver
Date: Tue, 2 Oct 2012 12:47:07 +0100 [thread overview]
Message-ID: <20121002124707.32b70292@bob.linux.org.uk> (raw)
In-Reply-To: <1349154216-7906-1-git-send-email-vgupta@synopsys.com>
> +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS)
> */ +int __attribute__((weak)) running_on_iss;
Why not pass a quirks field in your platform data instead - much
cleaner than a global.
> +static void arc_serial_set_ldisc(struct uart_port *port, int ld)
> +{
> +}
If you don't need it just remove this one
> + new->c_cflag &= ~(CMSPAR|CRTSCTS);
also force the CSIZE bits to CS8 if you only do 8N1.
Alan
next prev parent reply other threads:[~2012-10-02 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 5:03 [PATCH v2] serial/arc-uart: Add new driver Vineet.Gupta1
2012-10-02 5:03 ` Vineet.Gupta1
2012-10-02 11:47 ` Alan Cox [this message]
2012-10-02 11:47 ` Alan Cox
2012-10-03 7:10 ` Vineet Gupta
2012-10-03 7:10 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002124707.32b70292@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.