From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
aarcange@redhat.com, hannes@cmpxchg.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: Re: [PATCH 0/8] THP support for Sparc64
Date: Tue, 2 Oct 2012 15:55:44 -0700 [thread overview]
Message-ID: <20121002155544.2c67b1e8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121002.182601.845433592794197720.davem@davemloft.net>
On Tue, 02 Oct 2012 18:26:01 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> Here is a set of patches that add THP support for sparc64.
>
> A few of them are relatively minor portability issues I ran into.
> Like the MIPS guys I hit the update_mmu_cache() typing issue so I have
> a patch for that here.
>
> It is very likely that I need the ACCESSED bit handling fix the
> ARM folks have been posting recently as well.
>
> On the sparc64 side the biggest issue was moving to only supporting
> 4MB pages and then realigning the page tables so that the PMDs map 4MB
> (instead of 8MB as they do now).
>
> The rest was just trial and error, running tests, and fixing bugs.
>
> A familiar test case that makes 5 million random accesses to a 1GB
> memory area goes from 20 seconds down to 0.43 seconds with THP enabled
> on my SPARC T4-2 box.
Hardly worth bothering about ;)
I had a shot at integrating all this onto the pending stuff in linux-next.
"mm: Add and use update_mmu_cache_pmd() in transparent huge page code."
needed minor massaging in huge_memory.c. But as Andrea mentioned, we
ran aground on Gerald's
http://ozlabs.org/~akpm/mmotm/broken-out/thp-remove-assumptions-on-pgtable_t-type.patch,
part of the thp-for-s390 work.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
aarcange@redhat.com, hannes@cmpxchg.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: Re: [PATCH 0/8] THP support for Sparc64
Date: Tue, 02 Oct 2012 22:55:44 +0000 [thread overview]
Message-ID: <20121002155544.2c67b1e8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121002.182601.845433592794197720.davem@davemloft.net>
On Tue, 02 Oct 2012 18:26:01 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> Here is a set of patches that add THP support for sparc64.
>
> A few of them are relatively minor portability issues I ran into.
> Like the MIPS guys I hit the update_mmu_cache() typing issue so I have
> a patch for that here.
>
> It is very likely that I need the ACCESSED bit handling fix the
> ARM folks have been posting recently as well.
>
> On the sparc64 side the biggest issue was moving to only supporting
> 4MB pages and then realigning the page tables so that the PMDs map 4MB
> (instead of 8MB as they do now).
>
> The rest was just trial and error, running tests, and fixing bugs.
>
> A familiar test case that makes 5 million random accesses to a 1GB
> memory area goes from 20 seconds down to 0.43 seconds with THP enabled
> on my SPARC T4-2 box.
Hardly worth bothering about ;)
I had a shot at integrating all this onto the pending stuff in linux-next.
"mm: Add and use update_mmu_cache_pmd() in transparent huge page code."
needed minor massaging in huge_memory.c. But as Andrea mentioned, we
ran aground on Gerald's
http://ozlabs.org/~akpm/mmotm/broken-out/thp-remove-assumptions-on-pgtable_t-type.patch,
part of the thp-for-s390 work.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
aarcange@redhat.com, hannes@cmpxchg.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: Re: [PATCH 0/8] THP support for Sparc64
Date: Tue, 2 Oct 2012 15:55:44 -0700 [thread overview]
Message-ID: <20121002155544.2c67b1e8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121002.182601.845433592794197720.davem@davemloft.net>
On Tue, 02 Oct 2012 18:26:01 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> Here is a set of patches that add THP support for sparc64.
>
> A few of them are relatively minor portability issues I ran into.
> Like the MIPS guys I hit the update_mmu_cache() typing issue so I have
> a patch for that here.
>
> It is very likely that I need the ACCESSED bit handling fix the
> ARM folks have been posting recently as well.
>
> On the sparc64 side the biggest issue was moving to only supporting
> 4MB pages and then realigning the page tables so that the PMDs map 4MB
> (instead of 8MB as they do now).
>
> The rest was just trial and error, running tests, and fixing bugs.
>
> A familiar test case that makes 5 million random accesses to a 1GB
> memory area goes from 20 seconds down to 0.43 seconds with THP enabled
> on my SPARC T4-2 box.
Hardly worth bothering about ;)
I had a shot at integrating all this onto the pending stuff in linux-next.
"mm: Add and use update_mmu_cache_pmd() in transparent huge page code."
needed minor massaging in huge_memory.c. But as Andrea mentioned, we
ran aground on Gerald's
http://ozlabs.org/~akpm/mmotm/broken-out/thp-remove-assumptions-on-pgtable_t-type.patch,
part of the thp-for-s390 work.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-02 22:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 22:26 [PATCH 0/8] THP support for Sparc64 David Miller
2012-10-02 22:26 ` David Miller
2012-10-02 22:26 ` David Miller
2012-10-02 22:55 ` Andrew Morton [this message]
2012-10-02 22:55 ` Andrew Morton
2012-10-02 22:55 ` Andrew Morton
2012-10-03 0:53 ` David Miller
2012-10-03 0:53 ` David Miller
2012-10-03 0:53 ` David Miller
2012-10-04 2:00 ` David Miller
2012-10-04 2:00 ` David Miller
2012-10-04 2:00 ` David Miller
2012-10-04 10:35 ` Andrea Arcangeli
2012-10-04 10:35 ` Andrea Arcangeli
2012-10-04 10:35 ` Andrea Arcangeli
2012-10-04 18:11 ` David Miller
2012-10-04 18:11 ` David Miller
2012-10-04 18:11 ` David Miller
2012-10-05 9:28 ` Michal Hocko
2012-10-05 9:28 ` Michal Hocko
2012-10-05 9:28 ` Michal Hocko
2012-10-05 11:57 ` Andrea Arcangeli
2012-10-05 11:57 ` Andrea Arcangeli
2012-10-05 11:57 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002155544.2c67b1e8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=davem@davemloft.net \
--cc=gerald.schaefer@de.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.