From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Andrew Victor <linux@maxim.org.za>,
Jason Cooper <jason@lakedaemon.net>,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v6 3/5] watchdog: at91sam9_wdt: add device tree support
Date: Tue, 2 Oct 2012 21:59:14 +0200 [thread overview]
Message-ID: <20121002195914.GG21046@lunn.ch> (raw)
In-Reply-To: <CAHkwnC83DcKXZOtLse_xnYe7zOZ5qwGJVimLkBzDwSJ7Y5vL_Q@mail.gmail.com>
> I was thinking to add a more generic helper function like this:
>
> static inline void watchdog_get_dttimeout(struct device_node *node,
> u32 *timeout)
> {
> if (node)
> of_property_read_u32(node, "timeout", &wdd->timeout);
> }
You forgot to change the function signature.
Also, if you are adding a generic function, it should be a generic
function for the framework. All drivers should be slowly moving
towards the framework, so adding functions which help you not move
towards the framework are wrong.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/5] watchdog: at91sam9_wdt: add device tree support
Date: Tue, 2 Oct 2012 21:59:14 +0200 [thread overview]
Message-ID: <20121002195914.GG21046@lunn.ch> (raw)
In-Reply-To: <CAHkwnC83DcKXZOtLse_xnYe7zOZ5qwGJVimLkBzDwSJ7Y5vL_Q@mail.gmail.com>
> I was thinking to add a more generic helper function like this:
>
> static inline void watchdog_get_dttimeout(struct device_node *node,
> u32 *timeout)
> {
> if (node)
> of_property_read_u32(node, "timeout", &wdd->timeout);
> }
You forgot to change the function signature.
Also, if you are adding a generic function, it should be a generic
function for the framework. All drivers should be slowly moving
towards the framework, so adding functions which help you not move
towards the framework are wrong.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Fabio Porcedda <fabio.porcedda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Subject: Re: [PATCH v6 3/5] watchdog: at91sam9_wdt: add device tree support
Date: Tue, 2 Oct 2012 21:59:14 +0200 [thread overview]
Message-ID: <20121002195914.GG21046@lunn.ch> (raw)
In-Reply-To: <CAHkwnC83DcKXZOtLse_xnYe7zOZ5qwGJVimLkBzDwSJ7Y5vL_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> I was thinking to add a more generic helper function like this:
>
> static inline void watchdog_get_dttimeout(struct device_node *node,
> u32 *timeout)
> {
> if (node)
> of_property_read_u32(node, "timeout", &wdd->timeout);
> }
You forgot to change the function signature.
Also, if you are adding a generic function, it should be a generic
function for the framework. All drivers should be slowly moving
towards the framework, so adding functions which help you not move
towards the framework are wrong.
Andrew
next prev parent reply other threads:[~2012-10-02 19:59 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 12:24 [PATCH v6 0/5] watchdog: orion_wdt & at91sam9_wdt: improve dt support Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` [PATCH v6 1/5] watchdog: core: dt: add support for the timeout device tree property Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` [PATCH v6 2/5] watchdog: orion_wdt: dt: add the timeout property binding Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` [PATCH v6 3/5] watchdog: at91sam9_wdt: add device tree support Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:45 ` Andrew Lunn
2012-10-01 12:45 ` Andrew Lunn
2012-10-01 12:45 ` Andrew Lunn
2012-10-01 12:48 ` Fabio Porcedda
2012-10-01 12:48 ` Fabio Porcedda
2012-10-01 12:48 ` Fabio Porcedda
2012-10-01 12:54 ` Fabio Porcedda
2012-10-01 12:54 ` Fabio Porcedda
2012-10-01 12:54 ` Fabio Porcedda
2012-10-01 13:06 ` Andrew Lunn
2012-10-01 13:06 ` Andrew Lunn
2012-10-01 13:06 ` Andrew Lunn
2012-10-02 15:04 ` Fabio Porcedda
2012-10-02 15:04 ` Fabio Porcedda
2012-10-02 15:04 ` Fabio Porcedda
2012-10-02 19:00 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 19:00 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 19:00 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-03 16:32 ` Fabio Porcedda
2012-10-03 16:32 ` Fabio Porcedda
2012-10-03 16:32 ` Fabio Porcedda
2012-10-03 17:47 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-03 17:47 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-03 17:47 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 19:59 ` Andrew Lunn [this message]
2012-10-02 19:59 ` Andrew Lunn
2012-10-02 19:59 ` Andrew Lunn
2012-10-03 16:32 ` Fabio Porcedda
2012-10-03 16:32 ` Fabio Porcedda
2012-10-03 16:32 ` Fabio Porcedda
2012-10-01 12:56 ` Andrew Lunn
2012-10-01 12:56 ` Andrew Lunn
2012-10-01 12:56 ` Andrew Lunn
2012-10-01 12:24 ` [PATCH v6 4/5] ARM: at91/dts: add at91sam9_wdt driver to at91sam926x, at91sam9g45 Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` [PATCH v6 5/5] ARM: at91/dts: evk-pro3: enable watchdog Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
2012-10-01 12:24 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002195914.GG21046@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.porcedda@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.