From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Ortiz, Lance E" <lance.oritz@hp.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Len Brown <len.brown@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [acpi:next 4/5] drivers/acpi/scan.c:328 acpi_device_remove_files() info: redundant null check on
Date: Tue, 02 Oct 2012 20:46:05 +0000 [thread overview]
Message-ID: <20121002204604.GW4587@mwanda> (raw)
In-Reply-To: <A961433CDFF2F640A2866803152E61F950D26B71@G4W3226.americas.hpqcorp.net>
On Tue, Oct 02, 2012 at 06:53:05PM +0000, Ortiz, Lance E wrote:
> Thanks for letting me know. I send out an updated patch removing
> the redundant check. But I am wondering if we should leave it in
> for safety's sake.
There is no safety issue here. kfree() will always accept NULL
pointers. It's cleaner to leave it out.
> Is having a info message like this from smatch a problem?
It's not a problem. We just send you the one email is all.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Ortiz, Lance E" <lance.oritz@hp.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Len Brown <len.brown@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [acpi:next 4/5] drivers/acpi/scan.c:328 acpi_device_remove_files() info: redundant null check on dev->pnp.str_obj calling kfree()
Date: Tue, 2 Oct 2012 23:46:05 +0300 [thread overview]
Message-ID: <20121002204604.GW4587@mwanda> (raw)
In-Reply-To: <A961433CDFF2F640A2866803152E61F950D26B71@G4W3226.americas.hpqcorp.net>
On Tue, Oct 02, 2012 at 06:53:05PM +0000, Ortiz, Lance E wrote:
> Thanks for letting me know. I send out an updated patch removing
> the redundant check. But I am wondering if we should leave it in
> for safety's sake.
There is no safety issue here. kfree() will always accept NULL
pointers. It's cleaner to leave it out.
> Is having a info message like this from smatch a problem?
It's not a problem. We just send you the one email is all.
regards,
dan carpenter
next prev parent reply other threads:[~2012-10-02 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 7:39 [acpi:next 4/5] drivers/acpi/scan.c:328 acpi_device_remove_files() info: redundant null check on dev Fengguang Wu
2012-10-02 7:39 ` [acpi:next 4/5] drivers/acpi/scan.c:328 acpi_device_remove_files() info: redundant null check on dev->pnp.str_obj calling kfree() Fengguang Wu
2012-10-02 18:53 ` [acpi:next 4/5] drivers/acpi/scan.c:328 acpi_device_remove_files() info: redundant null check on Ortiz, Lance E
2012-10-02 18:53 ` [acpi:next 4/5] drivers/acpi/scan.c:328 acpi_device_remove_files() info: redundant null check on dev->pnp.str_obj calling kfree() Ortiz, Lance E
2012-10-02 20:46 ` Dan Carpenter [this message]
2012-10-02 20:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002204604.GW4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lance.oritz@hp.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.