All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv5] ARM: Add Altera SOCFPGA Cyclone5
Date: Wed, 3 Oct 2012 16:13:53 +0200	[thread overview]
Message-ID: <20121003161353.03e34ca8@lilith> (raw)
In-Reply-To: <20121003131145.GA4720@elf.ucw.cz>

Hi Pavel,

On Wed, 3 Oct 2012 15:11:45 +0200, Pavel Machek <pavel@denx.de> wrote:

> Hi!
> 
> > But this one is a mystery. Offending lines are:
> > 
> > #include <netdev.h>
> > 
> > DECLARE_GLOBAL_DATA_PTR;
> > 
> > [line 26:] void show_boot_progress(int progress)
> > {
> >         debug("Boot reached stage %d\n", progress);
> > }
> > 
> > Do we need direct include asm/global_data.h for
> > DECLARE_GLOBAL_DATA_PTR? Is something funny going on with debug()? Is
> > show_boot_progress() a macro in your build? Would it be enough to
> > check out current u-boot-arm to reproduce?
> 
> show_boot_progress() became a macro (for SPL build only, in the tree I
> can see). We can add an ifdef, but perhaps we should just delete the
> function...
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> Thanks,

Can you post a proper V6 patch with history updated?

Amicalement,
-- 
Albert.

  reply	other threads:[~2012-10-03 14:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02 22:45 [U-Boot] [PATCHv5] ARM: Add Altera SOCFPGA Cyclone5 dinguyen at altera.com
2012-10-02 22:33 ` Tom Rini
2012-10-03 11:59   ` Albert ARIBAUD
2012-10-03 12:56     ` Pavel Machek
2012-10-03 13:11       ` Pavel Machek
2012-10-03 14:13         ` Albert ARIBAUD [this message]
2012-10-03 13:11     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121003161353.03e34ca8@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.