Re: [PATCH v1 0/8]: PVH (PV guest with extensions)

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Oct 03, 2012 at 12:11:22PM -0700, Mukesh Rathor wrote:
> On Tue, 2 Oct 2012 10:35:28 +0100
> Ian Campbell <Ian.Campbell@citrix.com> wrote:
> 
> > On Mon, 2012-10-01 at 22:28 +0100, Mukesh Rathor wrote:
> > > On Tue, 25 Sep 2012 14:54:23 +0100
> > > Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > > 
> > > > On Fri, 2012-09-21 at 20:12 +0100, Mukesh Rathor wrote:
> > > > > Hi guys,
> > > > > 
> > > > > Ok, I've made all the changes from prev RFC patch submission.
> > > > 
> > > > Did I miss the patch with the changes to arch/x86/xen/xen-head.S
> > > > which declare the features which are used here as supported by
> > > > the kernel image?
> > > > 
> > > > Ian.
> > > > 
> > > 
> > > Strange, adding following to head.S
> > > 
> > >         ELFNOTE(Xen, XEN_ELFNOTE_PADDR_OFFSET,   _ASM_PTR 0)
> > >         ELFNOTE(Xen, XEN_ELFNOTE_GUEST_PVH, .long 1)  <--------
> > > 
> > > and xenstore won't start in dom0. What gives?
> > 
> > I have no idea, I can't think of any way that xenstored would be able
> > to even see the notes given in the dom0 kernel image.
> > 
> > Are you sure you only that one exact change?
> 
> You Ok with XEN_ELFNOTE_GUEST_PVH, or should I call it
> XEN_ELFNOTE_PV_EXTENSIONS. Please LMK.

XEN_ELFNOTE_PVH_FEATURES ?

That way you can fill it with different 'features' flags
if need to. Say 1<<1 is basic, etc.


> 
> tanks
> Mukesh