* Remove noisy printks from llcp_sock_connect
@ 2012-10-04 19:51 Dave Jones
2012-10-04 19:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2012-10-04 19:51 UTC (permalink / raw)
To: netdev; +Cc: lauro.venancio, aloisio.almeida, sameo
Validation of userspace input shouldn't trigger dmesg spamming.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c
index 40f056d..63e4cdc 100644
--- a/net/nfc/llcp/sock.c
+++ b/net/nfc/llcp/sock.c
@@ -497,15 +497,11 @@ static int llcp_sock_connect(struct socket *sock, struct sockaddr *_addr,
pr_debug("sock %p sk %p flags 0x%x\n", sock, sk, flags);
if (!addr || len < sizeof(struct sockaddr_nfc) ||
- addr->sa_family != AF_NFC) {
- pr_err("Invalid socket\n");
+ addr->sa_family != AF_NFC)
return -EINVAL;
- }
- if (addr->service_name_len == 0 && addr->dsap == 0) {
- pr_err("Missing service name or dsap\n");
+ if (addr->service_name_len == 0 && addr->dsap == 0)
return -EINVAL;
- }
pr_debug("addr dev_idx=%u target_idx=%u protocol=%u\n", addr->dev_idx,
addr->target_idx, addr->nfc_protocol);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Remove noisy printks from llcp_sock_connect
2012-10-04 19:51 Remove noisy printks from llcp_sock_connect Dave Jones
@ 2012-10-04 19:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-10-04 19:59 UTC (permalink / raw)
To: davej; +Cc: netdev, lauro.venancio, aloisio.almeida, sameo
From: Dave Jones <davej@redhat.com>
Date: Thu, 4 Oct 2012 15:51:11 -0400
> Validation of userspace input shouldn't trigger dmesg spamming.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Applied, thanks Dave.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-04 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 19:51 Remove noisy printks from llcp_sock_connect Dave Jones
2012-10-04 19:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.