From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Konstantin Khlebnikov
<khlebnikov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 1/2] mm: memcontrol: handle potential crash when rmap races with task exit
Date: Thu, 4 Oct 2012 16:19:08 -0400 [thread overview]
Message-ID: <20121004201908.GA2625@cmpxchg.org> (raw)
In-Reply-To: <20121004184958.GG27536-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
On Thu, Oct 04, 2012 at 08:49:58PM +0200, Michal Hocko wrote:
> On Thu 04-10-12 14:09:16, Johannes Weiner wrote:
> > page_referenced() counts only references of mm's that are associated
> > with the memcg hierarchy that is being reclaimed. However, if it
> > races with the owner of the mm exiting, mm->owner may be NULL. Don't
> > crash, just ignore the reference.
>
> This seems to be fixed by Hugh's patch 3a981f48 "memcg: fix use_hierarchy
> css_is_ancestor oops regression" which seems to be merged already.
And look who acked the patch. I'll show myself out...
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] mm: memcontrol: handle potential crash when rmap races with task exit
Date: Thu, 4 Oct 2012 16:19:08 -0400 [thread overview]
Message-ID: <20121004201908.GA2625@cmpxchg.org> (raw)
In-Reply-To: <20121004184958.GG27536@dhcp22.suse.cz>
On Thu, Oct 04, 2012 at 08:49:58PM +0200, Michal Hocko wrote:
> On Thu 04-10-12 14:09:16, Johannes Weiner wrote:
> > page_referenced() counts only references of mm's that are associated
> > with the memcg hierarchy that is being reclaimed. However, if it
> > races with the owner of the mm exiting, mm->owner may be NULL. Don't
> > crash, just ignore the reference.
>
> This seems to be fixed by Hugh's patch 3a981f48 "memcg: fix use_hierarchy
> css_is_ancestor oops regression" which seems to be merged already.
And look who acked the patch. I'll show myself out...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] mm: memcontrol: handle potential crash when rmap races with task exit
Date: Thu, 4 Oct 2012 16:19:08 -0400 [thread overview]
Message-ID: <20121004201908.GA2625@cmpxchg.org> (raw)
In-Reply-To: <20121004184958.GG27536@dhcp22.suse.cz>
On Thu, Oct 04, 2012 at 08:49:58PM +0200, Michal Hocko wrote:
> On Thu 04-10-12 14:09:16, Johannes Weiner wrote:
> > page_referenced() counts only references of mm's that are associated
> > with the memcg hierarchy that is being reclaimed. However, if it
> > races with the owner of the mm exiting, mm->owner may be NULL. Don't
> > crash, just ignore the reference.
>
> This seems to be fixed by Hugh's patch 3a981f48 "memcg: fix use_hierarchy
> css_is_ancestor oops regression" which seems to be merged already.
And look who acked the patch. I'll show myself out...
next prev parent reply other threads:[~2012-10-04 20:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 18:09 [patch 0/2] memcg fixups that fell through cracks in 3.5 Johannes Weiner
2012-10-04 18:09 ` Johannes Weiner
2012-10-04 18:09 ` Johannes Weiner
2012-10-04 18:09 ` [patch 1/2] mm: memcontrol: handle potential crash when rmap races with task exit Johannes Weiner
2012-10-04 18:09 ` Johannes Weiner
2012-10-04 18:49 ` Michal Hocko
2012-10-04 18:49 ` Michal Hocko
[not found] ` <20121004184958.GG27536-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-10-04 20:19 ` Johannes Weiner [this message]
2012-10-04 20:19 ` Johannes Weiner
2012-10-04 20:19 ` Johannes Weiner
[not found] ` <20121004201908.GA2625-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-10-05 7:05 ` Michal Hocko
2012-10-05 7:05 ` Michal Hocko
2012-10-05 7:05 ` Michal Hocko
2012-10-04 18:09 ` [patch 2/2] mm: memcg: clean up mm_match_cgroup() signature Johannes Weiner
2012-10-04 18:09 ` Johannes Weiner
[not found] ` <1349374157-20604-3-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-10-05 20:53 ` Andrew Morton
2012-10-05 20:53 ` Andrew Morton
2012-10-05 20:53 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004201908.GA2625@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=khlebnikov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.