All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	dedekind1@gmail.com, vikram186@gmail.com,
	Huang Shijie <b32955@freescale.com>,
	linux-mtd@lists.infradead.org, shawn.guo@linaro.org,
	dwmw2@infradead.org
Subject: Re: [PATCH v2 0/9] add EDO feature for gpmi-nand driver
Date: Thu, 4 Oct 2012 22:56:06 +0200	[thread overview]
Message-ID: <201210042256.06286.marex@denx.de> (raw)
In-Reply-To: <201210042224.30095.marex@denx.de>

Dear Huang Shijie,

> > The ONFI nand supports the EDO (extended data out) feature in
> > asynchronous mode when the host controller(such as gpmi-nand)
> > uses a tRC of less then 30ns.
> > 
> > The gpmi can supports this EDO feature.
> > This patch set adds the EDO support the gpmi-nand driver.
> > 
> > patch 1 ~ patch 2:
> > 	 These two patches provide the infrastructure for the EDO feature.
> > 	 
> >          They add necessary MTD helpers for the ONFI nand set/get
> >          features,
> > 	 
> > 	 and the help to get the supportted timing mode.
> > 	 These two patches are new version. The init version has been
> > 	 reviewed by Vikram & Florian.
> > 
> > patch 3 ~ patch 7:
> >          These patches are clean-ups for the gpmi-nand's timing code.
> > 	 
> > 	 Also they make the some preparations for the EDO patch.
> > 
> > patch 8: add the EDO feature to the gpmi-nand.
> > 
> > 
> > patch 9: a small optimization for the timing.
> > 
> >          only set the timing registers one time.
> > 
> > I tested this patch set on the IMX6Q-arm2 board with several Micron's
> > ONFI nand chips. Some chips only can supports to mode 4, some chips
> > can supports to mode 5.
> > 
> > The performance is much improved. Take Micron MT29F32G08MAA for example
> 
> > (in mode 5, 100MHz):
> [...]
> 
> Was this ever tested on something else than mx6q? I suspect these broke
> gpmi nand on mx28. Can you please verify?

Hm, this series isnt the problematic one ... poking further ... I recall next 
20120921 worked fine.

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/9] add EDO feature for gpmi-nand driver
Date: Thu, 4 Oct 2012 22:56:06 +0200	[thread overview]
Message-ID: <201210042256.06286.marex@denx.de> (raw)
In-Reply-To: <201210042224.30095.marex@denx.de>

Dear Huang Shijie,

> > The ONFI nand supports the EDO (extended data out) feature in
> > asynchronous mode when the host controller(such as gpmi-nand)
> > uses a tRC of less then 30ns.
> > 
> > The gpmi can supports this EDO feature.
> > This patch set adds the EDO support the gpmi-nand driver.
> > 
> > patch 1 ~ patch 2:
> > 	 These two patches provide the infrastructure for the EDO feature.
> > 	 
> >          They add necessary MTD helpers for the ONFI nand set/get
> >          features,
> > 	 
> > 	 and the help to get the supportted timing mode.
> > 	 These two patches are new version. The init version has been
> > 	 reviewed by Vikram & Florian.
> > 
> > patch 3 ~ patch 7:
> >          These patches are clean-ups for the gpmi-nand's timing code.
> > 	 
> > 	 Also they make the some preparations for the EDO patch.
> > 
> > patch 8: add the EDO feature to the gpmi-nand.
> > 
> > 
> > patch 9: a small optimization for the timing.
> > 
> >          only set the timing registers one time.
> > 
> > I tested this patch set on the IMX6Q-arm2 board with several Micron's
> > ONFI nand chips. Some chips only can supports to mode 4, some chips
> > can supports to mode 5.
> > 
> > The performance is much improved. Take Micron MT29F32G08MAA for example
> 
> > (in mode 5, 100MHz):
> [...]
> 
> Was this ever tested on something else than mx6q? I suspect these broke
> gpmi nand on mx28. Can you please verify?

Hm, this series isnt the problematic one ... poking further ... I recall next 
20120921 worked fine.

Best regards,
Marek Vasut

  reply	other threads:[~2012-10-04 20:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  6:57 [PATCH v2 0/9] add EDO feature for gpmi-nand driver Huang Shijie
2012-09-13  6:57 ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 1/9] mtd: add helpers to set/get features for ONFI nand Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 2/9] mtd: add helpers to get the supportted ONFI timing mode Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 3/9] mtd: gpmi: add a new field for HW_GPMI_TIMING1 Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 4/9] mtd: gpmi: do not get the clock frequency in gpmi_begin() Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 5/9] mtd: gpmi: add a new field for HW_GPMI_CTRL1 Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 6/9] mtd: gpmi: simplify the setting DLL code Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 7/9] mtd: gpmi: do not set the default values for the extra clocks Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:57 ` [PATCH v2 8/9] mtd: gpmi: add EDO feature for imx6q Huang Shijie
2012-09-13  6:57   ` Huang Shijie
2012-09-13  6:58 ` [PATCH v2 9/9] mtd: gpmi: initialize the timing registers only one time Huang Shijie
2012-09-13  6:58   ` Huang Shijie
2012-09-26  8:17 ` [PATCH v2 0/9] add EDO feature for gpmi-nand driver Artem Bityutskiy
2012-09-26  8:17   ` Artem Bityutskiy
2012-10-04 20:24 ` Marek Vasut
2012-10-04 20:24   ` Marek Vasut
2012-10-04 20:56   ` Marek Vasut [this message]
2012-10-04 20:56     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210042256.06286.marex@denx.de \
    --to=marex@denx.de \
    --cc=b32955@freescale.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shawn.guo@linaro.org \
    --cc=vikram186@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.