All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] sylpheed: Fix includedir
Date: Mon, 8 Oct 2012 11:01:13 +0200	[thread overview]
Message-ID: <20121008110113.3032157c@skate> (raw)
In-Reply-To: <1349649599-12615-1-git-send-email-gvaxon@gmail.com>

Dear Valentine Barshak,

On Mon,  8 Oct 2012 02:39:59 +0400, Valentine Barshak wrote:
> The sylpheed headers are installed to $(DESTDIR)$(includedir),
> while DESTDIR is $(TARGET_DIR) and includedir is set to
> $(STAGING_DIR)/usr/include in the SYLPHEED_CONF_OPT.
> Thus, the full staging directory path is created in the
> target root filesystem, which is wrong.
> 
> The includedir was set to staging include because sylpheed
> incorrectly adds includedir to its include path, and does
> not cross-compile with the default includedir set to
> /usr/include.
> 
> This removes includedir setting and also removes it from
> include paths in Makefiles to prevent using host headers
> from /usr/include. The same approach is used in the OE.
> 
> Signed-off-by: Valentine Barshak <gvaxon@gmail.com>

If you have the time, it would be great to submit a patch to the
upstream project in order to fix this problem.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2012-10-08  9:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07 22:39 [Buildroot] [PATCH v3] sylpheed: Fix includedir Valentine Barshak
2012-10-08  7:32 ` Arnout Vandecappelle
2012-10-08  9:01 ` Thomas Petazzoni [this message]
2012-10-08 18:37   ` Valentine Barshak
2012-10-10 12:58   ` Valentine Barshak
2012-10-10 14:42     ` Peter Korsgaard
2012-10-08 19:40 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121008110113.3032157c@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.